To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/release
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 237.7.290
- compare with another revision
- download diff
- download tarball
- view history from revision 237.7.290
- Committer: Teddy Hogeborn
- Date: 2015-03-10 18:03:38 UTC
- mto: (237.7.304 trunk)
- mto: This revision was merged to the branch mainline in revision 325.
- Revision ID: teddy@recompile.se-20150310180338-pcxw6r2qmw9k6br9
Add ":!RSA" to GnuTLS priority string, to disallow non-DHE kx.
If Mandos was somehow made to use a non-ephemeral Diffie-Hellman key
exchange algorithm in the TLS handshake, any saved network traffic
could then be decrypted later if the Mandos client key was obtained.
By default, Mandos uses ephemeral DH key exchanges which does not have
this problem, but a non-ephemeral key exchange algorithm was still
enabled by default. The simplest solution is to simply turn that off,
which ensures that Mandos will always use ephemeral DH key exchanges.
There is a "PFS" priority string specifier, but we can't use it because:
1. Security-wise, it is a mix between "NORMAL" and "SECURE128" - it
enables a lot more algorithms than "SECURE256".
2. It is only available since GnuTLS 3.2.4.
Thanks to Andreas Fischer <af@bantuX.org> for reporting this issue.
If Mandos was somehow made to use a non-ephemeral Diffie-Hellman key
exchange algorithm in the TLS handshake, any saved network traffic
could then be decrypted later if the Mandos client key was obtained.
By default, Mandos uses ephemeral DH key exchanges which does not have
this problem, but a non-ephemeral key exchange algorithm was still
enabled by default. The simplest solution is to simply turn that off,
which ensures that Mandos will always use ephemeral DH key exchanges.
There is a "PFS" priority string specifier, but we can't use it because:
1. Security-wise, it is a mix between "NORMAL" and "SECURE128" - it
enables a lot more algorithms than "SECURE256".
2. It is only available since GnuTLS 3.2.4.
Thanks to Andreas Fischer <af@bantuX.org> for reporting this issue.
- files added:
- initramfs-tools-hook-conf
- files removed:
- bugs.xml
- debian/tests
- dracut-module
- plugin-helpers
- files modified:
- .bzrignore
added
removed
plugin-runner.c
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008-2022 Teddy Hogeborn
6
* Copyright © 2008-2022 Björn Påhlsson
7
*
8
* This file is part of Mandos.
9
*
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
14
*
15
* Mandos is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2014 Teddy Hogeborn
6
* Copyright © 2008-2014 Björn Påhlsson
7
*
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
12
*
13
* This program is distributed in the hope that it will be useful, but
16
14
* WITHOUT ANY WARRANTY; without even the implied warranty of
17
15
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
18
16
* General Public License for more details.
19
17
*
20
18
* You should have received a copy of the GNU General Public License
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
22
21
*
23
22
* Contact the authors at <mandos@recompile.se>.
24
23
*/
25
24
26
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
27
getline(), asprintf(), O_CLOEXEC,
28
scandirat(), pipe2() */
29
#include <argp.h> /* argp_program_version,
30
argp_program_bug_address,
31
struct argp_option,
32
struct argp_state, argp_error(),
33
ARGP_NO_EXIT, argp_state_help,
34
ARGP_HELP_STD_HELP,
35
ARGP_HELP_USAGE, ARGP_HELP_EXIT_OK,
36
ARGP_KEY_ARG, ARGP_ERR_UNKNOWN,
37
struct argp, argp_parse(),
38
ARGP_IN_ORDER, ARGP_NO_HELP */
39
#include <stdbool.h> /* bool, false, true */
40
#include <sys/types.h> /* pid_t, sig_atomic_t, uid_t, gid_t,
41
getuid(), setgid(), setuid() */
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
O_CLOEXEC, pipe2() */
42
27
#include <stddef.h> /* size_t, NULL */
43
#include <iso646.h> /* or, and, not */
44
#include <string.h> /* strcmp(), strdup(), strchrnul(),
45
strncmp(), strlen(), strcpy(),
46
strsep(), strchr(), strsignal() */
47
#include <stdlib.h> /* malloc(), free(), reallocarray(),
48
realloc(), EXIT_SUCCESS */
49
#include <errno.h> /* errno, EINTR, ENOMEM, ECHILD,
50
error_t, EINVAL, EMFILE, ENFILE,
51
ENOENT, ESRCH */
52
#include <stdint.h> /* SIZE_MAX */
53
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
54
getline(), asprintf(), O_CLOEXEC,
55
scandirat(), pipe2() */
56
#include <unistd.h> /* TEMP_FAILURE_RETRY(), ssize_t,
57
write(), STDOUT_FILENO, uid_t,
58
gid_t, getuid(), fchown(), close(),
59
symlink(), setgid(), setuid(),
60
faccessat(), X_OK, pipe(), pipe2(),
61
fork(), _exit(), dup2(), fexecve(),
62
read(), getpass() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
realloc() */
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
34
WIFEXITED(), WEXITSTATUS(), wait(),
35
pid_t, uid_t, gid_t, getuid(),
36
getgid() */
37
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
38
FD_SET(), FD_ISSET(), FD_CLR */
39
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
40
WEXITSTATUS(), WTERMSIG(),
41
WCOREDUMP() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
51
*/
63
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
64
FD_CLOEXEC, open(), O_RDONLY,
65
O_CLOEXEC, openat() */
66
#include <sys/wait.h> /* waitpid(), WNOHANG, WIFEXITED(),
67
WEXITSTATUS(), WIFSIGNALED(),
68
WTERMSIG(), wait() */
69
#include <error.h> /* error() */
70
#include <stdio.h> /* FILE, fprintf(), fopen(),
71
getline(), fclose(), EOF,
72
asprintf(), stderr */
73
#include <dirent.h> /* struct dirent, scandirat(),
74
alphasort() */
75
#include <sys/stat.h> /* struct stat, fstat(), S_ISDIR(),
76
lstat(), S_ISREG() */
77
#include <sys/select.h> /* fd_set, FD_ZERO(), FD_SETSIZE,
78
FD_SET(), select(), FD_CLR(),
79
FD_ISSET() */
80
#include <signal.h> /* struct sigaction, SA_NOCLDSTOP,
81
sigemptyset(), sigaddset(),
82
SIGCHLD, sigprocmask(), SIG_BLOCK,
83
SIG_UNBLOCK, kill(), SIGTERM */
53
FD_CLOEXEC, openat(), scandirat(),
54
pipe2() */
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
57
#include <errno.h> /* errno */
58
#include <argp.h> /* struct argp_option, struct
59
argp_state, struct argp,
60
argp_parse(), ARGP_ERR_UNKNOWN,
61
ARGP_KEY_END, ARGP_KEY_ARG,
62
error_t */
63
#include <signal.h> /* struct sigaction, sigemptyset(),
64
sigaddset(), sigaction(),
65
sigprocmask(), SIG_BLOCK, SIGCHLD,
66
SIG_UNBLOCK, kill(), sig_atomic_t
67
*/
68
#include <errno.h> /* errno, EBADF */
69
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
84
70
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
85
71
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
86
#include <inttypes.h> /* intmax_t, strtoimax(), PRIdMAX */
87
#include <fnmatch.h> /* fnmatch(), FNM_FILE_NAME,
88
FNM_PERIOD, FNM_NOMATCH */
72
#include <errno.h> /* errno */
73
#include <error.h> /* error() */
74
#include <fnmatch.h> /* fnmatch() */
89
75
90
76
#define BUFFER_SIZE 256
91
77
92
78
#define PDIR "/lib/mandos/plugins.d"
93
#define PHDIR "/lib/mandos/plugin-helpers"
94
79
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
95
80
96
81
const char *argp_program_version = "plugin-runner " VERSION;
193
178
/* Resize the pointed-to array to hold one more pointer */
194
179
char **new_array = NULL;
195
180
do {
196
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
197
new_array = reallocarray(*array, (size_t)((*len) + 2),
198
sizeof(char *));
199
#else
200
if(((size_t)((*len) + 2)) > (SIZE_MAX / sizeof(char *))){
201
/* overflow */
202
new_array = NULL;
203
errno = ENOMEM;
204
} else {
205
new_array = realloc(*array, (size_t)((*len) + 2)
206
* sizeof(char *));
207
}
208
#endif
181
new_array = realloc(*array, sizeof(char *)
182
* (size_t) ((*len) + 2));
209
183
} while(new_array == NULL and errno == EINTR);
210
184
/* Malloc check */
211
185
if(new_array == NULL){
338
312
__attribute__((nonnull))
339
313
static void free_plugin(plugin *plugin_node){
340
314
341
for(char **arg = (plugin_node->argv)+1; *arg != NULL; arg++){
315
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
342
316
free(*arg);
343
317
}
344
free(plugin_node->name);
345
318
free(plugin_node->argv);
346
319
for(char **env = plugin_node->environ; *env != NULL; env++){
347
320
free(*env);
374
347
375
348
int main(int argc, char *argv[]){
376
349
char *plugindir = NULL;
377
char *pluginhelperdir = NULL;
378
350
char *argfile = NULL;
379
351
FILE *conffp;
380
352
struct dirent **direntries = NULL;
442
414
.doc = "Group ID the plugins will run as", .group = 3 },
443
415
{ .name = "debug", .key = 132,
444
416
.doc = "Debug mode", .group = 4 },
445
{ .name = "plugin-helper-dir", .key = 133,
446
.arg = "DIRECTORY",
447
.doc = "Specify a different plugin helper directory",
448
.group = 2 },
449
417
/*
450
418
* These reproduce what we would get without ARGP_NO_HELP
451
419
*/
577
545
case 132: /* --debug */
578
546
debug = true;
579
547
break;
580
case 133: /* --plugin-helper-dir */
581
free(pluginhelperdir);
582
pluginhelperdir = strdup(arg);
583
if(pluginhelperdir != NULL){
584
errno = 0;
585
}
586
break;
587
548
/*
588
549
* These reproduce what we would get without ARGP_NO_HELP
589
550
*/
590
551
case '?': /* --help */
591
552
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
592
553
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
593
__builtin_unreachable();
594
554
case -3: /* --usage */
595
555
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
596
556
argp_state_help(state, state->out_stream,
597
557
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
598
__builtin_unreachable();
599
558
case 'V': /* --version */
600
559
fprintf(state->out_stream, "%s\n", argp_program_version);
601
560
exit(EXIT_SUCCESS);
611
570
if(arg[0] == '\0'){
612
571
break;
613
572
}
614
#if __GNUC__ >= 7
615
__attribute__((fallthrough));
616
#else
617
/* FALLTHROUGH */
618
#endif
619
573
default:
620
574
return ARGP_ERR_UNKNOWN;
621
575
}
647
601
case 130: /* --userid */
648
602
case 131: /* --groupid */
649
603
case 132: /* --debug */
650
case 133: /* --plugin-helper-dir */
651
604
case '?': /* --help */
652
605
case -3: /* --usage */
653
606
case 'V': /* --version */
733
686
734
687
custom_argc += 1;
735
688
{
736
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
737
char **new_argv = reallocarray(custom_argv,
738
(size_t)custom_argc + 1,
739
sizeof(char *));
740
#else
741
char **new_argv = NULL;
742
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
743
/* overflow */
744
errno = ENOMEM;
745
} else {
746
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
747
* sizeof(char *));
748
}
749
#endif
689
char **new_argv = realloc(custom_argv, sizeof(char *)
690
* ((unsigned int)
691
custom_argc + 1));
750
692
if(new_argv == NULL){
751
error(0, errno, "reallocarray");
693
error(0, errno, "realloc");
752
694
exitstatus = EX_OSERR;
753
695
free(new_arg);
754
696
free(org_line);
819
761
goto fallback;
820
762
}
821
763
822
{
823
char *pluginhelperenv;
824
bool bret = true;
825
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
826
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
827
if(ret != -1){
828
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
829
}
830
if(ret == -1 or not bret){
831
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
832
" environment variable to \"%s\" for all plugins\n",
833
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
834
}
835
if(ret != -1){
836
free(pluginhelperenv);
837
}
838
}
839
840
764
if(debug){
841
for(plugin *p = plugin_list; p != NULL; p = p->next){
765
for(plugin *p = plugin_list; p != NULL; p=p->next){
842
766
fprintf(stderr, "Plugin: %s has %d arguments\n",
843
767
p->name ? p->name : "Global", p->argc - 1);
844
768
for(char **a = p->argv; *a != NULL; a++){
853
777
854
778
if(getuid() == 0){
855
779
/* Work around Debian bug #633582:
856
<https://bugs.debian.org/633582> */
780
<http://bugs.debian.org/633582> */
857
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
858
782
if(plugindir_fd == -1){
859
783
if(errno != ENOENT){
871
795
}
872
796
}
873
797
}
874
close(plugindir_fd);
875
}
876
877
/* Work around Debian bug #981302
878
<https://bugs.debian.org/981302> */
879
if(lstat("/dev/fd", &st) != 0 and errno == ENOENT){
880
ret = symlink("/proc/self/fd", "/dev/fd");
881
if(ret == -1){
882
error(0, errno, "Failed to create /dev/fd symlink");
883
}
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
884
799
}
885
800
}
886
801
945
860
return 1;
946
861
}
947
862
863
#ifdef __GLIBC__
864
#if __GLIBC_PREREQ(2, 15)
948
865
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
949
866
alphasort);
867
#else /* not __GLIBC_PREREQ(2, 15) */
868
int numplugins = scandir(plugindir != NULL ? plugindir : PDIR,
869
&direntries, good_name, alphasort);
870
#endif /* not __GLIBC_PREREQ(2, 15) */
871
#else /* not __GLIBC__ */
872
int numplugins = scandir(plugindir != NULL ? plugindir : PDIR,
873
&direntries, good_name, alphasort);
874
#endif /* not __GLIBC__ */
950
875
if(numplugins == -1){
951
876
error(0, errno, "Could not scan plugin dir");
952
877
direntries = NULL;
968
893
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
969
894
if(ret == -1){
970
895
error(0, errno, "stat");
971
close(plugin_fd);
896
TEMP_FAILURE_RETRY(close(plugin_fd));
972
897
free(direntries[i]);
973
898
continue;
974
899
}
983
908
plugindir != NULL ? plugindir : PDIR,
984
909
direntries[i]->d_name);
985
910
}
986
close(plugin_fd);
911
TEMP_FAILURE_RETRY(close(plugin_fd));
987
912
free(direntries[i]);
988
913
continue;
989
914
}
991
916
plugin *p = getplugin(direntries[i]->d_name);
992
917
if(p == NULL){
993
918
error(0, errno, "getplugin");
994
close(plugin_fd);
919
TEMP_FAILURE_RETRY(close(plugin_fd));
995
920
free(direntries[i]);
996
921
continue;
997
922
}
1000
925
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
1001
926
direntries[i]->d_name);
1002
927
}
1003
close(plugin_fd);
928
TEMP_FAILURE_RETRY(close(plugin_fd));
1004
929
free(direntries[i]);
1005
930
continue;
1006
931
}
1046
971
if(pipefd[0] >= FD_SETSIZE){
1047
972
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1048
973
FD_SETSIZE);
1049
close(pipefd[0]);
1050
close(pipefd[1]);
974
TEMP_FAILURE_RETRY(close(pipefd[0]));
975
TEMP_FAILURE_RETRY(close(pipefd[1]));
1051
976
exitstatus = EX_OSERR;
1052
977
free(direntries[i]);
1053
978
goto fallback;
1057
982
ret = set_cloexec_flag(pipefd[0]);
1058
983
if(ret < 0){
1059
984
error(0, errno, "set_cloexec_flag");
1060
close(pipefd[0]);
1061
close(pipefd[1]);
985
TEMP_FAILURE_RETRY(close(pipefd[0]));
986
TEMP_FAILURE_RETRY(close(pipefd[1]));
1062
987
exitstatus = EX_OSERR;
1063
988
free(direntries[i]);
1064
989
goto fallback;
1066
991
ret = set_cloexec_flag(pipefd[1]);
1067
992
if(ret < 0){
1068
993
error(0, errno, "set_cloexec_flag");
1069
close(pipefd[0]);
1070
close(pipefd[1]);
994
TEMP_FAILURE_RETRY(close(pipefd[0]));
995
TEMP_FAILURE_RETRY(close(pipefd[1]));
1071
996
exitstatus = EX_OSERR;
1072
997
free(direntries[i]);
1073
998
goto fallback;
1092
1017
error(0, errno, "fork");
1093
1018
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1094
1019
&sigchld_action.sa_mask, NULL));
1095
close(pipefd[0]);
1096
close(pipefd[1]);
1020
TEMP_FAILURE_RETRY(close(pipefd[0]));
1021
TEMP_FAILURE_RETRY(close(pipefd[1]));
1097
1022
exitstatus = EX_OSERR;
1098
1023
free(direntries[i]);
1099
1024
goto fallback;
1127
1052
/* no return */
1128
1053
}
1129
1054
/* Parent process */
1130
close(pipefd[1]); /* Close unused write end of pipe */
1131
close(plugin_fd);
1055
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1056
pipe */
1057
TEMP_FAILURE_RETRY(close(plugin_fd));
1132
1058
plugin *new_plugin = getplugin(direntries[i]->d_name);
1133
1059
if(new_plugin == NULL){
1134
1060
error(0, errno, "getplugin");
1146
1072
1147
1073
new_plugin->pid = pid;
1148
1074
new_plugin->fd = pipefd[0];
1149
1150
if(debug){
1151
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1152
new_plugin->name, (intmax_t) (new_plugin->pid));
1153
}
1154
1075
1155
1076
/* Unblock SIGCHLD so signal handler can be run if this process
1156
1077
has already completed */
1157
1078
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1163
1084
goto fallback;
1164
1085
}
1165
1086
1166
FD_SET(new_plugin->fd, &rfds_all);
1087
#if defined (__GNUC__) and defined (__GLIBC__)
1088
#if not __GLIBC_PREREQ(2, 16)
1089
#pragma GCC diagnostic push
1090
#pragma GCC diagnostic ignored "-Wsign-conversion"
1091
#endif
1092
#endif
1093
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1094
-Wconversion in GNU libc
1095
before 2.16 */
1096
#if defined (__GNUC__) and defined (__GLIBC__)
1097
#if not __GLIBC_PREREQ(2, 16)
1098
#pragma GCC diagnostic pop
1099
#endif
1100
#endif
1167
1101
1168
1102
if(maxfd < new_plugin->fd){
1169
1103
maxfd = new_plugin->fd;
1172
1106
1173
1107
free(direntries);
1174
1108
direntries = NULL;
1175
close(dir_fd);
1109
TEMP_FAILURE_RETRY(close(dir_fd));
1176
1110
dir_fd = -1;
1177
1111
free_plugin(getplugin(NULL));
1178
1112
1218
1152
(intmax_t) (proc->pid),
1219
1153
WTERMSIG(proc->status),
1220
1154
strsignal(WTERMSIG(proc->status)));
1155
} else if(WCOREDUMP(proc->status)){
1156
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1157
" core\n", proc->name, (intmax_t) (proc->pid));
1221
1158
}
1222
1159
}
1223
1160
1224
1161
/* Remove the plugin */
1225
FD_CLR(proc->fd, &rfds_all);
1162
#if defined (__GNUC__) and defined (__GLIBC__)
1163
#if not __GLIBC_PREREQ(2, 16)
1164
#pragma GCC diagnostic push
1165
#pragma GCC diagnostic ignored "-Wsign-conversion"
1166
#endif
1167
#endif
1168
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1169
-Wconversion in GNU libc
1170
before 2.16 */
1171
#if defined (__GNUC__) and defined (__GLIBC__)
1172
#if not __GLIBC_PREREQ(2, 16)
1173
#pragma GCC diagnostic pop
1174
#endif
1175
#endif
1226
1176
1227
1177
/* Block signal while modifying process_list */
1228
1178
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1268
1218
}
1269
1219
1270
1220
/* This process has not completed. Does it have any output? */
1271
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1221
#if defined (__GNUC__) and defined (__GLIBC__)
1222
#if not __GLIBC_PREREQ(2, 16)
1223
#pragma GCC diagnostic push
1224
#pragma GCC diagnostic ignored "-Wsign-conversion"
1225
#endif
1226
#endif
1227
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1228
warning from
1229
-Wconversion
1230
in GNU libc
1231
before
1232
2.16 */
1233
#if defined (__GNUC__) and defined (__GLIBC__)
1234
#if not __GLIBC_PREREQ(2, 16)
1235
#pragma GCC diagnostic pop
1236
#endif
1237
#endif
1272
1238
/* This process had nothing to say at this time */
1273
1239
proc = proc->next;
1274
1240
continue;
1344
1310
free(direntries);
1345
1311
1346
1312
if(dir_fd != -1){
1347
close(dir_fd);
1313
TEMP_FAILURE_RETRY(close(dir_fd));
1348
1314
}
1349
1315
1350
1316
/* Kill the processes */
1370
1336
free_plugin_list();
1371
1337
1372
1338
free(plugindir);
1373
free(pluginhelperdir);
1374
1339
free(argfile);
1375
1340
1376
1341
return exitstatus;
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0