19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
34
WIFEXITED(), WEXITSTATUS(), wait(),
35
pid_t, uid_t, gid_t, getuid(),
38
37
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
38
FD_SET(), FD_ISSET(), FD_CLR */
40
39
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
40
WEXITSTATUS(), WTERMSIG(),
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
53
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
#include <string.h> /* strsep, strlen(), asprintf() */
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
56
57
#include <errno.h> /* errno */
57
58
#include <argp.h> /* struct argp_option, struct
58
59
argp_state, struct argp,
372
414
.doc = "Group ID the plugins will run as", .group = 3 },
373
415
{ .name = "debug", .key = 132,
374
416
.doc = "Debug mode", .group = 4 },
418
* These reproduce what we would get without ARGP_NO_HELP
420
{ .name = "help", .key = '?',
421
.doc = "Give this help list", .group = -1 },
422
{ .name = "usage", .key = -3,
423
.doc = "Give a short usage message", .group = -1 },
424
{ .name = "version", .key = 'V',
425
.doc = "Print program version", .group = -1 },
378
error_t parse_opt(int key, char *arg, __attribute__((unused))
379
struct argp_state *state) {
429
__attribute__((nonnull(3)))
430
error_t parse_opt(int key, char *arg, struct argp_state *state){
381
435
case 'g': /* --global-options */
384
while((p = strsep(&arg, ",")) != NULL){
388
if(not add_argument(getplugin(NULL), p)){
389
perror("add_argument");
390
return ARGP_ERR_UNKNOWN;
438
while((plugin_option = strsep(&arg, ",")) != NULL){
439
if(not add_argument(getplugin(NULL), plugin_option)){
395
446
case 'G': /* --global-env */
399
if(not add_environment(getplugin(NULL), arg, true)){
400
perror("add_environment");
447
if(add_environment(getplugin(NULL), arg, true)){
403
451
case 'o': /* --options-for */
405
char *p_name = strsep(&arg, ":");
406
if(p_name[0] == '\0' or arg == NULL){
409
char *opt = strsep(&arg, ":");
410
if(opt[0] == '\0' or opt == NULL){
414
while((p = strsep(&opt, ",")) != NULL){
418
if(not add_argument(getplugin(p_name), p)){
419
perror("add_argument");
420
return ARGP_ERR_UNKNOWN;
453
char *option_list = strchr(arg, ':');
454
if(option_list == NULL){
455
argp_error(state, "No colon in \"%s\"", arg);
462
argp_error(state, "Empty plugin name");
467
while((option = strsep(&option_list, ",")) != NULL){
468
if(not add_argument(getplugin(arg), option)){
425
475
case 'E': /* --env-for */
430
477
char *envdef = strchr(arg, ':');
431
478
if(envdef == NULL){
479
argp_error(state, "No colon in \"%s\"", arg);
435
if(not add_environment(getplugin(arg), envdef+1, true)){
436
perror("add_environment");
486
argp_error(state, "Empty plugin name");
490
if(add_environment(getplugin(arg), envdef, true)){
440
495
case 'd': /* --disable */
442
497
plugin *p = getplugin(arg);
444
return ARGP_ERR_UNKNOWN;
449
504
case 'e': /* --enable */
451
506
plugin *p = getplugin(arg);
453
return ARGP_ERR_UNKNOWN;
458
513
case 128: /* --plugin-dir */
460
515
plugindir = strdup(arg);
461
if(plugindir == NULL){
516
if(plugindir != NULL){
465
520
case 129: /* --config-file */
466
521
/* This is already done by parse_opt_config_file() */
468
523
case 130: /* --userid */
469
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
470
if(ret < 1 or tmpmax != (uid_t)tmpmax
471
or arg[numchars] != '\0'){
472
fprintf(stderr, "Bad user ID number: \"%s\", using %"
473
PRIdMAX "\n", arg, (intmax_t)uid);
524
tmp_id = strtoimax(arg, &tmp, 10);
525
if(errno != 0 or tmp == arg or *tmp != '\0'
526
or tmp_id != (uid_t)tmp_id){
527
argp_error(state, "Bad user ID number: \"%s\", using %"
528
PRIdMAX, arg, (intmax_t)uid);
478
534
case 131: /* --groupid */
479
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
480
if(ret < 1 or tmpmax != (gid_t)tmpmax
481
or arg[numchars] != '\0'){
482
fprintf(stderr, "Bad group ID number: \"%s\", using %"
483
PRIdMAX "\n", arg, (intmax_t)gid);
535
tmp_id = strtoimax(arg, &tmp, 10);
536
if(errno != 0 or tmp == arg or *tmp != '\0'
537
or tmp_id != (gid_t)tmp_id){
538
argp_error(state, "Bad group ID number: \"%s\", using %"
539
PRIdMAX, arg, (intmax_t)gid);
488
545
case 132: /* --debug */
549
* These reproduce what we would get without ARGP_NO_HELP
551
case '?': /* --help */
552
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
554
case -3: /* --usage */
555
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
argp_state_help(state, state->out_stream,
557
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
558
case 'V': /* --version */
559
fprintf(state->out_stream, "%s\n", argp_program_version);
492
563
* When adding more options before this line, remember to also add a
493
564
* "case" to the "parse_opt_config_file" function below.
598
679
new_arg = strdup(p);
599
680
if(new_arg == NULL){
601
exitstatus = EXIT_FAILURE;
681
error(0, errno, "strdup");
682
exitstatus = EX_OSERR;
606
687
custom_argc += 1;
607
custom_argv = realloc(custom_argv, sizeof(char *)
608
* ((unsigned int) custom_argc + 1));
609
if(custom_argv == NULL){
611
exitstatus = EXIT_FAILURE;
689
char **new_argv = realloc(custom_argv, sizeof(char *)
692
if(new_argv == NULL){
693
error(0, errno, "realloc");
694
exitstatus = EX_OSERR;
699
custom_argv = new_argv;
615
702
custom_argv[custom_argc-1] = new_arg;
616
custom_argv[custom_argc] = NULL;
703
custom_argv[custom_argc] = NULL;
707
ret = fclose(conffp);
708
} while(ret == EOF and errno == EINTR);
710
error(0, errno, "fclose");
711
exitstatus = EX_IOERR;
621
716
/* Check for harmful errors and go to fallback. Other errors might
622
717
not affect opening plugins */
623
718
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
625
exitstatus = EXIT_FAILURE;
719
error(0, errno, "fopen");
720
exitstatus = EX_OSERR;
629
/* If there was any arguments from configuration file,
630
pass them to parser as command arguments */
724
/* If there were any arguments from the configuration file, pass
725
them to parser as command line arguments */
631
726
if(custom_argv != NULL){
632
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
634
if(ret == ARGP_ERR_UNKNOWN){
635
fprintf(stderr, "Unknown error while parsing arguments\n");
636
exitstatus = EXIT_FAILURE;
727
ret = argp_parse(&argp, custom_argc, custom_argv,
728
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
736
error(0, errno, "argp_parse");
737
exitstatus = EX_OSERR;
740
exitstatus = EX_CONFIG;
641
745
/* Parse actual command line arguments, to let them override the
643
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
644
if(ret == ARGP_ERR_UNKNOWN){
645
fprintf(stderr, "Unknown error while parsing arguments\n");
646
exitstatus = EXIT_FAILURE;
747
ret = argp_parse(&argp, argc, argv,
748
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
756
error(0, errno, "argp_parse");
757
exitstatus = EX_OSERR;
760
exitstatus = EX_USAGE;
664
/* Strip permissions down to nobody */
779
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
if(plugindir_fd == -1){
784
error(0, errno, "open(\"" PDIR "\")");
787
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
789
error(0, errno, "fstat");
791
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
792
ret = fchown(plugindir_fd, uid, gid);
794
error(0, errno, "fchown");
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
802
/* Lower permissions */
805
error(0, errno, "setgid");
665
807
ret = setuid(uid);
674
if(plugindir == NULL){
677
dir = opendir(plugindir);
681
perror("Could not open plugin dir");
682
exitstatus = EXIT_FAILURE;
686
/* Set the FD_CLOEXEC flag on the directory, if possible */
809
error(0, errno, "setuid");
812
/* Open plugin directory with close_on_exec flag */
688
int dir_fd = dirfd(dir);
690
ret = set_cloexec_flag(dir_fd);
692
perror("set_cloexec_flag");
693
exitstatus = EXIT_FAILURE;
814
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
817
#else /* not O_CLOEXEC */
819
#endif /* not O_CLOEXEC */
822
error(0, errno, "Could not open plugin dir");
823
exitstatus = EX_UNAVAILABLE;
828
/* Set the FD_CLOEXEC flag on the directory */
829
ret = set_cloexec_flag(dir_fd);
831
error(0, errno, "set_cloexec_flag");
832
exitstatus = EX_OSERR;
835
#endif /* O_CLOEXEC */
838
int good_name(const struct dirent * const dirent){
839
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
840
"*.dpkg-old", "*.dpkg-bak",
841
"*.dpkg-divert", NULL };
843
#pragma GCC diagnostic push
844
#pragma GCC diagnostic ignored "-Wcast-qual"
846
for(const char **pat = (const char **)patterns;
847
*pat != NULL; pat++){
849
#pragma GCC diagnostic pop
851
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
854
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
855
" matching pattern %s\n", dirent->d_name, *pat);
864
#if __GLIBC_PREREQ(2, 15)
865
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
867
#else /* not __GLIBC_PREREQ(2, 15) */
868
int numplugins = scandir(plugindir != NULL ? plugindir : PDIR,
869
&direntries, good_name, alphasort);
870
#endif /* not __GLIBC_PREREQ(2, 15) */
871
#else /* not __GLIBC__ */
872
int numplugins = scandir(plugindir != NULL ? plugindir : PDIR,
873
&direntries, good_name, alphasort);
874
#endif /* not __GLIBC__ */
875
if(numplugins == -1){
876
error(0, errno, "Could not scan plugin dir");
878
exitstatus = EX_OSERR;
699
882
FD_ZERO(&rfds_all);
701
884
/* Read and execute any executable in the plugin directory*/
703
dirst = readdir(dir);
705
/* All directory entries have been processed */
709
exitstatus = EXIT_FAILURE;
715
d_name_len = strlen(dirst->d_name);
717
/* Ignore dotfiles, backup files and other junk */
719
bool bad_name = false;
721
const char const *bad_prefixes[] = { ".", "#", NULL };
723
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
726
".dpkg-divert", NULL };
727
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
728
size_t pre_len = strlen(*pre);
729
if((d_name_len >= pre_len)
730
and strncmp((dirst->d_name), *pre, pre_len) == 0){
732
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
733
" with bad prefix %s\n", dirst->d_name, *pre);
742
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
743
size_t suf_len = strlen(*suf);
744
if((d_name_len >= suf_len)
745
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
748
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
749
" with bad suffix %s\n", dirst->d_name, *suf);
762
if(plugindir == NULL){
763
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
765
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
885
for(int i = 0; i < numplugins; i++){
887
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
889
error(0, errno, "Could not open plugin");
772
ret = stat(filename, &st);
892
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
894
error(0, errno, "stat");
895
TEMP_FAILURE_RETRY(close(plugin_fd));
779
899
/* Ignore non-executable files */
780
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
900
if(not S_ISREG(st.st_mode)
901
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
782
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
783
" with bad type or mode\n", filename);
904
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
905
" with bad type or mode\n",
906
plugindir != NULL ? plugindir : PDIR,
907
direntries[i]->d_name);
909
TEMP_FAILURE_RETRY(close(plugin_fd));
789
plugin *p = getplugin(dirst->d_name);
913
plugin *p = getplugin(direntries[i]->d_name);
915
error(0, errno, "getplugin");
916
TEMP_FAILURE_RETRY(close(plugin_fd));
797
921
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
922
direntries[i]->d_name);
924
TEMP_FAILURE_RETRY(close(plugin_fd));
807
931
for(char **a = g->argv + 1; *a != NULL; a++){
808
932
if(not add_argument(p, *a)){
809
perror("add_argument");
933
error(0, errno, "add_argument");
812
936
/* Add global environment variables */
813
937
for(char **e = g->environ; *e != NULL; e++){
814
938
if(not add_environment(p, *e, false)){
815
perror("add_environment");
939
error(0, errno, "add_environment");
820
/* If this plugin has any environment variables, we will call
821
using execve and need to duplicate the environment from this
944
/* If this plugin has any environment variables, we need to
945
duplicate the environment from this process, too. */
823
946
if(p->environ[0] != NULL){
824
947
for(char **e = environ; *e != NULL; e++){
825
948
if(not add_environment(p, *e, false)){
826
perror("add_environment");
949
error(0, errno, "add_environment");
956
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
957
#else /* O_CLOEXEC */
958
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
959
#endif /* O_CLOEXEC */
835
exitstatus = EXIT_FAILURE;
961
error(0, errno, "pipe");
962
exitstatus = EX_OSERR;
965
if(pipefd[0] >= FD_SETSIZE){
966
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
968
TEMP_FAILURE_RETRY(close(pipefd[0]));
969
TEMP_FAILURE_RETRY(close(pipefd[1]));
970
exitstatus = EX_OSERR;
838
974
/* Ask OS to automatic close the pipe on exec */
839
975
ret = set_cloexec_flag(pipefd[0]);
841
perror("set_cloexec_flag");
842
exitstatus = EXIT_FAILURE;
977
error(0, errno, "set_cloexec_flag");
978
TEMP_FAILURE_RETRY(close(pipefd[0]));
979
TEMP_FAILURE_RETRY(close(pipefd[1]));
980
exitstatus = EX_OSERR;
845
983
ret = set_cloexec_flag(pipefd[1]);
847
perror("set_cloexec_flag");
848
exitstatus = EXIT_FAILURE;
985
error(0, errno, "set_cloexec_flag");
986
TEMP_FAILURE_RETRY(close(pipefd[0]));
987
TEMP_FAILURE_RETRY(close(pipefd[1]));
988
exitstatus = EX_OSERR;
991
#endif /* not O_CLOEXEC */
851
992
/* Block SIGCHLD until process is safely in process list */
852
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
993
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
994
&sigchld_action.sa_mask,
854
perror("sigprocmask");
855
exitstatus = EXIT_FAILURE;
997
error(0, errno, "sigprocmask");
998
exitstatus = EX_OSERR;
858
1001
/* Starting a new process to be watched */
1005
} while(pid == -1 and errno == EINTR);
862
exitstatus = EXIT_FAILURE;
1007
error(0, errno, "fork");
1008
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1009
&sigchld_action.sa_mask, NULL));
1010
TEMP_FAILURE_RETRY(close(pipefd[0]));
1011
TEMP_FAILURE_RETRY(close(pipefd[1]));
1012
exitstatus = EX_OSERR;
866
1016
/* this is the child process */
867
1017
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1019
error(0, errno, "sigaction");
872
1022
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
874
perror("sigprocmask");
1024
error(0, errno, "sigprocmask");
878
1028
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1030
error(0, errno, "dup2");
885
/* If dir has no file descriptor, we could not set FD_CLOEXEC
886
above and must now close it manually here. */
889
if(p->environ[0] == NULL){
890
if(execv(filename, p->argv) < 0){
895
if(execve(filename, p->argv, p->environ) < 0){
1034
if(fexecve(plugin_fd, p->argv,
1035
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1036
error(0, errno, "fexecve for %s/%s",
1037
plugindir != NULL ? plugindir : PDIR,
1038
direntries[i]->d_name);
902
1043
/* Parent process */
903
close(pipefd[1]); /* Close unused write end of pipe */
905
plugin *new_plugin = getplugin(dirst->d_name);
1044
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1046
TEMP_FAILURE_RETRY(close(plugin_fd));
1047
plugin *new_plugin = getplugin(direntries[i]->d_name);
906
1048
if(new_plugin == NULL){
908
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1049
error(0, errno, "getplugin");
1050
ret = (int)(TEMP_FAILURE_RETRY
1051
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
910
perror("sigprocmask");
1054
error(0, errno, "sigprocmask");
912
exitstatus = EXIT_FAILURE;
1056
exitstatus = EX_OSERR;
950
1112
while(plugin_list){
951
1113
fd_set rfds = rfds_all;
952
1114
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
953
if(select_ret == -1){
955
exitstatus = EXIT_FAILURE;
1115
if(select_ret == -1 and errno != EINTR){
1116
error(0, errno, "select");
1117
exitstatus = EX_OSERR;
958
1120
/* OK, now either a process completed, or something can be read
959
1121
from one of them */
960
1122
for(plugin *proc = plugin_list; proc != NULL;){
961
1123
/* Is this process completely done? */
962
if(proc->eof and proc->completed){
1124
if(proc->completed and proc->eof){
963
1125
/* Only accept the plugin output if it exited cleanly */
964
1126
if(not WIFEXITED(proc->status)
965
1127
or WEXITSTATUS(proc->status) != 0){
966
1128
/* Bad exit by plugin */
969
1131
if(WIFEXITED(proc->status)){
970
fprintf(stderr, "Plugin %" PRIdMAX " exited with status"
971
" %d\n", (intmax_t) (proc->pid),
1132
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1133
" status %d\n", proc->name,
1134
(intmax_t) (proc->pid),
972
1135
WEXITSTATUS(proc->status));
973
} else if(WIFSIGNALED(proc->status)) {
974
fprintf(stderr, "Plugin %" PRIdMAX " killed by signal"
975
" %d\n", (intmax_t) (proc->pid),
976
WTERMSIG(proc->status));
1136
} else if(WIFSIGNALED(proc->status)){
1137
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1138
" signal %d: %s\n", proc->name,
1139
(intmax_t) (proc->pid),
1140
WTERMSIG(proc->status),
1141
strsignal(WTERMSIG(proc->status)));
977
1142
} else if(WCOREDUMP(proc->status)){
978
fprintf(stderr, "Plugin %" PRIdMAX " dumped core\n",
979
(intmax_t) (proc->pid));
1143
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1144
" core\n", proc->name, (intmax_t) (proc->pid));
983
1148
/* Remove the plugin */
984
FD_CLR(proc->fd, &rfds_all);
1149
#if defined (__GNUC__) and defined (__GLIBC__)
1150
#if not __GLIBC_PREREQ(2, 16)
1151
#pragma GCC diagnostic push
1152
#pragma GCC diagnostic ignored "-Wsign-conversion"
1155
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1156
-Wconversion in GNU libc
1158
#if defined (__GNUC__) and defined (__GLIBC__)
1159
#if not __GLIBC_PREREQ(2, 16)
1160
#pragma GCC diagnostic pop
986
1164
/* Block signal while modifying process_list */
987
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1165
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1167
&sigchld_action.sa_mask,
989
perror("sigprocmask");
990
exitstatus = EXIT_FAILURE;
1170
error(0, errno, "sigprocmask");
1171
exitstatus = EX_OSERR;
1016
1198
bool bret = print_out_password(proc->buffer,
1017
1199
proc->buffer_length);
1019
perror("print_out_password");
1020
exitstatus = EXIT_FAILURE;
1201
error(0, errno, "print_out_password");
1202
exitstatus = EX_IOERR;
1025
1207
/* This process has not completed. Does it have any output? */
1026
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1208
#if defined (__GNUC__) and defined (__GLIBC__)
1209
#if not __GLIBC_PREREQ(2, 16)
1210
#pragma GCC diagnostic push
1211
#pragma GCC diagnostic ignored "-Wsign-conversion"
1214
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1220
#if defined (__GNUC__) and defined (__GLIBC__)
1221
#if not __GLIBC_PREREQ(2, 16)
1222
#pragma GCC diagnostic pop
1027
1225
/* This process had nothing to say at this time */
1028
1226
proc = proc->next;
1031
1229
/* Before reading, make the process' data buffer large enough */
1032
1230
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1033
proc->buffer = realloc(proc->buffer, proc->buffer_size
1034
+ (size_t) BUFFER_SIZE);
1035
if(proc->buffer == NULL){
1037
exitstatus = EXIT_FAILURE;
1231
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1232
+ (size_t) BUFFER_SIZE);
1233
if(new_buffer == NULL){
1234
error(0, errno, "malloc");
1235
exitstatus = EX_OSERR;
1238
proc->buffer = new_buffer;
1040
1239
proc->buffer_size += BUFFER_SIZE;
1042
1241
/* Read from the process */
1043
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1242
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1244
+ proc->buffer_length,
1046
1247
/* Read error from this process; ignore the error */
1047
1248
proc = proc->next;