/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to TODO

  • Committer: Teddy Hogeborn
  • Date: 2014-06-14 23:29:00 UTC
  • mto: (237.7.272 trunk)
  • mto: This revision was merged to the branch mainline in revision 317.
  • Revision ID: teddy@recompile.se-20140614232900-vhcywskev4u8rz2d
mandos-client: Fix some bugs on error conditions.

* plugins.d/mandos-client.c (run_network_hooks): Init "dirent" to NULL
                                                 and, later, always
                                                 free() it unless
                                                 scandirat() or
                                                 scandir() failed.
  (main): Fix free() of uninitalized memory in case scandirat() or
          scandir() of "/sys/class/net" failed.  Also, when cleaning
          up, even if GPGME temp directory is empty, do
          free(direntries) and remove the directory.

Show diffs side-by-side

added added

removed removed

Lines of Context:
TODO
1
1
-*- org -*-
2
2
 
3
3
* GIT
4
 
** General: [[https://www.atlassian.com/git/workflows][Git Workflows]], [[http://gitimmersion.com/][Git Immersion]], [[https://news.ycombinator.com/item?id=7036628][Simple git workflow is simple]] [[https://news.ycombinator.com/item?id=9661349][On undoing, fixing, or removing commits in git]]
 
4
** General: [[https://www.atlassian.com/git/workflows][Git Workflows]], [[http://gitimmersion.com/][Git Immersion]], [[https://news.ycombinator.com/item?id=7036628][Simple git workflow is simple]]
5
5
** Intro: [[http://www.eyrie.org/~eagle/notes/debian/git.html#combine][Using Git for Debian Packaging]]
6
6
** Use: [[https://honk.sigxcpu.org/piki/projects/git-buildpackage/][git-buildpackage]]
7
7
** Migration
20
20
* mandos-applet
21
21
 
22
22
* mandos-client
23
 
** TODO [#A] --dh-params=FILE
24
23
** TODO [#B] Use capabilities instead of seteuid().
25
 
   https://forums.grsecurity.net/viewtopic.php?f=7&t=2522
26
24
** TODO [#B] Use getaddrinfo(hints=AI_NUMERICHOST) instead of inet_pton()
27
25
** TODO [#C] Make start_mandos_communication() take "struct server".
28
 
** TODO [#C] --interfaces=regex,eth*,noregex (bridge-utils-interfaces(5))
29
 
** TODO [#C] Remove code for GNU libc < 2.15
30
26
 
31
27
* splashy
32
28
** TODO [#B] use scandir(3) instead of readdir(3)
36
32
** TODO [#B] use scandir(3) instead of readdir(3)
37
33
 
38
34
* askpass-fifo
 
35
** TODO [#B] Drop privileges after opening FIFO.
39
36
 
40
37
* password-prompt
41
38
** TODO [#B] lock stdin (with flock()?)
47
44
* plugin-runner
48
45
** TODO handle printing for errors for plugins
49
46
*** Hook up stderr of plugins, buffer them, and prepend "Mandos Plugin [plugin name]"
 
47
** TODO [#B] use scandirat(3) instead of readdir(3)
 
48
*** Must wait until GNU libc 2.15
50
49
** TODO [#C] use same file name rules as run-parts(8)
51
50
** kernel command line option for debug info
52
 
** TODO [#C] Remove code for GNU libc < 2.15
53
51
 
54
52
* mandos (server)
55
 
** TODO [#B] Work around Avahi issue
56
 
   Avahi does not announce link-local addresses if any global
57
 
   addresses exist: http://lists.freedesktop.org/archives/avahi/2010-March/001863.html
58
 
** TODO [#B] --notify-command
59
 
   This would allow the mandos.service to use
60
 
   --notify-command="systemd-notify --pid READY=1"
61
53
** TODO [#B] Log level                                                    :BUGS:
62
54
*** TODO /etc/mandos/clients.d/*.conf
63
55
    Watch this directory and add/remove/update clients?
79
71
** TODO Use python-tlslite?
80
72
** TODO D-Bus AddClient() method on server object
81
73
** TODO Use org.freedesktop.DBus.Method.NoReply annotation on async methods. :2:
 
74
** TODO Emit [[http://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-properties][org.freedesktop.DBus.Properties.PropertiesChanged]] signal         :2:
 
75
   TODO Deprecate se.recompile.Mandos.Client.PropertyChanged - annotate!
 
76
   TODO Can use "invalidates" annotation to also emit on changed secret.
82
77
** TODO Support [[http://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager][org.freedesktop.DBus.ObjectManager]] interface on server object :2:
83
78
   Deprecate methods GetAllClients(), GetAllClientsWithProperties()
84
79
   and signals ClientAdded and ClientRemoved.
87
82
** TODO Secret Service API?
88
83
   http://standards.freedesktop.org/secret-service/
89
84
** TODO Remove D-Bus interfaces with old domain name                      :2:
90
 
** TODO Remove old string_to_delta format                                    :2:
91
 
** TODO http://0pointer.de/blog/projects/stateless.html
92
 
*** tmpfiles snippet to create /var/lib/mandos with right user+perms
93
 
*** File in /usr/lib/sysusers.d to create user+group "_mandos"
94
 
** TODO Error handling on error parsing config files
95
 
** TODO init.d script error handling
96
 
** TODO D-Bus server properties; address, port, interface, etc.              :2:
97
 
** TODO [#C] In Python 3.3, use shlex.quote() instead of re.escape()
98
 
** TODO [#A] USe systemd Type=dbus
 
85
** TODO Remove old string_to_delta format                                 :2:
 
86
** TODO --no-zeroconf (only valid if port or socket is set)
99
87
 
100
88
* mandos.xml
101
89
** Add mandos contact info in manual pages
103
91
* mandos-ctl
104
92
*** Handle "no D-Bus server" and/or "no Mandos server found" better
105
93
*** [#B] --dump option
106
 
** TODO Remove old string_to_delta format                                    :2:
 
94
** TODO Remove old string_to_delta format                                 :2:
107
95
 
108
96
* TODO mandos-dispatch
109
97
  Listens for specified D-Bus signals and spawns shell commands with
128
116
*** TODO [#C] use same file name rules as run-parts(8)
129
117
*** TODO [#C] Do not install in initrd.img if configured not to.
130
118
    Use "/etc/initramfs-tools/hooksconf.d/mandos"?
131
 
** TODO [#C] $(pkg-config --variable=completionsdir bash-completion)
 
119
** TODO [#C] /etc/bash_completion.d/mandos
132
120
   From XML sources directly?
133
121
 
134
122
* Side Stuff