18
19
* along with this program. If not, see
19
20
* <http://www.gnu.org/licenses/>.
21
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
24
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
27
#include <stddef.h> /* size_t, NULL */
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
30
#include <stdbool.h> /* bool, true, false */
30
#include <stdio.h> /* perror, popen(), fileno(),
31
fprintf(), stderr, STDOUT_FILENO */
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* DIR, fdopendir(), fstat(), struct
33
34
stat, waitpid(), WIFEXITED(),
34
35
WEXITSTATUS(), wait(), pid_t,
35
36
uid_t, gid_t, getuid(), getgid(),
37
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
38
39
FD_SET(), FD_ISSET(), FD_CLR */
39
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG(),
43
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
42
44
#include <iso646.h> /* and, or, not */
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
44
46
readdir(), closedir(), dirfd() */
45
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
46
fcntl(), setuid(), setgid(),
47
F_GETFD, F_SETFD, FD_CLOEXEC,
48
access(), pipe(), fork(), close()
49
dup2, STDOUT_FILENO, _exit(),
50
execv(), write(), read(),
47
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
48
FD_CLOEXEC, write(), STDOUT_FILENO,
49
struct stat, fstat(), close(),
50
setgid(), setuid(), S_ISREG(),
51
faccessat() pipe(), fork(),
52
_exit(), dup2(), fexecve(), read()
52
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
54
#include <string.h> /* strsep, strlen(), asprintf() */
55
FD_CLOEXEC, openat() */
56
#include <string.h> /* strsep, strlen(), strsignal(),
57
strcmp(), strncmp() */
55
58
#include <errno.h> /* errno */
56
59
#include <argp.h> /* struct argp_option, struct
57
60
argp_state, struct argp,
61
64
#include <signal.h> /* struct sigaction, sigemptyset(),
62
65
sigaddset(), sigaction(),
63
66
sigprocmask(), SIG_BLOCK, SIGCHLD,
64
SIG_UNBLOCK, kill() */
67
SIG_UNBLOCK, kill(), sig_atomic_t
65
69
#include <errno.h> /* errno, EBADF */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
71
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
75
#include <fnmatch.h> /* fnmatch() */
67
77
#define BUFFER_SIZE 256
69
79
#define PDIR "/lib/mandos/plugins.d"
70
80
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
72
const char *argp_program_version = "plugin-runner 1.0";
73
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
82
const char *argp_program_version = "plugin-runner " VERSION;
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
77
85
typedef struct plugin{
78
86
char *name; /* can be NULL or any plugin name */
99
107
/* Gets an existing plugin based on name,
100
108
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
101
110
static plugin *getplugin(char *name){
102
/* Check for exiting plugin with that name */
103
for (plugin *p = plugin_list; p != NULL; p = p->next){
104
if ((p->name == name)
105
or (p->name and name and (strcmp(p->name, name) == 0))){
111
/* Check for existing plugin with that name */
112
for(plugin *p = plugin_list; p != NULL; p = p->next){
114
or (p->name and name and (strcmp(p->name, name) == 0))){
109
118
/* Create a new plugin */
110
plugin *new_plugin = malloc(sizeof(plugin));
111
if (new_plugin == NULL){
119
plugin *new_plugin = NULL;
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
123
if(new_plugin == NULL){
114
126
char *copy_name = NULL;
115
127
if(name != NULL){
116
copy_name = strdup(name);
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
117
131
if(copy_name == NULL){
122
*new_plugin = (plugin) { .name = copy_name,
125
.next = plugin_list };
139
*new_plugin = (plugin){ .name = copy_name,
142
.next = plugin_list };
127
new_plugin->argv = malloc(sizeof(char *) * 2);
128
if (new_plugin->argv == NULL){
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
147
if(new_plugin->argv == NULL){
130
150
free(new_plugin);
133
154
new_plugin->argv[0] = copy_name;
134
155
new_plugin->argv[1] = NULL;
136
new_plugin->environ = malloc(sizeof(char *));
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
137
160
if(new_plugin->environ == NULL){
139
163
free(new_plugin->argv);
140
164
free(new_plugin);
143
168
new_plugin->environ[0] = NULL;
370
414
.doc = "Group ID the plugins will run as", .group = 3 },
371
415
{ .name = "debug", .key = 132,
372
416
.doc = "Debug mode", .group = 4 },
418
* These reproduce what we would get without ARGP_NO_HELP
420
{ .name = "help", .key = '?',
421
.doc = "Give this help list", .group = -1 },
422
{ .name = "usage", .key = -3,
423
.doc = "Give a short usage message", .group = -1 },
424
{ .name = "version", .key = 'V',
425
.doc = "Print program version", .group = -1 },
376
error_t parse_opt (int key, char *arg, __attribute__((unused))
377
struct argp_state *state) {
429
__attribute__((nonnull(3)))
430
error_t parse_opt(int key, char *arg, struct argp_state *state){
379
435
case 'g': /* --global-options */
382
while((p = strsep(&arg, ",")) != NULL){
386
if(not add_argument(getplugin(NULL), p)){
387
perror("add_argument");
388
return ARGP_ERR_UNKNOWN;
438
while((plugin_option = strsep(&arg, ",")) != NULL){
439
if(not add_argument(getplugin(NULL), plugin_option)){
393
446
case 'G': /* --global-env */
398
char *envdef = strdup(arg);
402
if(not add_environment(getplugin(NULL), envdef, true)){
403
perror("add_environment");
447
if(add_environment(getplugin(NULL), arg, true)){
407
451
case 'o': /* --options-for */
409
char *p_name = strsep(&arg, ":");
410
if(p_name[0] == '\0' or arg == NULL){
413
char *opt = strsep(&arg, ":");
414
if(opt[0] == '\0' or opt == NULL){
418
while((p = strsep(&opt, ",")) != NULL){
422
if(not add_argument(getplugin(p_name), p)){
423
perror("add_argument");
424
return ARGP_ERR_UNKNOWN;
453
char *option_list = strchr(arg, ':');
454
if(option_list == NULL){
455
argp_error(state, "No colon in \"%s\"", arg);
462
argp_error(state, "Empty plugin name");
467
while((option = strsep(&option_list, ",")) != NULL){
468
if(not add_argument(getplugin(arg), option)){
429
475
case 'E': /* --env-for */
434
477
char *envdef = strchr(arg, ':');
435
478
if(envdef == NULL){
438
char *p_name = strndup(arg, (size_t) (envdef-arg));
479
argp_error(state, "No colon in \"%s\"", arg);
443
if(not add_environment(getplugin(p_name), envdef, true)){
444
perror("add_environment");
486
argp_error(state, "Empty plugin name");
490
if(add_environment(getplugin(arg), envdef, true)){
448
495
case 'd': /* --disable */
450
497
plugin *p = getplugin(arg);
452
return ARGP_ERR_UNKNOWN;
457
504
case 'e': /* --enable */
459
506
plugin *p = getplugin(arg);
461
return ARGP_ERR_UNKNOWN;
466
513
case 128: /* --plugin-dir */
467
515
plugindir = strdup(arg);
468
if(plugindir == NULL){
516
if(plugindir != NULL){
472
520
case 129: /* --config-file */
473
521
/* This is already done by parse_opt_config_file() */
475
523
case 130: /* --userid */
476
uid = (uid_t)strtol(arg, NULL, 10);
524
tmp_id = strtoimax(arg, &tmp, 10);
525
if(errno != 0 or tmp == arg or *tmp != '\0'
526
or tmp_id != (uid_t)tmp_id){
527
argp_error(state, "Bad user ID number: \"%s\", using %"
528
PRIdMAX, arg, (intmax_t)uid);
478
534
case 131: /* --groupid */
479
gid = (gid_t)strtol(arg, NULL, 10);
535
tmp_id = strtoimax(arg, &tmp, 10);
536
if(errno != 0 or tmp == arg or *tmp != '\0'
537
or tmp_id != (gid_t)tmp_id){
538
argp_error(state, "Bad group ID number: \"%s\", using %"
539
PRIdMAX, arg, (intmax_t)gid);
481
545
case 132: /* --debug */
549
* These reproduce what we would get without ARGP_NO_HELP
551
case '?': /* --help */
552
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
554
case -3: /* --usage */
555
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
argp_state_help(state, state->out_stream,
557
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
558
case 'V': /* --version */
559
fprintf(state->out_stream, "%s\n", argp_program_version);
563
* When adding more options before this line, remember to also add a
564
* "case" to the "parse_opt_config_file" function below.
484
566
case ARGP_KEY_ARG:
485
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
567
/* Cryptsetup always passes an argument, which is an empty
568
string if "none" was specified in /etc/crypttab. So if
569
argument was empty, we ignore it silently. */
490
574
return ARGP_ERR_UNKNOWN;
576
return errno; /* Set to 0 at start */
495
579
/* This option parser is the same as parse_opt() above, except it
496
580
ignores everything but the --config-file option. */
497
error_t parse_opt_config_file (int key, char *arg,
498
__attribute__((unused))
499
struct argp_state *state) {
581
error_t parse_opt_config_file(int key, char *arg,
582
__attribute__((unused))
583
struct argp_state *state){
501
586
case 'g': /* --global-options */
502
587
case 'G': /* --global-env */
503
588
case 'o': /* --options-for */
582
679
new_arg = strdup(p);
583
680
if(new_arg == NULL){
585
exitstatus = EXIT_FAILURE;
681
error(0, errno, "strdup");
682
exitstatus = EX_OSERR;
590
687
custom_argc += 1;
591
custom_argv = realloc(custom_argv, sizeof(char *)
592
* ((unsigned int) custom_argc + 1));
593
if(custom_argv == NULL){
595
exitstatus = EXIT_FAILURE;
689
char **new_argv = realloc(custom_argv, sizeof(char *)
692
if(new_argv == NULL){
693
error(0, errno, "realloc");
694
exitstatus = EX_OSERR;
699
custom_argv = new_argv;
599
702
custom_argv[custom_argc-1] = new_arg;
600
custom_argv[custom_argc] = NULL;
703
custom_argv[custom_argc] = NULL;
707
ret = fclose(conffp);
708
} while(ret == EOF and errno == EINTR);
710
error(0, errno, "fclose");
711
exitstatus = EX_IOERR;
605
716
/* Check for harmful errors and go to fallback. Other errors might
606
717
not affect opening plugins */
607
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
609
exitstatus = EXIT_FAILURE;
718
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
719
error(0, errno, "fopen");
720
exitstatus = EX_OSERR;
613
/* If there was any arguments from configuration file,
614
pass them to parser as command arguments */
724
/* If there were any arguments from the configuration file, pass
725
them to parser as command line arguments */
615
726
if(custom_argv != NULL){
616
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
618
if (ret == ARGP_ERR_UNKNOWN){
619
fprintf(stderr, "Unknown error while parsing arguments\n");
620
exitstatus = EXIT_FAILURE;
727
ret = argp_parse(&argp, custom_argc, custom_argv,
728
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
736
error(0, errno, "argp_parse");
737
exitstatus = EX_OSERR;
740
exitstatus = EX_CONFIG;
625
745
/* Parse actual command line arguments, to let them override the
627
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
628
if (ret == ARGP_ERR_UNKNOWN){
629
fprintf(stderr, "Unknown error while parsing arguments\n");
630
exitstatus = EXIT_FAILURE;
747
ret = argp_parse(&argp, argc, argv,
748
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
756
error(0, errno, "argp_parse");
757
exitstatus = EX_OSERR;
760
exitstatus = EX_USAGE;
638
768
for(char **a = p->argv; *a != NULL; a++){
639
769
fprintf(stderr, "\tArg: %s\n", *a);
641
fprintf(stderr, "...and %u environment variables\n", p->envc);
771
fprintf(stderr, "...and %d environment variables\n", p->envc);
642
772
for(char **a = p->environ; *a != NULL; a++){
643
773
fprintf(stderr, "\t%s\n", *a);
648
/* Strip permissions down to nobody */
779
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
if(plugindir_fd == -1){
784
error(0, errno, "open(\"" PDIR "\")");
787
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
789
error(0, errno, "fstat");
791
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
792
ret = fchown(plugindir_fd, uid, gid);
794
error(0, errno, "fchown");
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
802
/* Lower permissions */
805
error(0, errno, "setgid");
649
807
ret = setuid(uid);
658
if (plugindir == NULL){
661
dir = opendir(plugindir);
665
perror("Could not open plugin dir");
666
exitstatus = EXIT_FAILURE;
670
/* Set the FD_CLOEXEC flag on the directory, if possible */
809
error(0, errno, "setuid");
812
/* Open plugin directory with close_on_exec flag */
672
int dir_fd = dirfd(dir);
674
ret = set_cloexec_flag(dir_fd);
676
perror("set_cloexec_flag");
677
exitstatus = EXIT_FAILURE;
814
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
817
#else /* not O_CLOEXEC */
819
#endif /* not O_CLOEXEC */
822
error(0, errno, "Could not open plugin dir");
823
exitstatus = EX_UNAVAILABLE;
828
/* Set the FD_CLOEXEC flag on the directory */
829
ret = set_cloexec_flag(dir_fd);
831
error(0, errno, "set_cloexec_flag");
832
TEMP_FAILURE_RETRY(close(dir_fd));
833
exitstatus = EX_OSERR;
836
#endif /* O_CLOEXEC */
838
dir = fdopendir(dir_fd);
840
error(0, errno, "Could not open plugin dir");
841
TEMP_FAILURE_RETRY(close(dir_fd));
842
exitstatus = EX_OSERR;
685
849
/* Read and execute any executable in the plugin directory*/
687
dirst = readdir(dir);
852
dirst = readdir(dir);
853
} while(dirst == NULL and errno == EINTR);
689
855
/* All directory entries have been processed */
690
856
if(dirst == NULL){
693
exitstatus = EXIT_FAILURE;
858
error(0, errno, "readdir");
859
exitstatus = EX_IOERR;
699
d_name_len = strlen(dirst->d_name);
701
865
/* Ignore dotfiles, backup files and other junk */
703
867
bool bad_name = false;
705
const char const *bad_prefixes[] = { ".", "#", NULL };
707
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
709
".dpkg-divert", NULL };
710
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
711
size_t pre_len = strlen(*pre);
712
if((d_name_len >= pre_len)
713
and strncmp((dirst->d_name), *pre, pre_len) == 0){
715
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
716
" with bad prefix %s\n", dirst->d_name, *pre);
725
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
726
size_t suf_len = strlen(*suf);
727
if((d_name_len >= suf_len)
728
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
731
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
732
" with bad suffix %s\n", dirst->d_name, *suf);
745
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
868
const char * const patterns[] = { ".*", "#*#", "*~",
869
"*.dpkg-new", "*.dpkg-old",
870
"*.dpkg-bak", "*.dpkg-divert",
873
#pragma GCC diagnostic push
874
#pragma GCC diagnostic ignored "-Wcast-qual"
876
for(const char **pat = (const char **)patterns;
877
*pat != NULL; pat++){
879
#pragma GCC diagnostic pop
881
if(fnmatch(*pat, dirst->d_name,
882
FNM_FILE_NAME | FNM_PERIOD) != FNM_NOMATCH){
884
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
885
" matching pattern %s\n", dirst->d_name, *pat);
896
int plugin_fd = openat(dir_fd, dirst->d_name, O_RDONLY |
899
#else /* not O_CLOEXEC */
901
#endif /* not O_CLOEXEC */
904
error(0, errno, "Could not open plugin");
908
/* Set the FD_CLOEXEC flag on the plugin FD */
909
ret = set_cloexec_flag(plugin_fd);
911
error(0, errno, "set_cloexec_flag");
912
TEMP_FAILURE_RETRY(close(plugin_fd));
915
#endif /* O_CLOEXEC */
916
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
918
error(0, errno, "stat");
919
TEMP_FAILURE_RETRY(close(plugin_fd));
751
ret = stat(filename, &st);
758
923
/* Ignore non-executable files */
759
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
924
if(not S_ISREG(st.st_mode)
925
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, dirst->d_name, X_OK,
761
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
762
" with bad type or mode\n", filename);
928
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
929
" with bad type or mode\n",
930
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
932
TEMP_FAILURE_RETRY(close(plugin_fd));
768
936
plugin *p = getplugin(dirst->d_name);
938
error(0, errno, "getplugin");
939
TEMP_FAILURE_RETRY(close(plugin_fd));
786
954
for(char **a = g->argv + 1; *a != NULL; a++){
787
955
if(not add_argument(p, *a)){
788
perror("add_argument");
956
error(0, errno, "add_argument");
791
959
/* Add global environment variables */
792
960
for(char **e = g->environ; *e != NULL; e++){
793
961
if(not add_environment(p, *e, false)){
794
perror("add_environment");
962
error(0, errno, "add_environment");
799
/* If this plugin has any environment variables, we will call
800
using execve and need to duplicate the environment from this
967
/* If this plugin has any environment variables, we need to
968
duplicate the environment from this process, too. */
802
969
if(p->environ[0] != NULL){
803
970
for(char **e = environ; *e != NULL; e++){
804
971
if(not add_environment(p, *e, false)){
805
perror("add_environment");
972
error(0, errno, "add_environment");
814
exitstatus = EXIT_FAILURE;
978
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
980
error(0, errno, "pipe");
981
exitstatus = EX_OSERR;
817
984
/* Ask OS to automatic close the pipe on exec */
818
985
ret = set_cloexec_flag(pipefd[0]);
820
perror("set_cloexec_flag");
821
exitstatus = EXIT_FAILURE;
987
error(0, errno, "set_cloexec_flag");
988
TEMP_FAILURE_RETRY(close(pipefd[0]));
989
TEMP_FAILURE_RETRY(close(pipefd[1]));
990
exitstatus = EX_OSERR;
824
993
ret = set_cloexec_flag(pipefd[1]);
826
perror("set_cloexec_flag");
827
exitstatus = EXIT_FAILURE;
995
error(0, errno, "set_cloexec_flag");
996
TEMP_FAILURE_RETRY(close(pipefd[0]));
997
TEMP_FAILURE_RETRY(close(pipefd[1]));
998
exitstatus = EX_OSERR;
830
1001
/* Block SIGCHLD until process is safely in process list */
831
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1002
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1003
&sigchld_action.sa_mask,
833
perror("sigprocmask");
834
exitstatus = EXIT_FAILURE;
1006
error(0, errno, "sigprocmask");
1007
exitstatus = EX_OSERR;
837
1010
/* Starting a new process to be watched */
1014
} while(pid == -1 and errno == EINTR);
841
exitstatus = EXIT_FAILURE;
1016
error(0, errno, "fork");
1017
exitstatus = EX_OSERR;
845
1021
/* this is the child process */
846
1022
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1024
error(0, errno, "sigaction");
851
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1027
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
853
perror("sigprocmask");
1029
error(0, errno, "sigprocmask");
857
1033
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1035
error(0, errno, "dup2");
863
1039
if(dirfd(dir) < 0){
865
1041
above and must now close it manually here. */
868
if(p->environ[0] == NULL){
869
if(execv(filename, p->argv) < 0){
874
if(execve(filename, p->argv, p->environ) < 0){
1044
if(fexecve(plugin_fd, p->argv,
1045
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1046
error(0, errno, "fexecve for %s/%s",
1047
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
881
1052
/* Parent process */
882
close(pipefd[1]); /* Close unused write end of pipe */
1053
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1055
TEMP_FAILURE_RETRY(close(plugin_fd));
884
1056
plugin *new_plugin = getplugin(dirst->d_name);
885
if (new_plugin == NULL){
887
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1057
if(new_plugin == NULL){
1058
error(0, errno, "getplugin");
1059
ret = (int)(TEMP_FAILURE_RETRY
1060
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
889
perror("sigprocmask");
1063
error(0, errno, "sigprocmask");
891
exitstatus = EXIT_FAILURE;
1065
exitstatus = EX_OSERR;
898
1072
/* Unblock SIGCHLD so signal handler can be run if this process
899
1073
has already completed */
900
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1074
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1075
&sigchld_action.sa_mask,
902
perror("sigprocmask");
903
exitstatus = EXIT_FAILURE;
1078
error(0, errno, "sigprocmask");
1079
exitstatus = EX_OSERR;
907
FD_SET(new_plugin->fd, &rfds_all);
1083
#if defined (__GNUC__) and defined (__GLIBC__)
1084
#if not __GLIBC_PREREQ(2, 16)
1085
#pragma GCC diagnostic push
1086
#pragma GCC diagnostic ignored "-Wsign-conversion"
1089
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1090
-Wconversion in GNU libc
1092
#if defined (__GNUC__) and defined (__GLIBC__)
1093
#if not __GLIBC_PREREQ(2, 16)
1094
#pragma GCC diagnostic pop
909
if (maxfd < new_plugin->fd){
1098
if(maxfd < new_plugin->fd){
910
1099
maxfd = new_plugin->fd;
1103
TEMP_FAILURE_RETRY(closedir(dir));
1105
free_plugin(getplugin(NULL));
918
1107
for(plugin *p = plugin_list; p != NULL; p = p->next){
919
1108
if(p->pid != 0){
925
1114
free_plugin_list();
929
1118
/* Main loop while running plugins exist */
930
1119
while(plugin_list){
931
1120
fd_set rfds = rfds_all;
932
1121
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
933
if (select_ret == -1){
935
exitstatus = EXIT_FAILURE;
1122
if(select_ret == -1 and errno != EINTR){
1123
error(0, errno, "select");
1124
exitstatus = EX_OSERR;
938
1127
/* OK, now either a process completed, or something can be read
939
1128
from one of them */
940
for(plugin *proc = plugin_list; proc != NULL; proc = proc->next){
1129
for(plugin *proc = plugin_list; proc != NULL;){
941
1130
/* Is this process completely done? */
942
if(proc->eof and proc->completed){
1131
if(proc->completed and proc->eof){
943
1132
/* Only accept the plugin output if it exited cleanly */
944
1133
if(not WIFEXITED(proc->status)
945
1134
or WEXITSTATUS(proc->status) != 0){
946
1135
/* Bad exit by plugin */
949
1138
if(WIFEXITED(proc->status)){
950
fprintf(stderr, "Plugin %u exited with status %d\n",
951
(unsigned int) (proc->pid),
1139
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1140
" status %d\n", proc->name,
1141
(intmax_t) (proc->pid),
952
1142
WEXITSTATUS(proc->status));
953
} else if(WIFSIGNALED(proc->status)) {
954
fprintf(stderr, "Plugin %u killed by signal %d\n",
955
(unsigned int) (proc->pid),
956
WTERMSIG(proc->status));
1143
} else if(WIFSIGNALED(proc->status)){
1144
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1145
" signal %d: %s\n", proc->name,
1146
(intmax_t) (proc->pid),
1147
WTERMSIG(proc->status),
1148
strsignal(WTERMSIG(proc->status)));
957
1149
} else if(WCOREDUMP(proc->status)){
958
fprintf(stderr, "Plugin %d dumped core\n",
959
(unsigned int) (proc->pid));
1150
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1151
" core\n", proc->name, (intmax_t) (proc->pid));
963
1155
/* Remove the plugin */
964
FD_CLR(proc->fd, &rfds_all);
1156
#if defined (__GNUC__) and defined (__GLIBC__)
1157
#if not __GLIBC_PREREQ(2, 16)
1158
#pragma GCC diagnostic push
1159
#pragma GCC diagnostic ignored "-Wsign-conversion"
1162
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1163
-Wconversion in GNU libc
1165
#if defined (__GNUC__) and defined (__GLIBC__)
1166
#if not __GLIBC_PREREQ(2, 16)
1167
#pragma GCC diagnostic pop
966
1171
/* Block signal while modifying process_list */
967
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1172
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1174
&sigchld_action.sa_mask,
969
perror("sigprocmask");
970
exitstatus = EXIT_FAILURE;
1177
error(0, errno, "sigprocmask");
1178
exitstatus = EX_OSERR;
1182
plugin *next_plugin = proc->next;
973
1183
free_plugin(proc);
974
1186
/* We are done modifying process list, so unblock signal */
975
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
1187
ret = (int)(TEMP_FAILURE_RETRY
1188
(sigprocmask(SIG_UNBLOCK,
1189
&sigchld_action.sa_mask, NULL)));
978
perror("sigprocmask");
979
exitstatus = EXIT_FAILURE;
1191
error(0, errno, "sigprocmask");
1192
exitstatus = EX_OSERR;
983
1196
if(plugin_list == NULL){
989
1203
/* This process exited nicely, so print its buffer */
991
1205
bool bret = print_out_password(proc->buffer,
992
1206
proc->buffer_length);
994
perror("print_out_password");
995
exitstatus = EXIT_FAILURE;
1208
error(0, errno, "print_out_password");
1209
exitstatus = EX_IOERR;
1000
1214
/* This process has not completed. Does it have any output? */
1001
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1215
#if defined (__GNUC__) and defined (__GLIBC__)
1216
#if not __GLIBC_PREREQ(2, 16)
1217
#pragma GCC diagnostic push
1218
#pragma GCC diagnostic ignored "-Wsign-conversion"
1221
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1227
#if defined (__GNUC__) and defined (__GLIBC__)
1228
#if not __GLIBC_PREREQ(2, 16)
1229
#pragma GCC diagnostic pop
1002
1232
/* This process had nothing to say at this time */
1005
1236
/* Before reading, make the process' data buffer large enough */
1006
1237
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1007
proc->buffer = realloc(proc->buffer, proc->buffer_size
1008
+ (size_t) BUFFER_SIZE);
1009
if (proc->buffer == NULL){
1011
exitstatus = EXIT_FAILURE;
1238
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1239
+ (size_t) BUFFER_SIZE);
1240
if(new_buffer == NULL){
1241
error(0, errno, "malloc");
1242
exitstatus = EX_OSERR;
1245
proc->buffer = new_buffer;
1014
1246
proc->buffer_size += BUFFER_SIZE;
1016
1248
/* Read from the process */
1017
ret = read(proc->fd, proc->buffer + proc->buffer_length,
1249
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1251
+ proc->buffer_length,
1020
1254
/* Read error from this process; ignore the error */
1025
1260
proc->eof = true;
1027
proc->buffer_length += (size_t) ret;
1262
proc->buffer_length += (size_t) sret;
1035
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1270
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1271
and exitstatus != EX_OK)){
1036
1272
/* Fallback if all plugins failed, none are found or an error