/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to mandos-keygen.xml

  • Committer: Teddy Hogeborn
  • Date: 2014-06-08 03:10:08 UTC
  • mto: (237.7.272 trunk)
  • mto: This revision was merged to the branch mainline in revision 317.
  • Revision ID: teddy@recompile.se-20140608031008-mc9bd7b024a3q0y0
Address a very theoretical possible security issue in mandos-client.

If there were to run some sort of "cleaner" process for /run/tmp (or
/tmp), and mandos-client were to run for long enough for that cleaner
process to remove the temporary directory for GPGME, there was a
possibility that another unprivileged process could trick the (also
unprivileged) mandos-client process to remove other files or symlinks
which the unprivileged mandos-client process was allowed to remove.
This is not currently known to have been exploitable, since there are
no known initramfs environments running such cleaner processes.

* plugins.d/mandos-client.c (main): Use O_NOFOLLOW when opening
                                    tempdir for cleaning.

Show diffs side-by-side

added added

removed removed

Lines of Context:
mandos-keygen.xml
2
2
<!DOCTYPE refentry PUBLIC "-//OASIS//DTD DocBook XML V4.5//EN"
3
3
        "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd" [
4
4
<!ENTITY COMMANDNAME "mandos-keygen">
5
 
<!ENTITY TIMESTAMP "2012-01-01">
 
5
<!ENTITY TIMESTAMP "2013-10-22">
6
6
<!ENTITY % common SYSTEM "common.ent">
7
7
%common;
8
8
]>
227
227
        <replaceable>TYPE</replaceable></option></term>
228
228
        <listitem>
229
229
          <para>
230
 
            Key type.  Default is <quote>DSA</quote>.
 
230
            Key type.  Default is <quote>RSA</quote>.
231
231
          </para>
232
232
        </listitem>
233
233
      </varlistentry>
239
239
        <replaceable>BITS</replaceable></option></term>
240
240
        <listitem>
241
241
          <para>
242
 
            Key length in bits.  Default is 2048.
 
242
            Key length in bits.  Default is 4096.
243
243
          </para>
244
244
        </listitem>
245
245
      </varlistentry>
251
251
        <replaceable>KEYTYPE</replaceable></option></term>
252
252
        <listitem>
253
253
          <para>
254
 
            Subkey type.  Default is <quote>ELG-E</quote> (Elgamal
 
254
            Subkey type.  Default is <quote>RSA</quote> (Elgamal
255
255
            encryption-only).
256
256
          </para>
257
257
        </listitem>
264
264
        <replaceable>BITS</replaceable></option></term>
265
265
        <listitem>
266
266
          <para>
267
 
            Subkey length in bits.  Default is 2048.
 
267
            Subkey length in bits.  Default is 4096.
268
268
          </para>
269
269
        </listitem>
270
270
      </varlistentry>
288
288
        <replaceable>TEXT</replaceable></option></term>
289
289
        <listitem>
290
290
          <para>
291
 
            Comment field for key.  The default value is
292
 
            <quote><literal>Mandos client key</literal></quote>.
 
291
            Comment field for key.  Default is empty.
293
292
          </para>
294
293
        </listitem>
295
294
      </varlistentry>