/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to initramfs-tools-hook-conf

  • Committer: Teddy Hogeborn
  • Date: 2014-06-08 03:10:08 UTC
  • mto: (237.7.272 trunk)
  • mto: This revision was merged to the branch mainline in revision 317.
  • Revision ID: teddy@recompile.se-20140608031008-mc9bd7b024a3q0y0
Address a very theoretical possible security issue in mandos-client.

If there were to run some sort of "cleaner" process for /run/tmp (or
/tmp), and mandos-client were to run for long enough for that cleaner
process to remove the temporary directory for GPGME, there was a
possibility that another unprivileged process could trick the (also
unprivileged) mandos-client process to remove other files or symlinks
which the unprivileged mandos-client process was allowed to remove.
This is not currently known to have been exploitable, since there are
no known initramfs environments running such cleaner processes.

* plugins.d/mandos-client.c (main): Use O_NOFOLLOW when opening
                                    tempdir for cleaning.

Show diffs side-by-side

added added

removed removed

Lines of Context:
initramfs-tools-hook-conf
 
1
# -*- shell-script -*-
 
2
 
 
3
# if mkinitramfs is started by mkinitramfs-kpkg, mkinitramfs-kpkg has
 
4
# already touched the initrd file with umask 022 before we had a
 
5
# chance to affect it.  We cannot allow a readable initrd file,
 
6
# therefore we must fix this now.
 
7
if [ -e "${outfile}" ] \
 
8
    && [ `stat --format=%s "${outfile}"` -eq 0 ]; then
 
9
    rm "${outfile}"
 
10
    (umask 027; touch "${outfile}")
 
11
fi
 
12
 
 
13
UMASK=027