/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to debian/mandos-client.postinst

  • Committer: Teddy Hogeborn
  • Date: 2014-06-08 03:10:08 UTC
  • mto: (237.7.272 trunk)
  • mto: This revision was merged to the branch mainline in revision 317.
  • Revision ID: teddy@recompile.se-20140608031008-mc9bd7b024a3q0y0
Address a very theoretical possible security issue in mandos-client.

If there were to run some sort of "cleaner" process for /run/tmp (or
/tmp), and mandos-client were to run for long enough for that cleaner
process to remove the temporary directory for GPGME, there was a
possibility that another unprivileged process could trick the (also
unprivileged) mandos-client process to remove other files or symlinks
which the unprivileged mandos-client process was allowed to remove.
This is not currently known to have been exploitable, since there are
no known initramfs environments running such cleaner processes.

* plugins.d/mandos-client.c (main): Use O_NOFOLLOW when opening
                                    tempdir for cleaning.

Show diffs side-by-side

added added

removed removed

Lines of Context:
debian/mandos-client.postinst
20
20
# Update the initial RAM file system image
21
21
update_initramfs()
22
22
{
23
 
    update-initramfs -u -k all
 
23
    if [ -x /usr/sbin/update-initramfs ]; then
 
24
        update-initramfs -u -k all
 
25
    fi
24
26
    
25
27
    if dpkg --compare-versions "$2" lt-nl "1.0.10-1"; then
26
28
        # Make old initrd.img files unreadable too, in case they were
56
58
        -a -r /etc/keys/mandos/seckey.txt ]; then
57
59
        return 0
58
60
    fi
59
 
    mandos-keygen
60
 
}
61
 
 
62
 
create_dh_params(){
63
 
    if [ -r /etc/keys/mandos/dhparams.pem ]; then
64
 
        return 0
65
 
    fi
66
 
    # Create a Diffe-Hellman parameters file
67
 
    DHFILE="`mktemp -t mandos-client-dh-parameters.XXXXXXXXXX.pem`"
68
 
    # First try certtool from GnuTLS
69
 
    if ! certtool --generate-dh-params --sec-param high \
70
 
         --outfile "$DHFILE"; then
71
 
        # Otherwise try OpenSSL
72
 
        if ! openssl genpkey -genparam -algorithm DH -out "$DHFILE" \
73
 
             -pkeyopt dh_paramgen_prime_len:3072; then
74
 
            # None of the commands succeded; give up
75
 
            rm -- "$DHFILE"
76
 
            return 1
77
 
        fi
78
 
    fi
79
 
    sed --in-place --expression='0,/^-----BEGIN DH PARAMETERS-----$/d' \
80
 
        "$DHFILE"
81
 
    sed --in-place --expression='1i-----BEGIN DH PARAMETERS-----' \
82
 
            "$DHFILE"
83
 
    cp --archive "$DHFILE" /etc/keys/mandos/dhparams.pem
84
 
    rm -- "$DHFILE"
 
61
    if [ -x /usr/sbin/mandos-keygen ]; then
 
62
        mandos-keygen
 
63
    fi
85
64
}
86
65
 
87
66
case "$1" in
88
67
    configure)
89
68
        add_mandos_user "$@"
90
69
        create_key "$@"
91
 
        create_dh_params "$@" || :
92
70
        update_initramfs "$@"
93
 
        if dpkg --compare-versions "$2" lt-nl "1.7.10-1"; then
94
 
            PLUGINHELPERDIR=/usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null)/mandos/plugin-helpers
95
 
            if ! dpkg-statoverride --list "$PLUGINHELPERDIR" \
96
 
                 >/dev/null 2>&1; then
97
 
                chmod u=rwx,go= -- "$PLUGINHELPERDIR"
98
 
            fi
99
 
            if ! dpkg-statoverride --list /etc/mandos/plugin-helpers \
100
 
                 >/dev/null 2>&1; then
101
 
                chmod u=rwx,go= -- /etc/mandos/plugin-helpers
102
 
            fi
103
 
        fi
104
71
        ;;
105
72
    abort-upgrade|abort-deconfigure|abort-remove)
106
73
        ;;