/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to debian/mandos-client.postinst

  • Committer: Teddy Hogeborn
  • Date: 2014-06-08 03:10:08 UTC
  • mto: (237.7.272 trunk)
  • mto: This revision was merged to the branch mainline in revision 317.
  • Revision ID: teddy@recompile.se-20140608031008-mc9bd7b024a3q0y0
Address a very theoretical possible security issue in mandos-client.

If there were to run some sort of "cleaner" process for /run/tmp (or
/tmp), and mandos-client were to run for long enough for that cleaner
process to remove the temporary directory for GPGME, there was a
possibility that another unprivileged process could trick the (also
unprivileged) mandos-client process to remove other files or symlinks
which the unprivileged mandos-client process was allowed to remove.
This is not currently known to have been exploitable, since there are
no known initramfs environments running such cleaner processes.

* plugins.d/mandos-client.c (main): Use O_NOFOLLOW when opening
                                    tempdir for cleaning.

Show diffs side-by-side

added added

removed removed

Lines of Context:
63
63
    fi
64
64
}
65
65
 
66
 
create_dh_params(){
67
 
    if [ -r /etc/keys/mandos/client-dhparams.pem ]; then
68
 
        return 0
69
 
    fi
70
 
    # Create a Diffe-Hellman parameters file
71
 
    DHFILE="`mktemp -t mandos-client-dh-parameters.XXXXXXXXXX.pem`"
72
 
    # First try certtool from GnuTLS
73
 
    if ! certtool --generate-dh-params --sec-param high \
74
 
         --outfile "$DHFILE"; then
75
 
        # Otherwise try OpenSSL
76
 
        if ! openssl genpkey -genparam -algorithm DH -out "$DHFILE" \
77
 
             -pkeyopt dh_paramgen_prime_len:3072; then
78
 
            # None of the commands succeded; give up
79
 
            rm -- "$DHFILE"
80
 
            return 1
81
 
        fi
82
 
    fi
83
 
    sed --in-place --expression='0,/^-----BEGIN DH PARAMETERS-----$/d' \
84
 
        "$DHFILE"
85
 
    sed --in-place --expression='1i-----BEGIN DH PARAMETERS-----' \
86
 
            "$DHFILE"
87
 
    cp --archive "$DHFILE" /etc/keys/mandos/client-dhparams.pem
88
 
    rm -- "$DHFILE"
89
 
}
90
 
 
91
66
case "$1" in
92
67
    configure)
93
68
        add_mandos_user "$@"
94
69
        create_key "$@"
95
 
        create_dh_params "$@" || :
96
70
        update_initramfs "$@"
97
71
        ;;
98
72
    abort-upgrade|abort-deconfigure|abort-remove)