/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to debian/mandos-client.lintian-overrides

  • Committer: Teddy Hogeborn
  • Date: 2014-06-08 03:10:08 UTC
  • mto: (237.7.272 trunk)
  • mto: This revision was merged to the branch mainline in revision 317.
  • Revision ID: teddy@recompile.se-20140608031008-mc9bd7b024a3q0y0
Address a very theoretical possible security issue in mandos-client.

If there were to run some sort of "cleaner" process for /run/tmp (or
/tmp), and mandos-client were to run for long enough for that cleaner
process to remove the temporary directory for GPGME, there was a
possibility that another unprivileged process could trick the (also
unprivileged) mandos-client process to remove other files or symlinks
which the unprivileged mandos-client process was allowed to remove.
This is not currently known to have been exploitable, since there are
no known initramfs environments running such cleaner processes.

* plugins.d/mandos-client.c (main): Use O_NOFOLLOW when opening
                                    tempdir for cleaning.

Show diffs side-by-side

added added

removed removed

Lines of Context:
debian/mandos-client.lintian-overrides
8
8
# allow anyone to run them.
9
9
#
10
10
mandos-client binary: non-standard-dir-perm usr/lib/*/mandos/plugins.d/ 0700 != 0755
11
 
# Likewise for helper executables for plugins
12
 
mandos-client binary: non-standard-dir-perm usr/lib/*/mandos/plugin-helpers/ 0700 != 0755
13
11
 
14
12
# These binaries must be setuid root, since they need root powers, but
15
13
# are started by plugin-runner(8mandos), which runs all plugins as
28
26
# /usr/lib/<arch>/mandos/plugins.d, and must be likewise protected.
29
27
#
30
28
mandos-client binary: non-standard-dir-perm etc/mandos/plugins.d/ 0700 != 0755
31
 
# Likewise for plugin-helpers directory
32
 
mandos-client binary: non-standard-dir-perm etc/mandos/plugin-helpers/ 0700 != 0755
33
 
 
34
 
# The debconf templates is only used for displaying information
35
 
# detected in the postinst, not for saving answers to questions, so we
36
 
# don't need a .config file.
37
 
mandos-client binary: no-debconf-config
38
 
 
39
 
# The notice displayed from the postinst script really is critical
40
 
mandos-client binary: postinst-uses-db-input
41
 
 
42
 
# It is a really long line
43
 
mandos-client binary: manpage-has-errors-from-man usr/share/man/man8/plugin-runner.8mandos.gz *: warning *: can't break line