19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf(), O_CLOEXEC */
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
31
#include <stdio.h> /* fileno(), fprintf(),
32
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
33
#include <sys/types.h> /* DIR, fdopendir(), stat(), struct
34
34
stat, waitpid(), WIFEXITED(),
35
35
WEXITSTATUS(), wait(), pid_t,
36
36
uid_t, gid_t, getuid(), getgid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
42
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
44
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
45
46
readdir(), closedir(), dirfd() */
46
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
48
fcntl(), setuid(), setgid(),
98
106
/* Gets an existing plugin based on name,
99
107
or if none is found, creates a new one */
108
__attribute__((warn_unused_result))
100
109
static plugin *getplugin(char *name){
101
/* Check for exiting plugin with that name */
102
for (plugin *p = plugin_list; p != NULL; p = p->next){
103
if ((p->name == name)
104
or (p->name and name and (strcmp(p->name, name) == 0))){
110
/* Check for existing plugin with that name */
111
for(plugin *p = plugin_list; p != NULL; p = p->next){
113
or (p->name and name and (strcmp(p->name, name) == 0))){
108
117
/* Create a new plugin */
109
plugin *new_plugin = malloc(sizeof(plugin));
110
if (new_plugin == NULL){
118
plugin *new_plugin = NULL;
120
new_plugin = malloc(sizeof(plugin));
121
} while(new_plugin == NULL and errno == EINTR);
122
if(new_plugin == NULL){
113
125
char *copy_name = NULL;
114
126
if(name != NULL){
115
copy_name = strdup(name);
128
copy_name = strdup(name);
129
} while(copy_name == NULL and errno == EINTR);
116
130
if(copy_name == NULL){
121
*new_plugin = (plugin) { .name = copy_name,
124
.next = plugin_list };
138
*new_plugin = (plugin){ .name = copy_name,
141
.next = plugin_list };
126
new_plugin->argv = malloc(sizeof(char *) * 2);
127
if (new_plugin->argv == NULL){
144
new_plugin->argv = malloc(sizeof(char *) * 2);
145
} while(new_plugin->argv == NULL and errno == EINTR);
146
if(new_plugin->argv == NULL){
129
149
free(new_plugin);
132
153
new_plugin->argv[0] = copy_name;
133
154
new_plugin->argv[1] = NULL;
135
new_plugin->environ = malloc(sizeof(char *));
157
new_plugin->environ = malloc(sizeof(char *));
158
} while(new_plugin->environ == NULL and errno == EINTR);
136
159
if(new_plugin->environ == NULL){
138
162
free(new_plugin->argv);
139
163
free(new_plugin);
142
167
new_plugin->environ[0] = NULL;
206
244
* Based on the example in the GNU LibC manual chapter 13.13 "File
207
245
* Descriptor Flags".
208
* *Note File Descriptor Flags:(libc)Descriptor Flags.
246
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
248
__attribute__((warn_unused_result))
210
249
static int set_cloexec_flag(int fd){
211
int ret = fcntl(fd, F_GETFD, 0);
250
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
212
251
/* If reading the flags failed, return error indication now. */
216
255
/* Store modified flag word in the descriptor. */
217
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
256
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
221
261
/* Mark processes as completed when they exit, and save their exit
223
263
static void handle_sigchld(__attribute__((unused)) int sig){
264
int old_errno = errno;
225
266
plugin *proc = plugin_list;
369
413
.doc = "Group ID the plugins will run as", .group = 3 },
370
414
{ .name = "debug", .key = 132,
371
415
.doc = "Debug mode", .group = 4 },
417
* These reproduce what we would get without ARGP_NO_HELP
419
{ .name = "help", .key = '?',
420
.doc = "Give this help list", .group = -1 },
421
{ .name = "usage", .key = -3,
422
.doc = "Give a short usage message", .group = -1 },
423
{ .name = "version", .key = 'V',
424
.doc = "Print program version", .group = -1 },
375
error_t parse_opt (int key, char *arg, __attribute__((unused))
376
struct argp_state *state) {
428
__attribute__((nonnull(3)))
429
error_t parse_opt(int key, char *arg, struct argp_state *state){
378
434
case 'g': /* --global-options */
381
while((p = strsep(&arg, ",")) != NULL){
385
if(not add_argument(getplugin(NULL), p)){
386
perror("add_argument");
387
return ARGP_ERR_UNKNOWN;
437
while((plugin_option = strsep(&arg, ",")) != NULL){
438
if(not add_argument(getplugin(NULL), plugin_option)){
392
445
case 'G': /* --global-env */
396
if(not add_environment(getplugin(NULL), arg, true)){
397
perror("add_environment");
446
if(add_environment(getplugin(NULL), arg, true)){
400
450
case 'o': /* --options-for */
402
char *p_name = strsep(&arg, ":");
403
if(p_name[0] == '\0' or arg == NULL){
406
char *opt = strsep(&arg, ":");
407
if(opt[0] == '\0' or opt == NULL){
411
while((p = strsep(&opt, ",")) != NULL){
415
if(not add_argument(getplugin(p_name), p)){
416
perror("add_argument");
417
return ARGP_ERR_UNKNOWN;
452
char *option_list = strchr(arg, ':');
453
if(option_list == NULL){
454
argp_error(state, "No colon in \"%s\"", arg);
461
argp_error(state, "Empty plugin name");
466
while((option = strsep(&option_list, ",")) != NULL){
467
if(not add_argument(getplugin(arg), option)){
422
474
case 'E': /* --env-for */
427
476
char *envdef = strchr(arg, ':');
428
477
if(envdef == NULL){
478
argp_error(state, "No colon in \"%s\"", arg);
432
if(not add_environment(getplugin(arg), envdef+1, true)){
433
perror("add_environment");
485
argp_error(state, "Empty plugin name");
489
if(add_environment(getplugin(arg), envdef, true)){
437
494
case 'd': /* --disable */
439
496
plugin *p = getplugin(arg);
441
return ARGP_ERR_UNKNOWN;
446
503
case 'e': /* --enable */
448
505
plugin *p = getplugin(arg);
450
return ARGP_ERR_UNKNOWN;
455
512
case 128: /* --plugin-dir */
457
514
plugindir = strdup(arg);
458
if(plugindir == NULL){
515
if(plugindir != NULL){
462
519
case 129: /* --config-file */
463
520
/* This is already done by parse_opt_config_file() */
465
522
case 130: /* --userid */
466
/* In the GNU C library, uid_t is always unsigned int */
467
ret = sscanf(arg, "%ud", &uid);
469
fprintf(stderr, "Bad user ID number: \"%s\", using %ud\n",
523
tmp_id = strtoimax(arg, &tmp, 10);
524
if(errno != 0 or tmp == arg or *tmp != '\0'
525
or tmp_id != (uid_t)tmp_id){
526
argp_error(state, "Bad user ID number: \"%s\", using %"
527
PRIdMAX, arg, (intmax_t)uid);
473
533
case 131: /* --groupid */
474
/* In the GNU C library, gid_t is always unsigned int */
475
ret = sscanf(arg, "%ud", &gid);
477
fprintf(stderr, "Bad group ID number: \"%s\", using %ud\n",
534
tmp_id = strtoimax(arg, &tmp, 10);
535
if(errno != 0 or tmp == arg or *tmp != '\0'
536
or tmp_id != (gid_t)tmp_id){
537
argp_error(state, "Bad group ID number: \"%s\", using %"
538
PRIdMAX, arg, (intmax_t)gid);
481
544
case 132: /* --debug */
548
* These reproduce what we would get without ARGP_NO_HELP
550
case '?': /* --help */
551
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
552
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
553
case -3: /* --usage */
554
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
555
argp_state_help(state, state->out_stream,
556
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
557
case 'V': /* --version */
558
fprintf(state->out_stream, "%s\n", argp_program_version);
485
562
* When adding more options before this line, remember to also add a
486
563
* "case" to the "parse_opt_config_file" function below.
591
678
new_arg = strdup(p);
592
679
if(new_arg == NULL){
594
exitstatus = EXIT_FAILURE;
680
error(0, errno, "strdup");
681
exitstatus = EX_OSERR;
599
686
custom_argc += 1;
600
custom_argv = realloc(custom_argv, sizeof(char *)
601
* ((unsigned int) custom_argc + 1));
602
if(custom_argv == NULL){
604
exitstatus = EXIT_FAILURE;
688
char **new_argv = realloc(custom_argv, sizeof(char *)
691
if(new_argv == NULL){
692
error(0, errno, "realloc");
693
exitstatus = EX_OSERR;
698
custom_argv = new_argv;
608
701
custom_argv[custom_argc-1] = new_arg;
609
custom_argv[custom_argc] = NULL;
702
custom_argv[custom_argc] = NULL;
706
ret = fclose(conffp);
707
} while(ret == EOF and errno == EINTR);
709
error(0, errno, "fclose");
710
exitstatus = EX_IOERR;
614
715
/* Check for harmful errors and go to fallback. Other errors might
615
716
not affect opening plugins */
616
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
618
exitstatus = EXIT_FAILURE;
717
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
718
error(0, errno, "fopen");
719
exitstatus = EX_OSERR;
622
/* If there was any arguments from configuration file,
623
pass them to parser as command arguments */
723
/* If there were any arguments from the configuration file, pass
724
them to parser as command line arguments */
624
725
if(custom_argv != NULL){
625
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
627
if (ret == ARGP_ERR_UNKNOWN){
628
fprintf(stderr, "Unknown error while parsing arguments\n");
629
exitstatus = EXIT_FAILURE;
726
ret = argp_parse(&argp, custom_argc, custom_argv,
727
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
735
error(0, errno, "argp_parse");
736
exitstatus = EX_OSERR;
739
exitstatus = EX_CONFIG;
634
744
/* Parse actual command line arguments, to let them override the
636
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
637
if (ret == ARGP_ERR_UNKNOWN){
638
fprintf(stderr, "Unknown error while parsing arguments\n");
639
exitstatus = EXIT_FAILURE;
746
ret = argp_parse(&argp, argc, argv,
747
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
755
error(0, errno, "argp_parse");
756
exitstatus = EX_OSERR;
759
exitstatus = EX_USAGE;
647
767
for(char **a = p->argv; *a != NULL; a++){
648
768
fprintf(stderr, "\tArg: %s\n", *a);
650
fprintf(stderr, "...and %u environment variables\n", p->envc);
770
fprintf(stderr, "...and %d environment variables\n", p->envc);
651
771
for(char **a = p->environ; *a != NULL; a++){
652
772
fprintf(stderr, "\t%s\n", *a);
657
/* Strip permissions down to nobody */
778
/* Work around Debian bug #633582:
779
<http://bugs.debian.org/633582> */
780
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
781
if(plugindir_fd == -1){
782
error(0, errno, "open");
784
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
786
error(0, errno, "fstat");
788
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
789
ret = fchown(plugindir_fd, uid, gid);
791
error(0, errno, "fchown");
795
TEMP_FAILURE_RETRY(close(plugindir_fd));
799
/* Lower permissions */
802
error(0, errno, "setgid");
658
804
ret = setuid(uid);
667
if (plugindir == NULL){
670
dir = opendir(plugindir);
674
perror("Could not open plugin dir");
675
exitstatus = EXIT_FAILURE;
679
/* Set the FD_CLOEXEC flag on the directory, if possible */
806
error(0, errno, "setuid");
809
/* Open plugin directory with close_on_exec flag */
681
int dir_fd = dirfd(dir);
683
ret = set_cloexec_flag(dir_fd);
685
perror("set_cloexec_flag");
686
exitstatus = EXIT_FAILURE;
812
if(plugindir == NULL){
813
dir_fd = open(PDIR, O_RDONLY |
816
#else /* not O_CLOEXEC */
818
#endif /* not O_CLOEXEC */
821
dir_fd = open(plugindir, O_RDONLY |
824
#else /* not O_CLOEXEC */
826
#endif /* not O_CLOEXEC */
830
error(0, errno, "Could not open plugin dir");
831
exitstatus = EX_UNAVAILABLE;
836
/* Set the FD_CLOEXEC flag on the directory */
837
ret = set_cloexec_flag(dir_fd);
839
error(0, errno, "set_cloexec_flag");
840
TEMP_FAILURE_RETRY(close(dir_fd));
841
exitstatus = EX_OSERR;
844
#endif /* O_CLOEXEC */
846
dir = fdopendir(dir_fd);
848
error(0, errno, "Could not open plugin dir");
849
TEMP_FAILURE_RETRY(close(dir_fd));
850
exitstatus = EX_OSERR;
755
936
if(plugindir == NULL){
756
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
937
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",
758
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
940
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",
945
error(0, errno, "asprintf");
765
ret = stat(filename, &st);
949
ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));
951
error(0, errno, "stat");
772
956
/* Ignore non-executable files */
773
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
957
if(not S_ISREG(st.st_mode)
958
or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){
775
960
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
776
961
" with bad type or mode\n", filename);
816
1001
if(p->environ[0] != NULL){
817
1002
for(char **e = environ; *e != NULL; e++){
818
1003
if(not add_environment(p, *e, false)){
819
perror("add_environment");
1004
error(0, errno, "add_environment");
828
exitstatus = EXIT_FAILURE;
1010
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1012
error(0, errno, "pipe");
1013
exitstatus = EX_OSERR;
831
1016
/* Ask OS to automatic close the pipe on exec */
832
1017
ret = set_cloexec_flag(pipefd[0]);
834
perror("set_cloexec_flag");
835
exitstatus = EXIT_FAILURE;
1019
error(0, errno, "set_cloexec_flag");
1020
exitstatus = EX_OSERR;
838
1023
ret = set_cloexec_flag(pipefd[1]);
840
perror("set_cloexec_flag");
841
exitstatus = EXIT_FAILURE;
1025
error(0, errno, "set_cloexec_flag");
1026
exitstatus = EX_OSERR;
844
1029
/* Block SIGCHLD until process is safely in process list */
845
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1030
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1031
&sigchld_action.sa_mask,
847
perror("sigprocmask");
848
exitstatus = EXIT_FAILURE;
1034
error(0, errno, "sigprocmask");
1035
exitstatus = EX_OSERR;
851
1038
/* Starting a new process to be watched */
1042
} while(pid == -1 and errno == EINTR);
855
exitstatus = EXIT_FAILURE;
1044
error(0, errno, "fork");
1045
exitstatus = EX_OSERR;
859
1049
/* this is the child process */
860
1050
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1052
error(0, errno, "sigaction");
865
1055
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
867
perror("sigprocmask");
1057
error(0, errno, "sigprocmask");
871
1061
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1063
error(0, errno, "dup2");
877
1067
if(dirfd(dir) < 0){
882
1072
if(p->environ[0] == NULL){
883
1073
if(execv(filename, p->argv) < 0){
1074
error(0, errno, "execv for %s", filename);
888
1078
if(execve(filename, p->argv, p->environ) < 0){
1079
error(0, errno, "execve for %s", filename);
895
1085
/* Parent process */
896
close(pipefd[1]); /* Close unused write end of pipe */
1086
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
898
1089
plugin *new_plugin = getplugin(dirst->d_name);
899
if (new_plugin == NULL){
901
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1090
if(new_plugin == NULL){
1091
error(0, errno, "getplugin");
1092
ret = (int)(TEMP_FAILURE_RETRY
1093
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
903
perror("sigprocmask");
1096
error(0, errno, "sigprocmask");
905
exitstatus = EXIT_FAILURE;
1098
exitstatus = EX_OSERR;
912
1105
/* Unblock SIGCHLD so signal handler can be run if this process
913
1106
has already completed */
914
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1107
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1108
&sigchld_action.sa_mask,
916
perror("sigprocmask");
917
exitstatus = EXIT_FAILURE;
1111
error(0, errno, "sigprocmask");
1112
exitstatus = EX_OSERR;
921
FD_SET(new_plugin->fd, &rfds_all);
1116
#if defined (__GNUC__) and defined (__GLIBC__)
1117
#if not __GLIBC_PREREQ(2, 16)
1118
#pragma GCC diagnostic push
1119
#pragma GCC diagnostic ignored "-Wsign-conversion"
1122
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1123
-Wconversion in GNU libc
1125
#if defined (__GNUC__) and defined (__GLIBC__)
1126
#if not __GLIBC_PREREQ(2, 16)
1127
#pragma GCC diagnostic pop
923
if (maxfd < new_plugin->fd){
1131
if(maxfd < new_plugin->fd){
924
1132
maxfd = new_plugin->fd;
1136
TEMP_FAILURE_RETRY(closedir(dir));
1138
free_plugin(getplugin(NULL));
931
1140
for(plugin *p = plugin_list; p != NULL; p = p->next){
932
1141
if(p->pid != 0){
943
1152
while(plugin_list){
944
1153
fd_set rfds = rfds_all;
945
1154
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
946
if (select_ret == -1){
948
exitstatus = EXIT_FAILURE;
1155
if(select_ret == -1 and errno != EINTR){
1156
error(0, errno, "select");
1157
exitstatus = EX_OSERR;
951
1160
/* OK, now either a process completed, or something can be read
952
1161
from one of them */
953
1162
for(plugin *proc = plugin_list; proc != NULL;){
954
1163
/* Is this process completely done? */
955
if(proc->eof and proc->completed){
1164
if(proc->completed and proc->eof){
956
1165
/* Only accept the plugin output if it exited cleanly */
957
1166
if(not WIFEXITED(proc->status)
958
1167
or WEXITSTATUS(proc->status) != 0){
959
1168
/* Bad exit by plugin */
962
1171
if(WIFEXITED(proc->status)){
963
fprintf(stderr, "Plugin %u exited with status %d\n",
964
(unsigned int) (proc->pid),
1172
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1173
" status %d\n", proc->name,
1174
(intmax_t) (proc->pid),
965
1175
WEXITSTATUS(proc->status));
966
} else if(WIFSIGNALED(proc->status)) {
967
fprintf(stderr, "Plugin %u killed by signal %d\n",
968
(unsigned int) (proc->pid),
969
WTERMSIG(proc->status));
1176
} else if(WIFSIGNALED(proc->status)){
1177
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1178
" signal %d: %s\n", proc->name,
1179
(intmax_t) (proc->pid),
1180
WTERMSIG(proc->status),
1181
strsignal(WTERMSIG(proc->status)));
970
1182
} else if(WCOREDUMP(proc->status)){
971
fprintf(stderr, "Plugin %d dumped core\n",
972
(unsigned int) (proc->pid));
1183
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1184
" core\n", proc->name, (intmax_t) (proc->pid));
976
1188
/* Remove the plugin */
977
FD_CLR(proc->fd, &rfds_all);
1189
#if defined (__GNUC__) and defined (__GLIBC__)
1190
#if not __GLIBC_PREREQ(2, 16)
1191
#pragma GCC diagnostic push
1192
#pragma GCC diagnostic ignored "-Wsign-conversion"
1195
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1196
-Wconversion in GNU libc
1198
#if defined (__GNUC__) and defined (__GLIBC__)
1199
#if not __GLIBC_PREREQ(2, 16)
1200
#pragma GCC diagnostic pop
979
1204
/* Block signal while modifying process_list */
980
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1205
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1207
&sigchld_action.sa_mask,
982
perror("sigprocmask");
983
exitstatus = EXIT_FAILURE;
1210
error(0, errno, "sigprocmask");
1211
exitstatus = EX_OSERR;
1009
1238
bool bret = print_out_password(proc->buffer,
1010
1239
proc->buffer_length);
1012
perror("print_out_password");
1013
exitstatus = EXIT_FAILURE;
1241
error(0, errno, "print_out_password");
1242
exitstatus = EX_IOERR;
1018
1247
/* This process has not completed. Does it have any output? */
1019
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1248
#if defined (__GNUC__) and defined (__GLIBC__)
1249
#if not __GLIBC_PREREQ(2, 16)
1250
#pragma GCC diagnostic push
1251
#pragma GCC diagnostic ignored "-Wsign-conversion"
1254
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1260
#if defined (__GNUC__) and defined (__GLIBC__)
1261
#if not __GLIBC_PREREQ(2, 16)
1262
#pragma GCC diagnostic pop
1020
1265
/* This process had nothing to say at this time */
1021
1266
proc = proc->next;
1024
1269
/* Before reading, make the process' data buffer large enough */
1025
1270
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1026
proc->buffer = realloc(proc->buffer, proc->buffer_size
1027
+ (size_t) BUFFER_SIZE);
1028
if (proc->buffer == NULL){
1030
exitstatus = EXIT_FAILURE;
1271
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1272
+ (size_t) BUFFER_SIZE);
1273
if(new_buffer == NULL){
1274
error(0, errno, "malloc");
1275
exitstatus = EX_OSERR;
1278
proc->buffer = new_buffer;
1033
1279
proc->buffer_size += BUFFER_SIZE;
1035
1281
/* Read from the process */
1036
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1282
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1284
+ proc->buffer_length,
1039
1287
/* Read error from this process; ignore the error */
1040
1288
proc = proc->next;