/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to mandos

  • Committer: Teddy Hogeborn
  • Date: 2012-06-14 21:42:44 UTC
  • mto: (301.1.1 release) (237.7.272 trunk)
  • mto: This revision was merged to the branch mainline in revision 302.
  • Revision ID: teddy@recompile.se-20120614214244-meh2hr7pg0p0fek2
* plugins.d/mandos-client.c: Only print message about nonexisting
                             network hook directory in debug mode.

Show diffs side-by-side

added added

removed removed

Lines of Context:
11
11
# "AvahiService" class, and some lines in "main".
12
12
13
13
# Everything else is
14
 
# Copyright © 2008-2014 Teddy Hogeborn
15
 
# Copyright © 2008-2014 Björn Påhlsson
 
14
# Copyright © 2008-2012 Teddy Hogeborn
 
15
# Copyright © 2008-2012 Björn Påhlsson
16
16
17
17
# This program is free software: you can redistribute it and/or modify
18
18
# it under the terms of the GNU General Public License as published by
68
68
import binascii
69
69
import tempfile
70
70
import itertools
71
 
import collections
72
71
 
73
72
import dbus
74
73
import dbus.service
79
78
import ctypes.util
80
79
import xml.dom.minidom
81
80
import inspect
 
81
import GnuPGInterface
82
82
 
83
83
try:
84
84
    SO_BINDTODEVICE = socket.SO_BINDTODEVICE
88
88
    except ImportError:
89
89
        SO_BINDTODEVICE = None
90
90
 
91
 
version = "1.6.3"
 
91
version = "1.5.5"
92
92
stored_state_file = "clients.pickle"
93
93
 
94
94
logger = logging.getLogger()
139
139
class PGPEngine(object):
140
140
    """A simple class for OpenPGP symmetric encryption & decryption"""
141
141
    def __init__(self):
 
142
        self.gnupg = GnuPGInterface.GnuPG()
142
143
        self.tempdir = tempfile.mkdtemp(prefix="mandos-")
143
 
        self.gnupgargs = ['--batch',
144
 
                          '--home', self.tempdir,
145
 
                          '--force-mdc',
146
 
                          '--quiet',
147
 
                          '--no-use-agent']
 
144
        self.gnupg = GnuPGInterface.GnuPG()
 
145
        self.gnupg.options.meta_interactive = False
 
146
        self.gnupg.options.homedir = self.tempdir
 
147
        self.gnupg.options.extra_args.extend(['--force-mdc',
 
148
                                              '--quiet',
 
149
                                              '--no-use-agent'])
148
150
    
149
151
    def __enter__(self):
150
152
        return self
172
174
    def password_encode(self, password):
173
175
        # Passphrase can not be empty and can not contain newlines or
174
176
        # NUL bytes.  So we prefix it and hex encode it.
175
 
        encoded = b"mandos" + binascii.hexlify(password)
176
 
        if len(encoded) > 2048:
177
 
            # GnuPG can't handle long passwords, so encode differently
178
 
            encoded = (b"mandos" + password.replace(b"\\", b"\\\\")
179
 
                       .replace(b"\n", b"\\n")
180
 
                       .replace(b"\0", b"\\x00"))
181
 
        return encoded
 
177
        return b"mandos" + binascii.hexlify(password)
182
178
    
183
179
    def encrypt(self, data, password):
184
 
        passphrase = self.password_encode(password)
185
 
        with tempfile.NamedTemporaryFile(dir=self.tempdir
186
 
                                         ) as passfile:
187
 
            passfile.write(passphrase)
188
 
            passfile.flush()
189
 
            proc = subprocess.Popen(['gpg', '--symmetric',
190
 
                                     '--passphrase-file',
191
 
                                     passfile.name]
192
 
                                    + self.gnupgargs,
193
 
                                    stdin = subprocess.PIPE,
194
 
                                    stdout = subprocess.PIPE,
195
 
                                    stderr = subprocess.PIPE)
196
 
            ciphertext, err = proc.communicate(input = data)
197
 
        if proc.returncode != 0:
198
 
            raise PGPError(err)
 
180
        self.gnupg.passphrase = self.password_encode(password)
 
181
        with open(os.devnull, "w") as devnull:
 
182
            try:
 
183
                proc = self.gnupg.run(['--symmetric'],
 
184
                                      create_fhs=['stdin', 'stdout'],
 
185
                                      attach_fhs={'stderr': devnull})
 
186
                with contextlib.closing(proc.handles['stdin']) as f:
 
187
                    f.write(data)
 
188
                with contextlib.closing(proc.handles['stdout']) as f:
 
189
                    ciphertext = f.read()
 
190
                proc.wait()
 
191
            except IOError as e:
 
192
                raise PGPError(e)
 
193
        self.gnupg.passphrase = None
199
194
        return ciphertext
200
195
    
201
196
    def decrypt(self, data, password):
202
 
        passphrase = self.password_encode(password)
203
 
        with tempfile.NamedTemporaryFile(dir = self.tempdir
204
 
                                         ) as passfile:
205
 
            passfile.write(passphrase)
206
 
            passfile.flush()
207
 
            proc = subprocess.Popen(['gpg', '--decrypt',
208
 
                                     '--passphrase-file',
209
 
                                     passfile.name]
210
 
                                    + self.gnupgargs,
211
 
                                    stdin = subprocess.PIPE,
212
 
                                    stdout = subprocess.PIPE,
213
 
                                    stderr = subprocess.PIPE)
214
 
            decrypted_plaintext, err = proc.communicate(input
215
 
                                                        = data)
216
 
        if proc.returncode != 0:
217
 
            raise PGPError(err)
 
197
        self.gnupg.passphrase = self.password_encode(password)
 
198
        with open(os.devnull, "w") as devnull:
 
199
            try:
 
200
                proc = self.gnupg.run(['--decrypt'],
 
201
                                      create_fhs=['stdin', 'stdout'],
 
202
                                      attach_fhs={'stderr': devnull})
 
203
                with contextlib.closing(proc.handles['stdin']) as f:
 
204
                    f.write(data)
 
205
                with contextlib.closing(proc.handles['stdout']) as f:
 
206
                    decrypted_plaintext = f.read()
 
207
                proc.wait()
 
208
            except IOError as e:
 
209
                raise PGPError(e)
 
210
        self.gnupg.passphrase = None
218
211
        return decrypted_plaintext
219
212
 
220
213
 
240
233
               Used to optionally bind to the specified interface.
241
234
    name: string; Example: 'Mandos'
242
235
    type: string; Example: '_mandos._tcp'.
243
 
     See <https://www.iana.org/assignments/service-names-port-numbers>
 
236
                  See <http://www.dns-sd.org/ServiceTypes.html>
244
237
    port: integer; what port to announce
245
238
    TXT: list of strings; TXT record for the service
246
239
    domain: string; Domain to publish on, default to .local if empty.
446
439
    runtime_expansions: Allowed attributes for runtime expansion.
447
440
    expires:    datetime.datetime(); time (UTC) when a client will be
448
441
                disabled, or None
449
 
    server_settings: The server_settings dict from main()
450
442
    """
451
443
    
452
444
    runtime_expansions = ("approval_delay", "approval_duration",
454
446
                          "fingerprint", "host", "interval",
455
447
                          "last_approval_request", "last_checked_ok",
456
448
                          "last_enabled", "name", "timeout")
457
 
    client_defaults = { "timeout": "PT5M",
458
 
                        "extended_timeout": "PT15M",
459
 
                        "interval": "PT2M",
 
449
    client_defaults = { "timeout": "5m",
 
450
                        "extended_timeout": "15m",
 
451
                        "interval": "2m",
460
452
                        "checker": "fping -q -- %%(host)s",
461
453
                        "host": "",
462
 
                        "approval_delay": "PT0S",
463
 
                        "approval_duration": "PT1S",
 
454
                        "approval_delay": "0s",
 
455
                        "approval_duration": "1s",
464
456
                        "approved_by_default": "True",
465
457
                        "enabled": "True",
466
458
                        }
527
519
        
528
520
        return settings
529
521
    
530
 
    def __init__(self, settings, name = None, server_settings=None):
 
522
    def __init__(self, settings, name = None):
531
523
        self.name = name
532
 
        if server_settings is None:
533
 
            server_settings = {}
534
 
        self.server_settings = server_settings
535
524
        # adding all client settings
536
525
        for setting, value in settings.iteritems():
537
526
            setattr(self, setting, value)
690
679
        # If a checker exists, make sure it is not a zombie
691
680
        try:
692
681
            pid, status = os.waitpid(self.checker.pid, os.WNOHANG)
693
 
        except AttributeError:
694
 
            pass
695
 
        except OSError as error:
696
 
            if error.errno != errno.ECHILD:
697
 
                raise
 
682
        except (AttributeError, OSError) as error:
 
683
            if (isinstance(error, OSError)
 
684
                and error.errno != errno.ECHILD):
 
685
                raise error
698
686
        else:
699
687
            if pid:
700
688
                logger.warning("Checker was a zombie")
722
710
                # in normal mode, that is already done by daemon(),
723
711
                # and in debug mode we don't want to.  (Stdin is
724
712
                # always replaced by /dev/null.)
725
 
                # The exception is when not debugging but nevertheless
726
 
                # running in the foreground; use the previously
727
 
                # created wnull.
728
 
                popen_args = {}
729
 
                if (not self.server_settings["debug"]
730
 
                    and self.server_settings["foreground"]):
731
 
                    popen_args.update({"stdout": wnull,
732
 
                                       "stderr": wnull })
733
713
                self.checker = subprocess.Popen(command,
734
714
                                                close_fds=True,
735
 
                                                shell=True, cwd="/",
736
 
                                                **popen_args)
 
715
                                                shell=True, cwd="/")
737
716
            except OSError as error:
738
717
                logger.error("Failed to start subprocess",
739
718
                             exc_info=error)
740
 
                return True
741
719
            self.checker_callback_tag = (gobject.child_watch_add
742
720
                                         (self.checker.pid,
743
721
                                          self.checker_callback,
744
722
                                          data=command))
745
723
            # The checker may have completed before the gobject
746
724
            # watch was added.  Check for this.
747
 
            try:
748
 
                pid, status = os.waitpid(self.checker.pid, os.WNOHANG)
749
 
            except OSError as error:
750
 
                if error.errno == errno.ECHILD:
751
 
                    # This should never happen
752
 
                    logger.error("Child process vanished",
753
 
                                 exc_info=error)
754
 
                    return True
755
 
                raise
 
725
            pid, status = os.waitpid(self.checker.pid, os.WNOHANG)
756
726
            if pid:
757
727
                gobject.source_remove(self.checker_callback_tag)
758
728
                self.checker_callback(pid, status, command)
934
904
            # The byte_arrays option is not supported yet on
935
905
            # signatures other than "ay".
936
906
            if prop._dbus_signature != "ay":
937
 
                raise ValueError("Byte arrays not supported for non-"
938
 
                                 "'ay' signature {0!r}"
939
 
                                 .format(prop._dbus_signature))
 
907
                raise ValueError
940
908
            value = dbus.ByteArray(b''.join(chr(byte)
941
909
                                            for byte in value))
942
910
        prop(value)
1100
1068
                interface_names.add(alt_interface)
1101
1069
                # Is this a D-Bus signal?
1102
1070
                if getattr(attribute, "_dbus_is_signal", False):
1103
 
                    # Extract the original non-method undecorated
1104
 
                    # function by black magic
 
1071
                    # Extract the original non-method function by
 
1072
                    # black magic
1105
1073
                    nonmethod_func = (dict(
1106
1074
                            zip(attribute.func_code.co_freevars,
1107
1075
                                attribute.__closure__))["func"]
1705
1673
            logger.debug("Protocol version: %r", line)
1706
1674
            try:
1707
1675
                if int(line.strip().split()[0]) > 1:
1708
 
                    raise RuntimeError(line)
 
1676
                    raise RuntimeError
1709
1677
            except (ValueError, IndexError, RuntimeError) as error:
1710
1678
                logger.error("Unknown protocol version: %s", error)
1711
1679
                return
1918
1886
    
1919
1887
    def add_pipe(self, parent_pipe, proc):
1920
1888
        """Dummy function; override as necessary"""
1921
 
        raise NotImplementedError()
 
1889
        raise NotImplementedError
1922
1890
 
1923
1891
 
1924
1892
class IPv6_TCPServer(MultiprocessingMixInWithPipe,
1980
1948
                try:
1981
1949
                    self.socket.setsockopt(socket.SOL_SOCKET,
1982
1950
                                           SO_BINDTODEVICE,
1983
 
                                           str(self.interface + '\0'))
 
1951
                                           str(self.interface
 
1952
                                               + '\0'))
1984
1953
                except socket.error as error:
1985
1954
                    if error.errno == errno.EPERM:
1986
 
                        logger.error("No permission to bind to"
1987
 
                                     " interface %s", self.interface)
 
1955
                        logger.error("No permission to"
 
1956
                                     " bind to interface %s",
 
1957
                                     self.interface)
1988
1958
                    elif error.errno == errno.ENOPROTOOPT:
1989
1959
                        logger.error("SO_BINDTODEVICE not available;"
1990
1960
                                     " cannot bind to interface %s",
1991
1961
                                     self.interface)
1992
1962
                    elif error.errno == errno.ENODEV:
1993
 
                        logger.error("Interface %s does not exist,"
1994
 
                                     " cannot bind", self.interface)
 
1963
                        logger.error("Interface %s does not"
 
1964
                                     " exist, cannot bind",
 
1965
                                     self.interface)
1995
1966
                    else:
1996
1967
                        raise
1997
1968
        # Only bind(2) the socket if we really need to.
2000
1971
                if self.address_family == socket.AF_INET6:
2001
1972
                    any_address = "::" # in6addr_any
2002
1973
                else:
2003
 
                    any_address = "0.0.0.0" # INADDR_ANY
 
1974
                    any_address = socket.INADDR_ANY
2004
1975
                self.server_address = (any_address,
2005
1976
                                       self.server_address[1])
2006
1977
            elif not self.server_address[1]:
2122
2093
        return True
2123
2094
 
2124
2095
 
2125
 
def rfc3339_duration_to_delta(duration):
2126
 
    """Parse an RFC 3339 "duration" and return a datetime.timedelta
2127
 
    
2128
 
    >>> rfc3339_duration_to_delta("P7D")
2129
 
    datetime.timedelta(7)
2130
 
    >>> rfc3339_duration_to_delta("PT60S")
2131
 
    datetime.timedelta(0, 60)
2132
 
    >>> rfc3339_duration_to_delta("PT60M")
2133
 
    datetime.timedelta(0, 3600)
2134
 
    >>> rfc3339_duration_to_delta("PT24H")
2135
 
    datetime.timedelta(1)
2136
 
    >>> rfc3339_duration_to_delta("P1W")
2137
 
    datetime.timedelta(7)
2138
 
    >>> rfc3339_duration_to_delta("PT5M30S")
2139
 
    datetime.timedelta(0, 330)
2140
 
    >>> rfc3339_duration_to_delta("P1DT3M20S")
2141
 
    datetime.timedelta(1, 200)
2142
 
    """
2143
 
    
2144
 
    # Parsing an RFC 3339 duration with regular expressions is not
2145
 
    # possible - there would have to be multiple places for the same
2146
 
    # values, like seconds.  The current code, while more esoteric, is
2147
 
    # cleaner without depending on a parsing library.  If Python had a
2148
 
    # built-in library for parsing we would use it, but we'd like to
2149
 
    # avoid excessive use of external libraries.
2150
 
    
2151
 
    # New type for defining tokens, syntax, and semantics all-in-one
2152
 
    Token = collections.namedtuple("Token",
2153
 
                                   ("regexp", # To match token; if
2154
 
                                              # "value" is not None,
2155
 
                                              # must have a "group"
2156
 
                                              # containing digits
2157
 
                                    "value",  # datetime.timedelta or
2158
 
                                              # None
2159
 
                                    "followers")) # Tokens valid after
2160
 
                                                  # this token
2161
 
    # RFC 3339 "duration" tokens, syntax, and semantics; taken from
2162
 
    # the "duration" ABNF definition in RFC 3339, Appendix A.
2163
 
    token_end = Token(re.compile(r"$"), None, frozenset())
2164
 
    token_second = Token(re.compile(r"(\d+)S"),
2165
 
                         datetime.timedelta(seconds=1),
2166
 
                         frozenset((token_end,)))
2167
 
    token_minute = Token(re.compile(r"(\d+)M"),
2168
 
                         datetime.timedelta(minutes=1),
2169
 
                         frozenset((token_second, token_end)))
2170
 
    token_hour = Token(re.compile(r"(\d+)H"),
2171
 
                       datetime.timedelta(hours=1),
2172
 
                       frozenset((token_minute, token_end)))
2173
 
    token_time = Token(re.compile(r"T"),
2174
 
                       None,
2175
 
                       frozenset((token_hour, token_minute,
2176
 
                                  token_second)))
2177
 
    token_day = Token(re.compile(r"(\d+)D"),
2178
 
                      datetime.timedelta(days=1),
2179
 
                      frozenset((token_time, token_end)))
2180
 
    token_month = Token(re.compile(r"(\d+)M"),
2181
 
                        datetime.timedelta(weeks=4),
2182
 
                        frozenset((token_day, token_end)))
2183
 
    token_year = Token(re.compile(r"(\d+)Y"),
2184
 
                       datetime.timedelta(weeks=52),
2185
 
                       frozenset((token_month, token_end)))
2186
 
    token_week = Token(re.compile(r"(\d+)W"),
2187
 
                       datetime.timedelta(weeks=1),
2188
 
                       frozenset((token_end,)))
2189
 
    token_duration = Token(re.compile(r"P"), None,
2190
 
                           frozenset((token_year, token_month,
2191
 
                                      token_day, token_time,
2192
 
                                      token_week))),
2193
 
    # Define starting values
2194
 
    value = datetime.timedelta() # Value so far
2195
 
    found_token = None
2196
 
    followers = frozenset(token_duration,) # Following valid tokens
2197
 
    s = duration                # String left to parse
2198
 
    # Loop until end token is found
2199
 
    while found_token is not token_end:
2200
 
        # Search for any currently valid tokens
2201
 
        for token in followers:
2202
 
            match = token.regexp.match(s)
2203
 
            if match is not None:
2204
 
                # Token found
2205
 
                if token.value is not None:
2206
 
                    # Value found, parse digits
2207
 
                    factor = int(match.group(1), 10)
2208
 
                    # Add to value so far
2209
 
                    value += factor * token.value
2210
 
                # Strip token from string
2211
 
                s = token.regexp.sub("", s, 1)
2212
 
                # Go to found token
2213
 
                found_token = token
2214
 
                # Set valid next tokens
2215
 
                followers = found_token.followers
2216
 
                break
2217
 
        else:
2218
 
            # No currently valid tokens were found
2219
 
            raise ValueError("Invalid RFC 3339 duration")
2220
 
    # End token found
2221
 
    return value
2222
 
 
2223
 
 
2224
2096
def string_to_delta(interval):
2225
2097
    """Parse a string and return a datetime.timedelta
2226
2098
    
2237
2109
    >>> string_to_delta('5m 30s')
2238
2110
    datetime.timedelta(0, 330)
2239
2111
    """
2240
 
    
2241
 
    try:
2242
 
        return rfc3339_duration_to_delta(interval)
2243
 
    except ValueError:
2244
 
        pass
2245
 
    
2246
2112
    timevalue = datetime.timedelta(0)
2247
2113
    for s in interval.split():
2248
2114
        try:
2261
2127
            else:
2262
2128
                raise ValueError("Unknown suffix {0!r}"
2263
2129
                                 .format(suffix))
2264
 
        except IndexError as e:
 
2130
        except (ValueError, IndexError) as e:
2265
2131
            raise ValueError(*(e.args))
2266
2132
        timevalue += delta
2267
2133
    return timevalue
2311
2177
                        help="Run self-test")
2312
2178
    parser.add_argument("--debug", action="store_true",
2313
2179
                        help="Debug mode; run in foreground and log"
2314
 
                        " to terminal", default=None)
 
2180
                        " to terminal")
2315
2181
    parser.add_argument("--debuglevel", metavar="LEVEL",
2316
2182
                        help="Debug level for stdout output")
2317
2183
    parser.add_argument("--priority", help="GnuTLS"
2324
2190
                        " files")
2325
2191
    parser.add_argument("--no-dbus", action="store_false",
2326
2192
                        dest="use_dbus", help="Do not provide D-Bus"
2327
 
                        " system bus interface", default=None)
 
2193
                        " system bus interface")
2328
2194
    parser.add_argument("--no-ipv6", action="store_false",
2329
 
                        dest="use_ipv6", help="Do not use IPv6",
2330
 
                        default=None)
 
2195
                        dest="use_ipv6", help="Do not use IPv6")
2331
2196
    parser.add_argument("--no-restore", action="store_false",
2332
2197
                        dest="restore", help="Do not restore stored"
2333
 
                        " state", default=None)
 
2198
                        " state")
2334
2199
    parser.add_argument("--socket", type=int,
2335
2200
                        help="Specify a file descriptor to a network"
2336
2201
                        " socket to use instead of creating one")
2337
2202
    parser.add_argument("--statedir", metavar="DIR",
2338
2203
                        help="Directory to save/restore state in")
2339
 
    parser.add_argument("--foreground", action="store_true",
2340
 
                        help="Run in foreground", default=None)
2341
2204
    
2342
2205
    options = parser.parse_args()
2343
2206
    
2352
2215
                        "port": "",
2353
2216
                        "debug": "False",
2354
2217
                        "priority":
2355
 
                        "SECURE256:!CTYPE-X.509:+CTYPE-OPENPGP:+SIGN-RSA-SHA224:+SIGN-RSA-RMD160",
 
2218
                        "SECURE256:!CTYPE-X.509:+CTYPE-OPENPGP",
2356
2219
                        "servicename": "Mandos",
2357
2220
                        "use_dbus": "True",
2358
2221
                        "use_ipv6": "True",
2359
2222
                        "debuglevel": "",
2360
2223
                        "restore": "True",
2361
2224
                        "socket": "",
2362
 
                        "statedir": "/var/lib/mandos",
2363
 
                        "foreground": "False",
 
2225
                        "statedir": "/var/lib/mandos"
2364
2226
                        }
2365
2227
    
2366
2228
    # Parse config file for server-global settings
2371
2233
    # Convert the SafeConfigParser object to a dict
2372
2234
    server_settings = server_config.defaults()
2373
2235
    # Use the appropriate methods on the non-string config options
2374
 
    for option in ("debug", "use_dbus", "use_ipv6", "foreground"):
 
2236
    for option in ("debug", "use_dbus", "use_ipv6"):
2375
2237
        server_settings[option] = server_config.getboolean("DEFAULT",
2376
2238
                                                           option)
2377
2239
    if server_settings["port"]:
2393
2255
    for option in ("interface", "address", "port", "debug",
2394
2256
                   "priority", "servicename", "configdir",
2395
2257
                   "use_dbus", "use_ipv6", "debuglevel", "restore",
2396
 
                   "statedir", "socket", "foreground"):
 
2258
                   "statedir", "socket"):
2397
2259
        value = getattr(options, option)
2398
2260
        if value is not None:
2399
2261
            server_settings[option] = value
2402
2264
    for option in server_settings.keys():
2403
2265
        if type(server_settings[option]) is str:
2404
2266
            server_settings[option] = unicode(server_settings[option])
2405
 
    # Force all boolean options to be boolean
2406
 
    for option in ("debug", "use_dbus", "use_ipv6", "restore",
2407
 
                   "foreground"):
2408
 
        server_settings[option] = bool(server_settings[option])
2409
 
    # Debug implies foreground
2410
 
    if server_settings["debug"]:
2411
 
        server_settings["foreground"] = True
2412
2267
    # Now we have our good server settings in "server_settings"
2413
2268
    
2414
2269
    ##################################################################
2420
2275
    use_ipv6 = server_settings["use_ipv6"]
2421
2276
    stored_state_path = os.path.join(server_settings["statedir"],
2422
2277
                                     stored_state_file)
2423
 
    foreground = server_settings["foreground"]
2424
2278
    
2425
2279
    if debug:
2426
2280
        initlogger(debug, logging.DEBUG)
2458
2312
                              use_dbus=use_dbus,
2459
2313
                              socketfd=(server_settings["socket"]
2460
2314
                                        or None))
2461
 
    if not foreground:
2462
 
        pidfilename = "/run/mandos.pid"
2463
 
        if not os.path.isdir("/run/."):
2464
 
            pidfilename = "/var/run/mandos.pid"
2465
 
        pidfile = None
 
2315
    if not debug:
 
2316
        pidfilename = "/var/run/mandos.pid"
2466
2317
        try:
2467
2318
            pidfile = open(pidfilename, "w")
2468
2319
        except IOError as e:
2484
2335
        os.setuid(uid)
2485
2336
    except OSError as error:
2486
2337
        if error.errno != errno.EPERM:
2487
 
            raise
 
2338
            raise error
2488
2339
    
2489
2340
    if debug:
2490
2341
        # Enable all possible GnuTLS debugging
2507
2358
            os.close(null)
2508
2359
    
2509
2360
    # Need to fork before connecting to D-Bus
2510
 
    if not foreground:
 
2361
    if not debug:
2511
2362
        # Close all input and output, do double fork, etc.
2512
2363
        daemon()
2513
2364
    
2553
2404
    old_client_settings = {}
2554
2405
    clients_data = {}
2555
2406
    
2556
 
    # This is used to redirect stdout and stderr for checker processes
2557
 
    global wnull
2558
 
    wnull = open(os.devnull, "w") # A writable /dev/null
2559
 
    # Only used if server is running in foreground but not in debug
2560
 
    # mode
2561
 
    if debug or not foreground:
2562
 
        wnull.close()
2563
 
    
2564
2407
    # Get client data and settings from last running state.
2565
2408
    if server_settings["restore"]:
2566
2409
        try:
2582
2425
    
2583
2426
    with PGPEngine() as pgp:
2584
2427
        for client_name, client in clients_data.iteritems():
2585
 
            # Skip removed clients
2586
 
            if client_name not in client_settings:
2587
 
                continue
2588
 
            
2589
2428
            # Decide which value to use after restoring saved state.
2590
2429
            # We have three different values: Old config file,
2591
2430
            # new config file, and saved state.
2653
2492
    # Create all client objects
2654
2493
    for client_name, client in clients_data.iteritems():
2655
2494
        tcp_server.clients[client_name] = client_class(
2656
 
            name = client_name, settings = client,
2657
 
            server_settings = server_settings)
 
2495
            name = client_name, settings = client)
2658
2496
    
2659
2497
    if not tcp_server.clients:
2660
2498
        logger.warning("No clients defined")
2661
2499
    
2662
 
    if not foreground:
2663
 
        if pidfile is not None:
2664
 
            try:
2665
 
                with pidfile:
2666
 
                    pid = os.getpid()
2667
 
                    pidfile.write(str(pid) + "\n".encode("utf-8"))
2668
 
            except IOError:
2669
 
                logger.error("Could not write to file %r with PID %d",
2670
 
                             pidfilename, pid)
2671
 
        del pidfile
 
2500
    if not debug:
 
2501
        try:
 
2502
            with pidfile:
 
2503
                pid = os.getpid()
 
2504
                pidfile.write(str(pid) + "\n".encode("utf-8"))
 
2505
            del pidfile
 
2506
        except IOError:
 
2507
            logger.error("Could not write to file %r with PID %d",
 
2508
                         pidfilename, pid)
 
2509
        except NameError:
 
2510
            # "pidfile" was never created
 
2511
            pass
2672
2512
        del pidfilename
2673
2513
    
2674
2514
    signal.signal(signal.SIGHUP, lambda signum, frame: sys.exit())
2743
2583
        service.cleanup()
2744
2584
        
2745
2585
        multiprocessing.active_children()
2746
 
        wnull.close()
2747
2586
        if not (tcp_server.clients or client_settings):
2748
2587
            return
2749
2588
        
2761
2600
                # A list of attributes that can not be pickled
2762
2601
                # + secret.
2763
2602
                exclude = set(("bus", "changedstate", "secret",
2764
 
                               "checker", "server_settings"))
 
2603
                               "checker"))
2765
2604
                for name, typ in (inspect.getmembers
2766
2605
                                  (dbus.service.Object)):
2767
2606
                    exclude.add(name)
2795
2634
            else:
2796
2635
                logger.warning("Could not save persistent state:",
2797
2636
                               exc_info=e)
2798
 
                raise
 
2637
                raise e
2799
2638
        
2800
2639
        # Delete all clients, and settings from config
2801
2640
        while tcp_server.clients: