/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to TODO

  • Committer: Teddy Hogeborn
  • Date: 2015-05-23 20:18:34 UTC
  • mto: (237.7.304 trunk)
  • mto: This revision was merged to the branch mainline in revision 325.
  • Revision ID: teddy@recompile.se-20150523201834-e89ex4ito93yni8x
mandos: Use multiprocessing module to run checkers.

For a long time, the Mandos server has occasionally logged the message
"ERROR: Child process vanished".  This was never a fatal error, but it
has been annoying and slightly worrying, since a definite cause was
not found.  One potential cause could be the "multiprocessing" and
"subprocess" modules conflicting w.r.t. SIGCHLD.  To avoid this,
change the running of checkers from using subprocess.Popen
asynchronously to instead first create a multiprocessing.Process()
(which is asynchronous) calling a function, and have that function
then call subprocess.call() (which is synchronous).  In this way, the
only thing using any asynchronous subprocesses is the multiprocessing
module.

This makes it necessary to change one small thing in the D-Bus API,
since the subprocesses.call() function does not expose the raw wait(2)
status value.

DBUS-API (CheckerCompleted): Change the second value provided by this
                             D-Bus signal from the raw wait(2) status
                             to the actual terminating signal number.
mandos (subprocess_call_pipe): New function to be called by
                               multiprocessing.Process (starting a
                               separate process).
(Client.last_checker signal): New attribute for signal which
                              terminated last checker.  Like
                              last_checker_status, only not accessible
                              via D-Bus.
(Client.checker_callback): Take new "connection" argument and use it
                           to get returncode; set last_checker_signal.
                           Return False so gobject does not call this
                           callback again.
(Client.start_checker): Start checker using a multiprocessing.Process
                        instead of a subprocess.Popen.
(ClientDBus.checker_callback): Take new "connection" argument.        Call
                               Client.checker_callback early to have
                               it set last_checker_status and
                               last_checker_signal; use those.  Change
                               second value provided to D-Bus signal
                               CheckerCompleted to use
                               last_checker_signal if checker was
                               terminated by signal.
mandos-monitor: Update to reflect DBus API change.
(MandosClientWidget.checker_completed): Take "signal" instead of
                                        "condition" argument.  Use it
                                        accordingly.  Remove dead code
                                        (os.WCOREDUMP case).

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
1
-*- org -*-
2
2
 
 
3
* GIT
 
4
** General: [[https://www.atlassian.com/git/workflows][Git Workflows]], [[http://gitimmersion.com/][Git Immersion]], [[https://news.ycombinator.com/item?id=7036628][Simple git workflow is simple]]
 
5
** Intro: [[http://www.eyrie.org/~eagle/notes/debian/git.html#combine][Using Git for Debian Packaging]]
 
6
** Use: [[https://honk.sigxcpu.org/piki/projects/git-buildpackage/][git-buildpackage]]
 
7
** Migration
 
8
   tailor?
 
9
   Using bzr-fastimport: [[http://www.fusonic.net/en/blog/2013/03/26/migrating-from-bazaar-to-git/][Migrating from Bazaar to Git]]
 
10
** Unresolved: [[http://jameswestby.net/bzr/builddeb/user_manual/split.html][bzr builddeb split mode]]
 
11
   Maybe: [[http://honk.sigxcpu.org/projects/git-buildpackage/manual-html/gbp.import.html#GBP.IMPORT.UPSTREAM.GIT.NOTARBALL][git-buildpackage - No upstream tarballs]]
 
12
   [[http://www.python.org/dev/peps/pep-0374/][PEP 374 - Choosing a distributed VCS for the Python project]]
 
13
   [[http://www.emacswiki.org/emacs/GitForEmacsDevs][Git For Emacs Devs]]
 
14
 
 
15
* [[http://www.undeadly.org/cgi?action=article&sid=20110530221728][OpenBSD]]
 
16
 
3
17
* Testing
4
18
** python-nemu
5
19
 
6
20
* mandos-applet
7
21
 
8
22
* mandos-client
9
 
** TODO A --server option which only adds to the server list.
10
 
   (Unlike --connect, which implicitly disables zeroconf.)
 
23
** TODO [#A] --dh-params=FILE
11
24
** TODO [#B] Use capabilities instead of seteuid().
12
25
   https://forums.grsecurity.net/viewtopic.php?f=7&t=2522
13
26
** TODO [#B] Use getaddrinfo(hints=AI_NUMERICHOST) instead of inet_pton()
18
31
** TODO [#B] use scandir(3) instead of readdir(3)
19
32
 
20
33
* usplash (Deprecated)
21
 
** TODO [#B] Make it work again
 
34
** TODO [#A] Make it work again
22
35
** TODO [#B] use scandir(3) instead of readdir(3)
23
36
 
24
37
* askpass-fifo
37
50
** kernel command line option for debug info
38
51
 
39
52
* mandos (server)
 
53
** TODO [#B] Work around Avahi issue
 
54
   Avahi does not announce link-local addresses if any global
 
55
   addresses exist: http://lists.freedesktop.org/archives/avahi/2010-March/001863.html
40
56
** TODO [#B] --notify-command
41
57
   This would allow the mandos.service to use
42
 
   --notify-command="systemd-notify --pid --ready"
 
58
   --notify-command="systemd-notify --pid READY=1"
43
59
** TODO [#B] Log level                                                    :BUGS:
44
60
*** TODO /etc/mandos/clients.d/*.conf
45
61
    Watch this directory and add/remove/update clients?
54
70
    + Approve(False) -> Close client connection immediately
55
71
** TODO [#C] python-parsedatetime
56
72
** TODO Separate logging logic to own object
57
 
** TODO [#B] Limit approval_delay to max gnutls/tls timeout value
 
73
** TODO [#A] Limit approval_delay to max gnutls/tls timeout value
58
74
** TODO [#B] break the wait on approval_delay if connection dies
59
75
** TODO Generate Client.runtime_expansions from client options + extra
60
76
** TODO Allow %%(checker)s as a runtime expansion
 
77
** TODO Use python-tlslite?
61
78
** TODO D-Bus AddClient() method on server object
62
79
** TODO Use org.freedesktop.DBus.Method.NoReply annotation on async methods. :2:
 
80
** TODO Support [[http://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager][org.freedesktop.DBus.ObjectManager]] interface on server object :2:
 
81
   Deprecate methods GetAllClients(), GetAllClientsWithProperties()
 
82
   and signals ClientAdded and ClientRemoved.
63
83
** TODO Save state periodically to recover better from hard shutdowns
64
84
** TODO CheckerCompleted method, deprecate CheckedOK
65
85
** TODO Secret Service API?
66
86
   http://standards.freedesktop.org/secret-service/
67
87
** TODO Remove D-Bus interfaces with old domain name                      :2:
68
 
** TODO Remove old string_to_delta format                                 :2:
 
88
** TODO Remove old string_to_delta format                                    :2:
69
89
** TODO http://0pointer.de/blog/projects/stateless.html
 
90
*** tmpfiles snippet to create /var/lib/mandos with right user+perms
70
91
*** File in /usr/lib/sysusers.d to create user+group "_mandos"
71
92
** TODO Error handling on error parsing config files
72
93
** TODO init.d script error handling
73
 
** TODO D-Bus server properties; address, port, interface, etc.           :2:
74
 
** Python 3                                                               :2:
75
 
*** TODO [#C] In Python 3.3, use shlex.quote() instead of re.escape()
 
94
** TODO D-Bus server properties; address, port, interface, etc.              :2:
 
95
** TODO [#C] In Python 3.3, use shlex.quote() instead of re.escape()
 
96
 
 
97
* mandos.xml
 
98
** Add mandos contact info in manual pages
76
99
 
77
100
* mandos-ctl
78
101
*** Handle "no D-Bus server" and/or "no Mandos server found" better
79
102
*** [#B] --dump option
80
 
** TODO Remove old string_to_delta format                                 :2:
 
103
** TODO Remove old string_to_delta format                                    :2:
81
104
 
82
105
* TODO mandos-dispatch
83
106
  Listens for specified D-Bus signals and spawns shell commands with
84
107
  arguments.
85
108
 
86
109
* mandos-monitor
87
 
** TODO --servicename                                                  :BUGS:
88
110
** TODO help should be toggleable
89
111
** Urwid client data displayer
90
112
   Better view of client data in the listing
91
113
*** Properties popup
92
114
** Print a nice "We are sorry" message, save stack trace to log.
 
115
** Rename module "gobject" to "GObject".
93
116
 
94
117
* mandos-keygen
95
118
** TODO "--secfile" option
102
125
*** TODO [#C] use same file name rules as run-parts(8)
103
126
*** TODO [#C] Do not install in initrd.img if configured not to.
104
127
    Use "/etc/initramfs-tools/hooksconf.d/mandos"?
105
 
** TODO [#C] $(pkg-config --variable=completionsdir bash-completion)
 
128
** TODO [#C] /etc/bash_completion.d/mandos
106
129
   From XML sources directly?
107
130
 
108
131
* Side Stuff
109
132
** TODO Locate which package moves the other bin/sh when busybox is deactivated
110
133
** TODO contact owner of package, and ask them to have that shell static in position regardless of busybox
111
134
 
112
 
* [[http://www.undeadly.org/cgi?action=article&sid=20110530221728][OpenBSD]]
113
 
 
114
135
 
115
136
#+STARTUP: showall