19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@recompile.se>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
34
WIFEXITED(), WEXITSTATUS(), wait(),
35
pid_t, uid_t, gid_t, getuid(),
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
37
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
38
39
FD_SET(), FD_ISSET(), FD_CLR */
39
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
40
WEXITSTATUS(), WTERMSIG(),
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
52
53
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
55
#include <string.h> /* strsep, strlen(), asprintf() */
57
56
#include <errno.h> /* errno */
58
57
#include <argp.h> /* struct argp_option, struct
59
58
argp_state, struct argp,
414
372
.doc = "Group ID the plugins will run as", .group = 3 },
415
373
{ .name = "debug", .key = 132,
416
374
.doc = "Debug mode", .group = 4 },
418
* These reproduce what we would get without ARGP_NO_HELP
420
{ .name = "help", .key = '?',
421
.doc = "Give this help list", .group = -1 },
422
{ .name = "usage", .key = -3,
423
.doc = "Give a short usage message", .group = -1 },
424
{ .name = "version", .key = 'V',
425
.doc = "Print program version", .group = -1 },
429
__attribute__((nonnull(3)))
430
error_t parse_opt(int key, char *arg, struct argp_state *state){
378
error_t parse_opt(int key, char *arg, __attribute__((unused))
379
struct argp_state *state){
435
381
case 'g': /* --global-options */
438
while((plugin_option = strsep(&arg, ",")) != NULL){
439
if(not add_argument(getplugin(NULL), plugin_option)){
384
while((p = strsep(&arg, ",")) != NULL){
388
if(not add_argument(getplugin(NULL), p)){
389
perror("add_argument");
390
return ARGP_ERR_UNKNOWN;
446
395
case 'G': /* --global-env */
447
if(add_environment(getplugin(NULL), arg, true)){
399
if(not add_environment(getplugin(NULL), arg, true)){
400
perror("add_environment");
451
403
case 'o': /* --options-for */
453
char *option_list = strchr(arg, ':');
454
if(option_list == NULL){
455
argp_error(state, "No colon in \"%s\"", arg);
462
argp_error(state, "Empty plugin name");
467
while((option = strsep(&option_list, ",")) != NULL){
468
if(not add_argument(getplugin(arg), option)){
405
char *p_name = strsep(&arg, ":");
406
if(p_name[0] == '\0' or arg == NULL){
409
char *opt = strsep(&arg, ":");
410
if(opt[0] == '\0' or opt == NULL){
414
while((p = strsep(&opt, ",")) != NULL){
418
if(not add_argument(getplugin(p_name), p)){
419
perror("add_argument");
420
return ARGP_ERR_UNKNOWN;
475
425
case 'E': /* --env-for */
477
430
char *envdef = strchr(arg, ':');
478
431
if(envdef == NULL){
479
argp_error(state, "No colon in \"%s\"", arg);
486
argp_error(state, "Empty plugin name");
490
if(add_environment(getplugin(arg), envdef, true)){
435
if(not add_environment(getplugin(arg), envdef+1, true)){
436
perror("add_environment");
495
440
case 'd': /* --disable */
497
442
plugin *p = getplugin(arg);
444
return ARGP_ERR_UNKNOWN;
504
449
case 'e': /* --enable */
506
451
plugin *p = getplugin(arg);
453
return ARGP_ERR_UNKNOWN;
513
458
case 128: /* --plugin-dir */
515
460
plugindir = strdup(arg);
516
if(plugindir != NULL){
461
if(plugindir == NULL){
520
465
case 129: /* --config-file */
521
466
/* This is already done by parse_opt_config_file() */
523
468
case 130: /* --userid */
524
tmp_id = strtoimax(arg, &tmp, 10);
525
if(errno != 0 or tmp == arg or *tmp != '\0'
526
or tmp_id != (uid_t)tmp_id){
527
argp_error(state, "Bad user ID number: \"%s\", using %"
528
PRIdMAX, arg, (intmax_t)uid);
469
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
470
if(ret < 1 or tmpmax != (uid_t)tmpmax
471
or arg[numchars] != '\0'){
472
fprintf(stderr, "Bad user ID number: \"%s\", using %"
473
PRIdMAX "\n", arg, (intmax_t)uid);
534
478
case 131: /* --groupid */
535
tmp_id = strtoimax(arg, &tmp, 10);
536
if(errno != 0 or tmp == arg or *tmp != '\0'
537
or tmp_id != (gid_t)tmp_id){
538
argp_error(state, "Bad group ID number: \"%s\", using %"
539
PRIdMAX, arg, (intmax_t)gid);
479
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
480
if(ret < 1 or tmpmax != (gid_t)tmpmax
481
or arg[numchars] != '\0'){
482
fprintf(stderr, "Bad group ID number: \"%s\", using %"
483
PRIdMAX "\n", arg, (intmax_t)gid);
545
488
case 132: /* --debug */
549
* These reproduce what we would get without ARGP_NO_HELP
551
case '?': /* --help */
552
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
554
case -3: /* --usage */
555
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
argp_state_help(state, state->out_stream,
557
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
558
case 'V': /* --version */
559
fprintf(state->out_stream, "%s\n", argp_program_version);
563
492
* When adding more options before this line, remember to also add a
564
493
* "case" to the "parse_opt_config_file" function below.
679
598
new_arg = strdup(p);
680
599
if(new_arg == NULL){
681
error(0, errno, "strdup");
682
exitstatus = EX_OSERR;
601
exitstatus = EXIT_FAILURE;
687
606
custom_argc += 1;
689
char **new_argv = realloc(custom_argv, sizeof(char *)
692
if(new_argv == NULL){
693
error(0, errno, "realloc");
694
exitstatus = EX_OSERR;
699
custom_argv = new_argv;
607
custom_argv = realloc(custom_argv, sizeof(char *)
608
* ((unsigned int) custom_argc + 1));
609
if(custom_argv == NULL){
611
exitstatus = EXIT_FAILURE;
702
615
custom_argv[custom_argc-1] = new_arg;
703
custom_argv[custom_argc] = NULL;
616
custom_argv[custom_argc] = NULL;
707
ret = fclose(conffp);
708
} while(ret == EOF and errno == EINTR);
710
error(0, errno, "fclose");
711
exitstatus = EX_IOERR;
716
621
/* Check for harmful errors and go to fallback. Other errors might
717
622
not affect opening plugins */
718
623
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
719
error(0, errno, "fopen");
720
exitstatus = EX_OSERR;
625
exitstatus = EXIT_FAILURE;
724
/* If there were any arguments from the configuration file, pass
725
them to parser as command line arguments */
629
/* If there was any arguments from configuration file,
630
pass them to parser as command arguments */
726
631
if(custom_argv != NULL){
727
ret = argp_parse(&argp, custom_argc, custom_argv,
728
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
736
error(0, errno, "argp_parse");
737
exitstatus = EX_OSERR;
740
exitstatus = EX_CONFIG;
632
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
634
if(ret == ARGP_ERR_UNKNOWN){
635
fprintf(stderr, "Unknown error while parsing arguments\n");
636
exitstatus = EXIT_FAILURE;
745
641
/* Parse actual command line arguments, to let them override the
747
ret = argp_parse(&argp, argc, argv,
748
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
756
error(0, errno, "argp_parse");
757
exitstatus = EX_OSERR;
760
exitstatus = EX_USAGE;
643
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
644
if(ret == ARGP_ERR_UNKNOWN){
645
fprintf(stderr, "Unknown error while parsing arguments\n");
646
exitstatus = EXIT_FAILURE;
779
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
if(plugindir_fd == -1){
784
error(0, errno, "open(\"" PDIR "\")");
787
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
789
error(0, errno, "fstat");
791
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
792
ret = fchown(plugindir_fd, uid, gid);
794
error(0, errno, "fchown");
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
802
/* Lower permissions */
805
error(0, errno, "setgid");
664
/* Strip permissions down to nobody */
807
665
ret = setuid(uid);
809
error(0, errno, "setuid");
812
/* Open plugin directory with close_on_exec flag */
674
if(plugindir == NULL){
677
dir = opendir(plugindir);
681
perror("Could not open plugin dir");
682
exitstatus = EXIT_FAILURE;
686
/* Set the FD_CLOEXEC flag on the directory, if possible */
814
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
817
#else /* not O_CLOEXEC */
819
#endif /* not O_CLOEXEC */
822
error(0, errno, "Could not open plugin dir");
823
exitstatus = EX_UNAVAILABLE;
828
/* Set the FD_CLOEXEC flag on the directory */
829
ret = set_cloexec_flag(dir_fd);
831
error(0, errno, "set_cloexec_flag");
832
TEMP_FAILURE_RETRY(close(dir_fd));
833
exitstatus = EX_OSERR;
836
#endif /* O_CLOEXEC */
839
int good_name(const struct dirent * const dirent){
840
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
841
"*.dpkg-old", "*.dpkg-bak",
842
"*.dpkg-divert", NULL };
844
#pragma GCC diagnostic push
845
#pragma GCC diagnostic ignored "-Wcast-qual"
847
for(const char **pat = (const char **)patterns;
848
*pat != NULL; pat++){
850
#pragma GCC diagnostic pop
852
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
855
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
856
" matching pattern %s\n", dirent->d_name, *pat);
688
int dir_fd = dirfd(dir);
690
ret = set_cloexec_flag(dir_fd);
692
perror("set_cloexec_flag");
693
exitstatus = EXIT_FAILURE;
865
#if __GLIBC_PREREQ(2, 15)
866
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
868
#else /* not __GLIBC_PREREQ(2, 15) */
869
int numplugins = scandir(plugindir != NULL ? plugindir : PDIR,
870
&direntries, good_name, alphasort);
871
#endif /* not __GLIBC_PREREQ(2, 15) */
872
#else /* not __GLIBC__ */
873
int numplugins = scandir(plugindir != NULL ? plugindir : PDIR,
874
&direntries, good_name, alphasort);
875
#endif /* not __GLIBC__ */
876
if(numplugins == -1){
877
error(0, errno, "Could not scan plugin dir");
878
TEMP_FAILURE_RETRY(close(dir_fd));
879
exitstatus = EX_OSERR;
883
699
FD_ZERO(&rfds_all);
885
701
/* Read and execute any executable in the plugin directory*/
886
for(int i = 0; i < numplugins; i++){
888
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
890
error(0, errno, "Could not open plugin");
703
dirst = readdir(dir);
705
/* All directory entries have been processed */
709
exitstatus = EXIT_FAILURE;
715
d_name_len = strlen(dirst->d_name);
717
/* Ignore dotfiles, backup files and other junk */
719
bool bad_name = false;
721
const char const *bad_prefixes[] = { ".", "#", NULL };
723
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
726
".dpkg-divert", NULL };
727
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
728
size_t pre_len = strlen(*pre);
729
if((d_name_len >= pre_len)
730
and strncmp((dirst->d_name), *pre, pre_len) == 0){
732
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
733
" with bad prefix %s\n", dirst->d_name, *pre);
742
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
743
size_t suf_len = strlen(*suf);
744
if((d_name_len >= suf_len)
745
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
748
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
749
" with bad suffix %s\n", dirst->d_name, *suf);
762
if(plugindir == NULL){
763
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
765
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
893
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
772
ret = stat(filename, &st);
895
error(0, errno, "stat");
896
TEMP_FAILURE_RETRY(close(plugin_fd));
900
779
/* Ignore non-executable files */
901
if(not S_ISREG(st.st_mode)
902
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
780
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
905
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
906
" with bad type or mode\n",
907
plugindir != NULL ? plugindir : PDIR,
908
direntries[i]->d_name);
782
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
783
" with bad type or mode\n", filename);
910
TEMP_FAILURE_RETRY(close(plugin_fd));
914
plugin *p = getplugin(direntries[i]->d_name);
789
plugin *p = getplugin(dirst->d_name);
916
error(0, errno, "getplugin");
917
TEMP_FAILURE_RETRY(close(plugin_fd));
922
797
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
923
direntries[i]->d_name);
925
TEMP_FAILURE_RETRY(close(plugin_fd));
932
807
for(char **a = g->argv + 1; *a != NULL; a++){
933
808
if(not add_argument(p, *a)){
934
error(0, errno, "add_argument");
809
perror("add_argument");
937
812
/* Add global environment variables */
938
813
for(char **e = g->environ; *e != NULL; e++){
939
814
if(not add_environment(p, *e, false)){
940
error(0, errno, "add_environment");
815
perror("add_environment");
945
/* If this plugin has any environment variables, we need to
946
duplicate the environment from this process, too. */
820
/* If this plugin has any environment variables, we will call
821
using execve and need to duplicate the environment from this
947
823
if(p->environ[0] != NULL){
948
824
for(char **e = environ; *e != NULL; e++){
949
825
if(not add_environment(p, *e, false)){
950
error(0, errno, "add_environment");
826
perror("add_environment");
957
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
958
#else /* O_CLOEXEC */
959
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
960
#endif /* O_CLOEXEC */
962
error(0, errno, "pipe");
963
exitstatus = EX_OSERR;
966
if(pipefd[0] >= FD_SETSIZE){
967
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
969
TEMP_FAILURE_RETRY(close(pipefd[0]));
970
TEMP_FAILURE_RETRY(close(pipefd[1]));
971
exitstatus = EX_OSERR;
835
exitstatus = EXIT_FAILURE;
975
838
/* Ask OS to automatic close the pipe on exec */
976
839
ret = set_cloexec_flag(pipefd[0]);
978
error(0, errno, "set_cloexec_flag");
979
TEMP_FAILURE_RETRY(close(pipefd[0]));
980
TEMP_FAILURE_RETRY(close(pipefd[1]));
981
exitstatus = EX_OSERR;
841
perror("set_cloexec_flag");
842
exitstatus = EXIT_FAILURE;
984
845
ret = set_cloexec_flag(pipefd[1]);
986
error(0, errno, "set_cloexec_flag");
987
TEMP_FAILURE_RETRY(close(pipefd[0]));
988
TEMP_FAILURE_RETRY(close(pipefd[1]));
989
exitstatus = EX_OSERR;
847
perror("set_cloexec_flag");
848
exitstatus = EXIT_FAILURE;
992
#endif /* not O_CLOEXEC */
993
851
/* Block SIGCHLD until process is safely in process list */
994
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
995
&sigchld_action.sa_mask,
852
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
998
error(0, errno, "sigprocmask");
999
exitstatus = EX_OSERR;
854
perror("sigprocmask");
855
exitstatus = EXIT_FAILURE;
1002
858
/* Starting a new process to be watched */
1006
} while(pid == -1 and errno == EINTR);
1008
error(0, errno, "fork");
1009
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1010
&sigchld_action.sa_mask, NULL));
1011
TEMP_FAILURE_RETRY(close(pipefd[0]));
1012
TEMP_FAILURE_RETRY(close(pipefd[1]));
1013
exitstatus = EX_OSERR;
862
exitstatus = EXIT_FAILURE;
1017
866
/* this is the child process */
1018
867
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1020
error(0, errno, "sigaction");
1023
872
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1025
error(0, errno, "sigprocmask");
874
perror("sigprocmask");
1029
878
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1031
error(0, errno, "dup2");
1035
if(fexecve(plugin_fd, p->argv,
1036
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1037
error(0, errno, "fexecve for %s/%s",
1038
plugindir != NULL ? plugindir : PDIR,
1039
direntries[i]->d_name);
885
/* If dir has no file descriptor, we could not set FD_CLOEXEC
886
above and must now close it manually here. */
889
if(p->environ[0] == NULL){
890
if(execv(filename, p->argv) < 0){
895
if(execve(filename, p->argv, p->environ) < 0){
1044
902
/* Parent process */
1045
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1047
TEMP_FAILURE_RETRY(close(plugin_fd));
1048
plugin *new_plugin = getplugin(direntries[i]->d_name);
903
close(pipefd[1]); /* Close unused write end of pipe */
905
plugin *new_plugin = getplugin(dirst->d_name);
1049
906
if(new_plugin == NULL){
1050
error(0, errno, "getplugin");
1051
ret = (int)(TEMP_FAILURE_RETRY
1052
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
908
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1055
error(0, errno, "sigprocmask");
910
perror("sigprocmask");
1057
exitstatus = EX_OSERR;
912
exitstatus = EXIT_FAILURE;
1110
950
while(plugin_list){
1111
951
fd_set rfds = rfds_all;
1112
952
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
1113
if(select_ret == -1 and errno != EINTR){
1114
error(0, errno, "select");
1115
exitstatus = EX_OSERR;
953
if(select_ret == -1){
955
exitstatus = EXIT_FAILURE;
1118
958
/* OK, now either a process completed, or something can be read
1119
959
from one of them */
1120
960
for(plugin *proc = plugin_list; proc != NULL;){
1121
961
/* Is this process completely done? */
1122
if(proc->completed and proc->eof){
962
if(proc->eof and proc->completed){
1123
963
/* Only accept the plugin output if it exited cleanly */
1124
964
if(not WIFEXITED(proc->status)
1125
965
or WEXITSTATUS(proc->status) != 0){
1126
966
/* Bad exit by plugin */
1129
969
if(WIFEXITED(proc->status)){
1130
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1131
" status %d\n", proc->name,
1132
(intmax_t) (proc->pid),
970
fprintf(stderr, "Plugin %" PRIdMAX " exited with status"
971
" %d\n", (intmax_t) (proc->pid),
1133
972
WEXITSTATUS(proc->status));
1134
973
} else if(WIFSIGNALED(proc->status)){
1135
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1136
" signal %d: %s\n", proc->name,
1137
(intmax_t) (proc->pid),
1138
WTERMSIG(proc->status),
1139
strsignal(WTERMSIG(proc->status)));
974
fprintf(stderr, "Plugin %" PRIdMAX " killed by signal"
975
" %d\n", (intmax_t) (proc->pid),
976
WTERMSIG(proc->status));
1140
977
} else if(WCOREDUMP(proc->status)){
1141
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1142
" core\n", proc->name, (intmax_t) (proc->pid));
978
fprintf(stderr, "Plugin %" PRIdMAX " dumped core\n",
979
(intmax_t) (proc->pid));
1146
983
/* Remove the plugin */
1147
#if defined (__GNUC__) and defined (__GLIBC__)
1148
#if not __GLIBC_PREREQ(2, 16)
1149
#pragma GCC diagnostic push
1150
#pragma GCC diagnostic ignored "-Wsign-conversion"
1153
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1154
-Wconversion in GNU libc
1156
#if defined (__GNUC__) and defined (__GLIBC__)
1157
#if not __GLIBC_PREREQ(2, 16)
1158
#pragma GCC diagnostic pop
984
FD_CLR(proc->fd, &rfds_all);
1162
986
/* Block signal while modifying process_list */
1163
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1165
&sigchld_action.sa_mask,
987
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1168
error(0, errno, "sigprocmask");
1169
exitstatus = EX_OSERR;
989
perror("sigprocmask");
990
exitstatus = EXIT_FAILURE;
1196
1016
bool bret = print_out_password(proc->buffer,
1197
1017
proc->buffer_length);
1199
error(0, errno, "print_out_password");
1200
exitstatus = EX_IOERR;
1019
perror("print_out_password");
1020
exitstatus = EXIT_FAILURE;
1205
1025
/* This process has not completed. Does it have any output? */
1206
#if defined (__GNUC__) and defined (__GLIBC__)
1207
#if not __GLIBC_PREREQ(2, 16)
1208
#pragma GCC diagnostic push
1209
#pragma GCC diagnostic ignored "-Wsign-conversion"
1212
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1218
#if defined (__GNUC__) and defined (__GLIBC__)
1219
#if not __GLIBC_PREREQ(2, 16)
1220
#pragma GCC diagnostic pop
1026
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1223
1027
/* This process had nothing to say at this time */
1224
1028
proc = proc->next;
1227
1031
/* Before reading, make the process' data buffer large enough */
1228
1032
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1229
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1230
+ (size_t) BUFFER_SIZE);
1231
if(new_buffer == NULL){
1232
error(0, errno, "malloc");
1233
exitstatus = EX_OSERR;
1033
proc->buffer = realloc(proc->buffer, proc->buffer_size
1034
+ (size_t) BUFFER_SIZE);
1035
if(proc->buffer == NULL){
1037
exitstatus = EXIT_FAILURE;
1236
proc->buffer = new_buffer;
1237
1040
proc->buffer_size += BUFFER_SIZE;
1239
1042
/* Read from the process */
1240
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1242
+ proc->buffer_length,
1043
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1245
1046
/* Read error from this process; ignore the error */
1246
1047
proc = proc->next;