/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to plugins.d/askpass-fifo.c

* README (The Plugin System): Removed redundant text about options and
                              files for the plugins, this is now
                              documented in the manuals for the
                              plugins.

* plugins.d/mandos-client.c (main): Remove comment which was copied
                                    from another program by mistake.
                                    Use "sscanf" instead of "strtol"
                                    to parse numbers; this uses the
                                    correct type instead of casting.
                                    Don't report errors when removing
                                    temporary directory if directory
                                    is already gone.

Show diffs side-by-side

added added

removed removed

Lines of Context:
plugins.d/askpass-fifo.c
19
19
 * along with this program.  If not, see
20
20
 * <http://www.gnu.org/licenses/>.
21
21
 * 
22
 
 * Contact the authors at <mandos@fukt.bsnet.se>.
 
22
 * Contact the authors at <https://www.fukt.bsnet.se/~belorn/> and
 
23
 * <https://www.fukt.bsnet.se/~teddy/>.
23
24
 */
24
25
 
25
26
#define _GNU_SOURCE             /* TEMP_FAILURE_RETRY() */
28
29
#include <iso646.h>             /* and */
29
30
#include <errno.h>              /* errno, EEXIST */
30
31
#include <stdio.h>              /* perror() */
31
 
#include <stdlib.h>             /* EXIT_FAILURE, NULL, size_t, free(),
 
32
#include <stdlib.h>             /* EXIT_FAILURE, NULL, size_t, free(), 
32
33
                                   realloc(), EXIT_SUCCESS */
33
34
#include <fcntl.h>              /* open(), O_RDONLY */
34
35
#include <unistd.h>             /* read(), close(), write(),
42
43
  
43
44
  /* Create FIFO */
44
45
  const char passfifo[] = "/lib/cryptsetup/passfifo";
45
 
  ret = mkfifo(passfifo, S_IRUSR | S_IWUSR);
 
46
  ret = (int)TEMP_FAILURE_RETRY(mkfifo(passfifo, S_IRUSR | S_IWUSR));
46
47
  if(ret == -1 and errno != EEXIST){
47
48
    perror("mkfifo");
48
49
    return EXIT_FAILURE;
49
50
  }
50
51
  
51
52
  /* Open FIFO */
52
 
  int fifo_fd = open(passfifo, O_RDONLY);
 
53
  int fifo_fd = (int)TEMP_FAILURE_RETRY(open(passfifo, O_RDONLY));
53
54
  if(fifo_fd == -1){
54
55
    perror("open");
55
56
    return EXIT_FAILURE;
61
62
  {
62
63
    size_t buf_allocated = 0;
63
64
    const size_t blocksize = 1024;
64
 
    do {
 
65
    do{
65
66
      if(buf_len + blocksize > buf_allocated){
66
67
        char *tmp = realloc(buf, buf_allocated + blocksize);
67
68
        if(tmp == NULL){
72
73
        buf = tmp;
73
74
        buf_allocated += blocksize;
74
75
      }
75
 
      sret = read(fifo_fd, buf + buf_len, buf_allocated - buf_len);
 
76
      sret = TEMP_FAILURE_RETRY(read(fifo_fd, buf + buf_len,
 
77
                                     buf_allocated - buf_len));
76
78
      if(sret == -1){
77
79
        perror("read");
78
80
        free(buf);
79
81
        return EXIT_FAILURE;
80
82
      }
81
83
      buf_len += (size_t)sret;
82
 
    } while(sret != 0);
 
84
    }while(sret != 0);
83
85
  }
84
86
  
85
87
  /* Close FIFO */
86
 
  close(fifo_fd);
 
88
  TEMP_FAILURE_RETRY(close(fifo_fd));
87
89
  
88
90
  /* Print password to stdout */
89
91
  size_t written = 0;
90
92
  while(written < buf_len){
91
 
    sret = write(STDOUT_FILENO, buf + written, buf_len - written);
 
93
    sret = TEMP_FAILURE_RETRY(write(STDOUT_FILENO, buf + written,
 
94
                                    buf_len - written));
92
95
    if(sret == -1){
93
96
      perror("write");
94
97
      free(buf);