/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to Makefile

Convert some programs to use the exit codes from <sysexits.h>.  Change
all programs using the "argp" parsing functions to use them correctly;
checking return value, using argp_error() to report parse errors etc.

* plugin-runner.c: Use <sysexits.h> exit codes.  Always use fallback,
                   even on option errors, except for "--help", etc.
  (getplugin): Make sure "errno" is set correctly on return.
  (main): Declare our own "--help", "--usage", and "--version"
          options which do not cause the fallback to be invoked.
          In all other options, use fallback on any error.
  (parse_opt, parse_opt_config_file): Reset errno at start and return
                                      errno.  No need to check "arg"
                                      for NULL.  New "--help",
                                      "--usage", and "--version"
                                      options.
  (parse_opt): Accept empty string as global option.  Do not print
               errors which will be detected and reported later.  Do
               "argp_error()" on parse error or empty plugin names.
* plugins.d/mandos-client.c: Use <sysexits.h> exit codes.  Do not
                             return successful exit code on "--help",
                             etc. since this would give the wrong
                             message to "plugin-runner".
  (main): Declare our own "--help", "--usage", and "--version"
          options which do not return a successful exit code.
  (parse_opt): Reset errno at start and return errno.  Do
               "argp_error()" on parse errors.  New "--help",
               "--usage", and "--version" options.
* plugins.d/password-prompt.c: Use exit codes from <sysexits.h>.  Do
                               not return successful exit code on
                               "--help", etc. since this would give
                               the wrong message to "plugin-runner".
  (main): Declare our own "--help", "--usage", and "--version" options
          which do not return a successful exit code.  Do
          close(STDOUT_FILENO) after writing to check its return code.
  (parse_opt): Reset errno at start and return errno.

Show diffs side-by-side

added added

removed removed

Lines of Context:
5
5
        -Wbad-function-cast -Wcast-qual -Wcast-align -Wwrite-strings \
6
6
        -Wconversion -Wstrict-prototypes -Wold-style-definition \
7
7
        -Wpacked -Wnested-externs -Winline -Wvolatile-register-var
8
 
#       -Wunreachable-code
 
8
#       -Wunreachable-code 
9
9
#DEBUG=-ggdb3
10
10
# For info about _FORTIFY_SOURCE, see
11
11
# <http://www.kernel.org/doc/man-pages/online/pages/man7/feature_test_macros.7.html>
12
12
# and <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
13
 
FORTIFY=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC
14
 
LINK_FORTIFY_LD=-z relro -z now
15
 
LINK_FORTIFY=
16
 
 
17
 
# If BROKEN_PIE is set, do not build with -pie
18
 
ifndef BROKEN_PIE
19
 
FORTIFY += -fPIE
20
 
LINK_FORTIFY += -pie
21
 
endif
 
13
FORTIFY=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC -fPIE
 
14
LINK_FORTIFY_LD=-z relro -fPIE
 
15
LINK_FORTIFY=-pie
22
16
#COVERAGE=--coverage
23
17
OPTIMIZE=-Os
24
18
LANGUAGE=-std=gnu99
25
19
htmldir=man
26
 
version=1.5.3
 
20
version=1.0.13
27
21
SED=sed
28
22
 
29
 
USER=$(firstword $(subst :, ,$(shell getent passwd _mandos || getent passwd nobody || echo 65534)))
30
 
GROUP=$(firstword $(subst :, ,$(shell getent group _mandos || getent group nobody || echo 65534)))
31
 
 
32
23
## Use these settings for a traditional /usr/local install
33
24
# PREFIX=$(DESTDIR)/usr/local
34
25
# CONFDIR=$(DESTDIR)/etc/mandos
35
26
# KEYDIR=$(DESTDIR)/etc/mandos/keys
36
27
# MANDIR=$(PREFIX)/man
37
28
# INITRAMFSTOOLS=$(DESTDIR)/etc/initramfs-tools
38
 
# STATEDIR=$(DESTDIR)/var/lib/mandos
39
29
##
40
30
 
41
31
## These settings are for a package-type install
44
34
KEYDIR=$(DESTDIR)/etc/keys/mandos
45
35
MANDIR=$(PREFIX)/share/man
46
36
INITRAMFSTOOLS=$(DESTDIR)/usr/share/initramfs-tools
47
 
STATEDIR=$(DESTDIR)/var/lib/mandos
48
37
##
49
38
 
50
39
GNUTLS_CFLAGS=$(shell pkg-config --cflags-only-I gnutls)
59
48
CFLAGS=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
60
49
        $(LANGUAGE) $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) $(GPGME_CFLAGS) \
61
50
        -DVERSION='"$(version)"'
62
 
LDFLAGS=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
 
51
LDFLAGS=$(COVERAGE) $(LINK_FORTIFY) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
63
52
 
64
53
# Commands to format a DocBook <refentry> document into a manual page
65
 
DOCBOOKTOMAN=$(strip cd $(dir $<); xsltproc --nonet --xinclude \
 
54
DOCBOOKTOMAN=cd $(dir $<); xsltproc --nonet --xinclude \
66
55
        --param man.charmap.use.subset          0 \
67
56
        --param make.year.ranges                1 \
68
57
        --param make.single.year.ranges         1 \
70
59
        --param man.authors.section.enabled     0 \
71
60
         /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl \
72
61
        $(notdir $<); \
73
 
        $(MANPOST) $(notdir $@);\
74
 
        LANG=en_US.UTF-8 MANWIDTH=80 man --warnings --encoding=UTF-8 \
75
 
        --local-file $(notdir $@) >/dev/null)
 
62
        $(MANPOST) $(notdir $@)
76
63
# DocBook-to-man post-processing to fix a '\n' escape bug
77
64
MANPOST=$(SED) --in-place --expression='s,\\\\en,\\en,g;s,\\n,\\en,g'
78
65
 
79
 
DOCBOOKTOHTML=$(strip xsltproc --nonet --xinclude \
 
66
DOCBOOKTOHTML=xsltproc --nonet --xinclude \
80
67
        --param make.year.ranges                1 \
81
68
        --param make.single.year.ranges         1 \
82
69
        --param man.output.quietly              1 \
84
71
        --param citerefentry.link               1 \
85
72
        --output $@ \
86
73
        /usr/share/xml/docbook/stylesheet/nwalsh/xhtml/docbook.xsl \
87
 
        $<; $(HTMLPOST) $@)
 
74
        $<; $(HTMLPOST) $@
88
75
# Fix citerefentry links
89
76
HTMLPOST=$(SED) --in-place \
90
77
        --expression='s/\(<a class="citerefentry" href="\)\("><span class="citerefentry"><span class="refentrytitle">\)\([^<]*\)\(<\/span>(\)\([^)]*\)\()<\/span><\/a>\)/\1\3.\5\2\3\4\5\6/g'
91
78
 
92
79
PLUGINS=plugins.d/password-prompt plugins.d/mandos-client \
93
 
        plugins.d/usplash plugins.d/splashy plugins.d/askpass-fifo \
94
 
        plugins.d/plymouth
 
80
        plugins.d/usplash plugins.d/splashy plugins.d/askpass-fifo
95
81
CPROGS=plugin-runner $(PLUGINS)
96
 
PROGS=mandos mandos-keygen mandos-ctl mandos-monitor $(CPROGS)
97
 
DOCS=mandos.8 mandos-keygen.8 mandos-monitor.8 mandos-ctl.8 \
98
 
        mandos.conf.5 mandos-clients.conf.5 plugin-runner.8mandos \
 
82
PROGS=mandos mandos-keygen mandos-ctl $(CPROGS)
 
83
DOCS=mandos.8 plugin-runner.8mandos mandos-keygen.8 \
99
84
        plugins.d/mandos-client.8mandos \
100
 
        plugins.d/password-prompt.8mandos plugins.d/usplash.8mandos \
101
 
        plugins.d/splashy.8mandos plugins.d/askpass-fifo.8mandos \
102
 
        plugins.d/plymouth.8mandos intro.8mandos
 
85
        plugins.d/password-prompt.8mandos mandos.conf.5 \
 
86
        plugins.d/usplash.8mandos plugins.d/splashy.8mandos \
 
87
        plugins.d/askpass-fifo.8mandos mandos-clients.conf.5
103
88
 
104
89
htmldocs=$(addsuffix .xhtml,$(DOCS))
105
90
 
126
111
%.8mandos.xhtml: %.xml common.ent legalnotice.xml
127
112
        $(DOCBOOKTOHTML)
128
113
 
129
 
intro.8mandos: intro.xml common.ent legalnotice.xml
130
 
        $(DOCBOOKTOMAN)
131
 
intro.8mandos.xhtml: intro.xml common.ent legalnotice.xml
132
 
        $(DOCBOOKTOHTML)
133
 
 
134
114
mandos.8: mandos.xml common.ent mandos-options.xml overview.xml \
135
115
                legalnotice.xml
136
116
        $(DOCBOOKTOMAN)
145
125
                 legalnotice.xml
146
126
        $(DOCBOOKTOHTML)
147
127
 
148
 
mandos-monitor.8: mandos-monitor.xml common.ent overview.xml \
149
 
                legalnotice.xml
150
 
        $(DOCBOOKTOMAN)
151
 
mandos-monitor.8.xhtml: mandos-monitor.xml common.ent overview.xml \
152
 
                 legalnotice.xml
153
 
        $(DOCBOOKTOHTML)
154
 
 
155
 
mandos-ctl.8: mandos-ctl.xml common.ent overview.xml \
156
 
                legalnotice.xml
157
 
        $(DOCBOOKTOMAN)
158
 
mandos-ctl.8.xhtml: mandos-ctl.xml common.ent overview.xml \
159
 
                 legalnotice.xml
160
 
        $(DOCBOOKTOHTML)
161
 
 
162
128
mandos.conf.5: mandos.conf.xml common.ent mandos-options.xml \
163
129
                legalnotice.xml
164
130
        $(DOCBOOKTOMAN)
186
152
 
187
153
# Update all these files with version number $(version)
188
154
common.ent: Makefile
189
 
        $(strip $(SED) --in-place \
 
155
        $(SED) --in-place \
190
156
                --expression='s/^\(<!ENTITY version "\)[^"]*">$$/\1$(version)">/' \
191
 
                $@)
 
157
                $@
192
158
 
193
159
mandos: Makefile
194
 
        $(strip $(SED) --in-place \
 
160
        $(SED) --in-place \
195
161
                --expression='s/^\(version = "\)[^"]*"$$/\1$(version)"/' \
196
 
                $@)
 
162
                $@
197
163
 
198
164
mandos-keygen: Makefile
199
 
        $(strip $(SED) --in-place \
 
165
        $(SED) --in-place \
200
166
                --expression='s/^\(VERSION="\)[^"]*"$$/\1$(version)"/' \
201
 
                $@)
 
167
                $@
202
168
 
203
169
mandos-ctl: Makefile
204
 
        $(strip $(SED) --in-place \
205
 
                --expression='s/^\(version = "\)[^"]*"$$/\1$(version)"/' \
206
 
                $@)
207
 
 
208
 
mandos-monitor: Makefile
209
 
        $(strip $(SED) --in-place \
210
 
                --expression='s/^\(version = "\)[^"]*"$$/\1$(version)"/' \
211
 
                $@)
 
170
        $(SED) --in-place \
 
171
                --expression='s/^\(version = "\)[^"]*"$$/\1$(version)"/' \
 
172
                $@
212
173
 
213
174
mandos.lsm: Makefile
214
 
        $(strip $(SED) --in-place \
 
175
        $(SED) --in-place \
215
176
                --expression='s/^\(Version:\).*/\1\t$(version)/' \
216
 
                $@)
217
 
        $(strip $(SED) --in-place \
 
177
                $@
 
178
        $(SED) --in-place \
218
179
                --expression='s/^\(Entered-date:\).*/\1\t$(shell date --rfc-3339=date --reference=Makefile)/' \
219
 
                $@)
220
 
        $(strip $(SED) --in-place \
 
180
                $@
 
181
        $(SED) --in-place \
221
182
                --expression='s/\(mandos_\)[0-9.]\+\(\.orig\.tar\.gz\)/\1$(version)\2/' \
222
 
                $@)
 
183
                $@
223
184
 
224
 
plugins.d/mandos-client: plugins.d/mandos-client.c
225
 
        $(LINK.c) $^ -lrt $(GNUTLS_LIBS) $(AVAHI_LIBS) $(strip\
226
 
                ) $(GPGME_LIBS) $(LOADLIBES) $(LDLIBS) -o $@
 
185
plugins.d/mandos-client: plugins.d/mandos-client.o
 
186
        $(LINK.o) $(GNUTLS_LIBS) $(AVAHI_LIBS) $(GPGME_LIBS) \
 
187
                $(COMMON) $^ $(LOADLIBES) $(LDLIBS) -o $@
227
188
 
228
189
.PHONY : all doc html clean distclean run-client run-server install \
229
190
        install-server install-client uninstall uninstall-server \
235
196
distclean: clean
236
197
mostlyclean: clean
237
198
maintainer-clean: clean
238
 
        -rm --force --recursive keydir confdir statedir
 
199
        -rm --force --recursive keydir confdir
239
200
 
240
201
check:  all
241
202
        ./mandos --check
242
203
 
243
204
# Run the client with a local config and key
244
205
run-client: all keydir/seckey.txt keydir/pubkey.txt
245
 
        @echo "###################################################################"
246
 
        @echo "# The following error messages are harmless and can be safely     #"
247
 
        @echo "# ignored.  The messages are caused by not running as root, but   #"
248
 
        @echo "# you should NOT run \"make run-client\" as root unless you also    #"
249
 
        @echo "# unpacked and compiled Mandos as root, which is NOT recommended. #"
250
 
        @echo "# From plugin-runner: setuid: Operation not permitted             #"
251
 
        @echo "# From askpass-fifo:  mkfifo: Permission denied                   #"
252
 
        @echo "# From mandos-client: setuid: Operation not permitted             #"
253
 
        @echo "#                     seteuid: Operation not permitted            #"
254
 
        @echo "#                     klogctl: Operation not permitted            #"
255
 
        @echo "###################################################################"
256
206
        ./plugin-runner --plugin-dir=plugins.d \
257
207
                --config-file=plugin-runner.conf \
258
 
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt,--network-hook-dir=network-hooks.d \
 
208
                --options-for=mandos-client:--seckey=keydir/seckey.txt,--pubkey=keydir/pubkey.txt \
259
209
                $(CLIENTARGS)
260
210
 
261
211
# Used by run-client
265
215
 
266
216
# Run the server with a local config
267
217
run-server: confdir/mandos.conf confdir/clients.conf
268
 
        ./mandos --debug --no-dbus --configdir=confdir \
269
 
                --statedir=statedir $(SERVERARGS)
 
218
        ./mandos --debug --no-dbus --configdir=confdir $(SERVERARGS)
270
219
 
271
220
# Used by run-server
272
221
confdir/mandos.conf: mandos.conf
277
226
        install --mode=u=rw $< $@
278
227
# Add a client password
279
228
        ./mandos-keygen --dir keydir --password >> $@
280
 
statedir:
281
 
        install --directory statedir
282
229
 
283
230
install: install-server install-client-nokey
284
231
 
289
236
 
290
237
install-server: doc
291
238
        install --directory $(CONFDIR)
292
 
        install --directory --mode=u=rwx --owner=$(USER) \
293
 
                --group=$(GROUP) $(STATEDIR)
294
239
        install --mode=u=rwx,go=rx mandos $(PREFIX)/sbin/mandos
295
 
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
296
 
                mandos-ctl
297
 
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
298
 
                mandos-monitor
299
240
        install --mode=u=rw,go=r --target-directory=$(CONFDIR) \
300
241
                mandos.conf
301
242
        install --mode=u=rw --target-directory=$(CONFDIR) \
302
243
                clients.conf
303
 
        install --mode=u=rw,go=r dbus-mandos.conf \
304
 
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
305
244
        install --mode=u=rwx,go=rx init.d-mandos \
306
245
                $(DESTDIR)/etc/init.d/mandos
307
246
        install --mode=u=rw,go=r default-mandos \
311
250
        fi
312
251
        gzip --best --to-stdout mandos.8 \
313
252
                > $(MANDIR)/man8/mandos.8.gz
314
 
        gzip --best --to-stdout mandos-monitor.8 \
315
 
                > $(MANDIR)/man8/mandos-monitor.8.gz
316
 
        gzip --best --to-stdout mandos-ctl.8 \
317
 
                > $(MANDIR)/man8/mandos-ctl.8.gz
318
253
        gzip --best --to-stdout mandos.conf.5 \
319
254
                > $(MANDIR)/man5/mandos.conf.5.gz
320
255
        gzip --best --to-stdout mandos-clients.conf.5 \
321
256
                > $(MANDIR)/man5/mandos-clients.conf.5.gz
322
 
        gzip --best --to-stdout intro.8mandos \
323
 
                > $(MANDIR)/man8/intro.8mandos.gz
324
257
 
325
258
install-client-nokey: all doc
326
259
        install --directory $(PREFIX)/lib/mandos $(CONFDIR)
330
263
                install --mode=u=rwx \
331
264
                        --directory "$(CONFDIR)/plugins.d"; \
332
265
        fi
333
 
        install --mode=u=rwx,go=rx --directory \
334
 
                "$(CONFDIR)/network-hooks.d"
335
266
        install --mode=u=rwx,go=rx \
336
267
                --target-directory=$(PREFIX)/lib/mandos plugin-runner
337
268
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
351
282
        install --mode=u=rwxs,go=rx \
352
283
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
353
284
                plugins.d/askpass-fifo
354
 
        install --mode=u=rwxs,go=rx \
355
 
                --target-directory=$(PREFIX)/lib/mandos/plugins.d \
356
 
                plugins.d/plymouth
357
285
        install initramfs-tools-hook \
358
286
                $(INITRAMFSTOOLS)/hooks/mandos
359
287
        install --mode=u=rw,go=r initramfs-tools-hook-conf \
365
293
                > $(MANDIR)/man8/mandos-keygen.8.gz
366
294
        gzip --best --to-stdout plugin-runner.8mandos \
367
295
                > $(MANDIR)/man8/plugin-runner.8mandos.gz
 
296
        gzip --best --to-stdout plugins.d/password-prompt.8mandos \
 
297
                > $(MANDIR)/man8/password-prompt.8mandos.gz
368
298
        gzip --best --to-stdout plugins.d/mandos-client.8mandos \
369
299
                > $(MANDIR)/man8/mandos-client.8mandos.gz
370
 
        gzip --best --to-stdout plugins.d/password-prompt.8mandos \
371
 
                > $(MANDIR)/man8/password-prompt.8mandos.gz
372
300
        gzip --best --to-stdout plugins.d/usplash.8mandos \
373
301
                > $(MANDIR)/man8/usplash.8mandos.gz
374
302
        gzip --best --to-stdout plugins.d/splashy.8mandos \
375
303
                > $(MANDIR)/man8/splashy.8mandos.gz
376
304
        gzip --best --to-stdout plugins.d/askpass-fifo.8mandos \
377
305
                > $(MANDIR)/man8/askpass-fifo.8mandos.gz
378
 
        gzip --best --to-stdout plugins.d/plymouth.8mandos \
379
 
                > $(MANDIR)/man8/plymouth.8mandos.gz
380
306
 
381
307
install-client: install-client-nokey
382
308
# Post-installation stuff
388
314
 
389
315
uninstall-server:
390
316
        -rm --force $(PREFIX)/sbin/mandos \
391
 
                $(PREFIX)/sbin/mandos-ctl \
392
 
                $(PREFIX)/sbin/mandos-monitor \
393
317
                $(MANDIR)/man8/mandos.8.gz \
394
 
                $(MANDIR)/man8/mandos-monitor.8.gz \
395
 
                $(MANDIR)/man8/mandos-ctl.8.gz \
396
318
                $(MANDIR)/man5/mandos.conf.5.gz \
397
319
                $(MANDIR)/man5/mandos-clients.conf.5.gz
398
320
        update-rc.d -f mandos remove
410
332
                $(PREFIX)/lib/mandos/plugins.d/usplash \
411
333
                $(PREFIX)/lib/mandos/plugins.d/splashy \
412
334
                $(PREFIX)/lib/mandos/plugins.d/askpass-fifo \
413
 
                $(PREFIX)/lib/mandos/plugins.d/plymouth \
414
335
                $(INITRAMFSTOOLS)/hooks/mandos \
415
336
                $(INITRAMFSTOOLS)/conf-hooks.d/mandos \
416
337
                $(INITRAMFSTOOLS)/scripts/init-premount/mandos \
 
338
                $(MANDIR)/man8/plugin-runner.8mandos.gz \
417
339
                $(MANDIR)/man8/mandos-keygen.8.gz \
418
 
                $(MANDIR)/man8/plugin-runner.8mandos.gz \
419
 
                $(MANDIR)/man8/mandos-client.8mandos.gz
420
340
                $(MANDIR)/man8/password-prompt.8mandos.gz \
421
341
                $(MANDIR)/man8/usplash.8mandos.gz \
422
342
                $(MANDIR)/man8/splashy.8mandos.gz \
423
343
                $(MANDIR)/man8/askpass-fifo.8mandos.gz \
424
 
                $(MANDIR)/man8/plymouth.8mandos.gz \
 
344
                $(MANDIR)/man8/mandos-client.8mandos.gz
425
345
        -rmdir $(PREFIX)/lib/mandos/plugins.d $(CONFDIR)/plugins.d \
426
346
                 $(PREFIX)/lib/mandos $(CONFDIR) $(KEYDIR)
427
347
        update-initramfs -k all -u
430
350
 
431
351
purge-server: uninstall-server
432
352
        -rm --force $(CONFDIR)/mandos.conf $(CONFDIR)/clients.conf \
433
 
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
434
353
                $(DESTDIR)/etc/default/mandos \
435
354
                $(DESTDIR)/etc/init.d/mandos \
436
355
                $(DESTDIR)/var/run/mandos.pid