/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

  • Committer: teddy at recompile
  • Date: 2020-04-05 21:30:59 UTC
  • Revision ID: teddy@recompile.se-20200405213059-fb2a61ckqynrmatk
Fix file descriptor leak in mandos-client

When the local network has Mandos servers announcing themselves using
real, globally reachable, IPv6 addresses (i.e. not link-local
addresses), but there is no router on the local network providing IPv6
RA (Router Advertisement) packets, the client cannot reach the server
by normal means, since the client only has a link-local IPv6 address,
and has no usable route to reach the server's global IPv6 address.
(This is not a common situation, and usually only happens when the
router itself reboots and runs a Mandos client, since it cannot then
give RA packets to itself.)  The client code has a solution for
this, which consists of adding a temporary local route to reach the
address of the server during communication, and removing this
temporary route afterwards.

This solution with a temporary route works, but has a file descriptor
leak; it leaks one file descriptor for each addition and for each
removal of a route.  If one server requiring an added route is present
on the network, but no servers gives a password, making the client
retry after the default ten seconds, and we furthermore assume a
default 1024 open files limit, the client runs out of file descriptors
after about 90 minutes, after which time the client process will be
useless and fail to retrieve any passwords, necessitating manual
password entry via the keyboard.

Fix this by eliminating the file descriptor leak in the client.

* plugins.d/mandos-client.c (add_delete_local_route): Do
  close(devnull) also in parent process, also if fork() fails, and on
  any failure in child process.
Filename Latest Rev Last Changed Committer Comment Size
..
po 199 16 years ago Teddy Hogeborn * Makefile: Bug fix: fix syntax error. * debian/c Diff
source 237.2.216 14 years ago Teddy Hogeborn * debian/source/format: New; contains "3.0 (quilt) Diff
tests 237.7.664 5 years ago Teddy Hogeborn Debian package change: Add autopkgtest support * Diff
upstream 237.7.226 10 years ago Teddy Hogeborn Fix location and format of signing key file. * de Diff
changelog 397 4 years ago teddy at recompile Version 1.8.10-1 * Makefile (version): Change to 36.3 KB Diff Download File
compat 237.7.469 6 years ago Teddy Hogeborn Update Debian Debhelper compatibility version. * 3 bytes Diff Download File
control 237.7.759 4 years ago teddy at recompile Update Debian Policy version to 4.5.0; no other ch 3 KB Diff Download File
copyright 237.7.517 5 years ago Teddy Hogeborn Update copyright year to 2019 * DBUS-API: Update 1 KB Diff Download File
mandos-client.dirs 237.7.709 5 years ago Teddy Hogeborn Debian package: Client: Install the systemd sysuse 248 bytes Diff Download File
mandos-client.docs 237.7.142 12 years ago Teddy Hogeborn * debian/copyright (Copyright): Join the two lines 17 bytes Diff Download File
mandos-client.examples 237.7.142 12 years ago Teddy Hogeborn * debian/copyright (Copyright): Join the two lines 16 bytes Diff Download File
mandos-client.links 191 16 years ago Teddy Hogeborn * debian/mandos-client.docs: New. Add README and 93 bytes Diff Download File
mandos-client.lintian-overrides 237.7.700 5 years ago Teddy Hogeborn Override lintian warnings about upgrading from old 2.2 KB Diff Download File
mandos-client.postinst 237.7.675 5 years ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 5.9 KB Diff Download File
mandos-client.postrm 237.7.697 5 years ago Teddy Hogeborn Client: Debian package fix: Make uninstall when us 1.6 KB Diff Download File
mandos-client.README.Debian 237.7.675 5 years ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 4.9 KB Diff Download File
mandos-client.templates 237.7.698 5 years ago Teddy Hogeborn Create a debconf translation file * debian/mandos 813 bytes Diff Download File
mandos.dirs 237.7.707 5 years ago Teddy Hogeborn Use the systemd sysusers.d mechanism, if present 162 bytes Diff Download File
mandos.docs 237.2.186 14 years ago Teddy Hogeborn Documentation changes: * DBUS-API: New file docum 26 bytes Diff Download File
mandos.lintian-overrides 237.7.700 5 years ago Teddy Hogeborn Override lintian warnings about upgrading from old 703 bytes Diff Download File
mandos.postinst 237.7.706 5 years ago Teddy Hogeborn Debian package: Only reload dbus daemon if necessa 3.8 KB Diff Download File
mandos.prerm 237.7.318 9 years ago Teddy Hogeborn * debian/mandos.prerm: Don't run init script, use 759 bytes Diff Download File
mandos.README.Debian 237.11.2 13 years ago Teddy Hogeborn Change "fukt.bsnet.se" to "recompile.se" throughou 445 bytes Diff Download File
mandos.templates 237.7.698 5 years ago Teddy Hogeborn Create a debconf translation file * debian/mandos 1.2 KB Diff Download File
File rules 237.7.649 5 years ago Teddy Hogeborn Debian package: Fix backports package dependency a 2.1 KB Diff Download File
watch 237.7.524 5 years ago Teddy Hogeborn Fix Debian watch file * debian/watch: Make the ". 112 bytes Diff Download File