/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release
237.2.122 by Teddy Hogeborn
* plugins-runner.c (main): Bug fix: Close config file.
1
/*  -*- coding: utf-8; mode: c; mode: orgtbl -*- */
21 by Teddy Hogeborn
* Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and
2
/*
3
 * Mandos plugin runner - Run Mandos plugins
4
 *
237.7.471 by Teddy Hogeborn
Update copyright year to 2018
5
 * Copyright © 2008-2018 Teddy Hogeborn
6
 * Copyright © 2008-2018 Björn Påhlsson
21 by Teddy Hogeborn
* Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and
7
 * 
237.7.455 by Teddy Hogeborn
Alter copyright notices slightly. Actual license is unchanged!
8
 * This file is part of Mandos.
9
 * 
10
 * Mandos is free software: you can redistribute it and/or modify it
11
 * under the terms of the GNU General Public License as published by
12
 * the Free Software Foundation, either version 3 of the License, or
13
 * (at your option) any later version.
14
 * 
15
 * Mandos is distributed in the hope that it will be useful, but
21 by Teddy Hogeborn
* Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and
16
 * WITHOUT ANY WARRANTY; without even the implied warranty of
17
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
18
 * General Public License for more details.
19
 * 
20
 * You should have received a copy of the GNU General Public License
237.7.455 by Teddy Hogeborn
Alter copyright notices slightly. Actual license is unchanged!
21
 * along with Mandos.  If not, see <http://www.gnu.org/licenses/>.
21 by Teddy Hogeborn
* Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and
22
 * 
237.11.2 by Teddy Hogeborn
Change "fukt.bsnet.se" to "recompile.se" throughout.
23
 * Contact the authors at <mandos@recompile.se>.
21 by Teddy Hogeborn
* Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and
24
 */
25
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
26
#define _GNU_SOURCE		/* TEMP_FAILURE_RETRY(), getline(),
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
27
				   O_CLOEXEC, pipe2() */
24.1.26 by Björn Påhlsson
tally count of used symbols
28
#include <stddef.h>		/* size_t, NULL */
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
29
#include <stdlib.h>		/* malloc(), exit(), EXIT_SUCCESS,
30
				   realloc() */
24.1.26 by Björn Påhlsson
tally count of used symbols
31
#include <stdbool.h>		/* bool, true, false */
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
32
#include <stdio.h>		/* fileno(), fprintf(),
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
33
				   stderr, STDOUT_FILENO, fclose() */
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
34
#include <sys/types.h>	        /* fstat(), struct stat, waitpid(),
35
				   WIFEXITED(), WEXITSTATUS(), wait(),
36
				   pid_t, uid_t, gid_t, getuid(),
37
				   getgid() */
24.1.26 by Björn Påhlsson
tally count of used symbols
38
#include <sys/select.h>		/* fd_set, select(), FD_ZERO(),
39
				   FD_SET(), FD_ISSET(), FD_CLR */
40
#include <sys/wait.h>		/* wait(), waitpid(), WIFEXITED(),
237.7.382 by Teddy Hogeborn
Client: Remove dead code in plugin-runner
41
				   WEXITSTATUS(), WTERMSIG() */
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
42
#include <sys/stat.h>		/* struct stat, fstat(), S_ISREG() */
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
43
#include <iso646.h>		/* and, or, not */
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
44
#include <dirent.h>		/* struct dirent, scandirat() */
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
45
#include <unistd.h>		/* fcntl(), F_GETFD, F_SETFD,
46
				   FD_CLOEXEC, write(), STDOUT_FILENO,
47
				   struct stat, fstat(), close(),
48
				   setgid(), setuid(), S_ISREG(),
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
49
				   faccessat() pipe2(), fork(),
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
50
				   _exit(), dup2(), fexecve(), read()
51
				*/
24.1.26 by Björn Påhlsson
tally count of used symbols
52
#include <fcntl.h>		/* fcntl(), F_GETFD, F_SETFD,
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
53
				   FD_CLOEXEC, openat(), scandirat(),
54
				   pipe2() */
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
55
#include <string.h>		/* strsep, strlen(), strsignal(),
56
				   strcmp(), strncmp() */
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
57
#include <errno.h>		/* errno */
24.1.26 by Björn Påhlsson
tally count of used symbols
58
#include <argp.h>		/* struct argp_option, struct
59
				   argp_state, struct argp,
60
				   argp_parse(), ARGP_ERR_UNKNOWN,
102 by Teddy Hogeborn
* plugin-runner.c (process): Set "completed" and "status" as volatile.
61
				   ARGP_KEY_END, ARGP_KEY_ARG,
62
				   error_t */
24.1.26 by Björn Påhlsson
tally count of used symbols
63
#include <signal.h> 		/* struct sigaction, sigemptyset(),
64
				   sigaddset(), sigaction(),
65
				   sigprocmask(), SIG_BLOCK, SIGCHLD,
237.2.71 by Teddy Hogeborn
* plugin-runner.c: Comment change.
66
				   SIG_UNBLOCK, kill(), sig_atomic_t
67
				*/
24.1.26 by Björn Påhlsson
tally count of used symbols
68
#include <errno.h>		/* errno, EBADF */
237.2.74 by Teddy Hogeborn
Overflows are not detected by sscanf(), so stop using it:
69
#include <inttypes.h>		/* intmax_t, PRIdMAX, strtoimax() */
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
70
#include <sysexits.h>		/* EX_OSERR, EX_USAGE, EX_IOERR,
71
				   EX_CONFIG, EX_UNAVAILABLE, EX_OK */
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
72
#include <errno.h> 		/* errno */
73
#include <error.h>		/* error() */
237.7.224 by Teddy Hogeborn
Use fnmatch()in plugin-runner.
74
#include <fnmatch.h>		/* fnmatch() */
13 by Björn Påhlsson
Added following support:
75
37 by Teddy Hogeborn
Non-tested commit for merge purposes.
76
#define BUFFER_SIZE 256
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
77
78
#define PDIR "/lib/mandos/plugins.d"
237.25.1 by Teddy Hogeborn
Add a plugin helper directory, available to all plugins.
79
#define PHDIR "/lib/mandos/plugin-helpers"
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
80
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
37 by Teddy Hogeborn
Non-tested commit for merge purposes.
81
217 by Teddy Hogeborn
* .bzrignore: Added "man" directory (created by "make install-html").
82
const char *argp_program_version = "plugin-runner " VERSION;
237.11.2 by Teddy Hogeborn
Change "fukt.bsnet.se" to "recompile.se" throughout.
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
24.1.35 by Björn Påhlsson
version 1.0
84
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
85
typedef struct plugin{
86
  char *name;			/* can be NULL or any plugin name */
87
  char **argv;
88
  int argc;
89
  char **environ;
90
  int envc;
91
  bool disabled;
237.2.75 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
92
  
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
93
  /* Variables used for running processes*/
13 by Björn Påhlsson
Added following support:
94
  pid_t pid;
95
  int fd;
96
  char *buffer;
21 by Teddy Hogeborn
* Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and
97
  size_t buffer_size;
98
  size_t buffer_length;
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
99
  bool eof;
237.2.59 by Teddy Hogeborn
* plugin-runner.c (struct plugin.completed): Changed type to "volatile
100
  volatile sig_atomic_t completed;
237.2.60 by Teddy Hogeborn
* plugin-runner.c (struct plugin.status): Changed type to "int".
101
  int status;
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
102
  struct plugin *next;
103
} plugin;
104
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
105
static plugin *plugin_list = NULL;
106
24.1.90 by Björn Påhlsson
fixed two bugs:
107
/* Gets an existing plugin based on name,
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
108
   or if none is found, creates a new one */
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
109
__attribute__((warn_unused_result))
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
110
static plugin *getplugin(char *name){
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
111
  /* Check for existing plugin with that name */
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
112
  for(plugin *p = plugin_list; p != NULL; p = p->next){
113
    if((p->name == name)
114
       or (p->name and name and (strcmp(p->name, name) == 0))){
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
115
      return p;
116
    }
117
  }
118
  /* Create a new plugin */
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
119
  plugin *new_plugin = NULL;
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
120
  do {
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
121
    new_plugin = malloc(sizeof(plugin));
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
122
  } while(new_plugin == NULL and errno == EINTR);
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
123
  if(new_plugin == NULL){
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
124
    return NULL;
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
125
  }
24.1.62 by Björn Påhlsson
merge + small bugfix
126
  char *copy_name = NULL;
127
  if(name != NULL){
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
128
    do {
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
129
      copy_name = strdup(name);
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
130
    } while(copy_name == NULL and errno == EINTR);
98 by Teddy Hogeborn
* plugin-runner.c (getplugin): Only copy "name" if not NULL. Free
131
    if(copy_name == NULL){
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
132
      int e = errno;
237.2.35 by Teddy Hogeborn
Fix problem found using cppcheck, thanks to George Danchev
133
      free(new_plugin);
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
134
      errno = e;
98 by Teddy Hogeborn
* plugin-runner.c (getplugin): Only copy "name" if not NULL. Free
135
      return NULL;
136
    }
24.1.54 by Björn Påhlsson
plugin-runner
137
  }
24.1.90 by Björn Påhlsson
fixed two bugs:
138
  
237.2.56 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
139
  *new_plugin = (plugin){ .name = copy_name,
140
			  .argc = 1,
141
			  .disabled = false,
142
			  .next = plugin_list };
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
143
  
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
144
  do {
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
145
    new_plugin->argv = malloc(sizeof(char *) * 2);
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
146
  } while(new_plugin->argv == NULL and errno == EINTR);
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
147
  if(new_plugin->argv == NULL){
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
148
    int e = errno;
24.1.62 by Björn Påhlsson
merge + small bugfix
149
    free(copy_name);
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
150
    free(new_plugin);
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
151
    errno = e;
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
152
    return NULL;
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
153
  }
24.1.54 by Björn Påhlsson
plugin-runner
154
  new_plugin->argv[0] = copy_name;
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
155
  new_plugin->argv[1] = NULL;
135 by Teddy Hogeborn
* plugin-runner.c (add_environment): Never insert existing environment
156
  
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
157
  do {
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
158
    new_plugin->environ = malloc(sizeof(char *));
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
159
  } while(new_plugin->environ == NULL and errno == EINTR);
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
160
  if(new_plugin->environ == NULL){
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
161
    int e = errno;
24.1.62 by Björn Påhlsson
merge + small bugfix
162
    free(copy_name);
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
163
    free(new_plugin->argv);
164
    free(new_plugin);
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
165
    errno = e;
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
166
    return NULL;
167
  }
168
  new_plugin->environ[0] = NULL;
135 by Teddy Hogeborn
* plugin-runner.c (add_environment): Never insert existing environment
169
  
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
170
  /* Append the new plugin to the list */
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
171
  plugin_list = new_plugin;
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
172
  return new_plugin;
173
}
174
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
175
/* Helper function for add_argument and add_environment */
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
176
__attribute__((nonnull, warn_unused_result))
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
177
static bool add_to_char_array(const char *new, char ***array,
178
			      int *len){
179
  /* Resize the pointed-to array to hold one more pointer */
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
180
  char **new_array = NULL;
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
181
  do {
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
182
    new_array = realloc(*array, sizeof(char *)
183
			* (size_t) ((*len) + 2));
184
  } while(new_array == NULL and errno == EINTR);
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
185
  /* Malloc check */
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
186
  if(new_array == NULL){
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
187
    return false;
188
  }
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
189
  *array = new_array;
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
190
  /* Make a copy of the new string */
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
191
  char *copy;
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
192
  do {
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
193
    copy = strdup(new);
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
194
  } while(copy == NULL and errno == EINTR);
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
195
  if(copy == NULL){
196
    return false;
197
  }
198
  /* Insert the copy */
199
  (*array)[*len] = copy;
200
  (*len)++;
201
  /* Add a new terminating NULL pointer to the last element */
202
  (*array)[*len] = NULL;
203
  return true;
204
}
205
206
/* Add to a plugin's argument vector */
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
207
__attribute__((nonnull(2), warn_unused_result))
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
208
static bool add_argument(plugin *p, const char *arg){
209
  if(p == NULL){
210
    return false;
211
  }
212
  return add_to_char_array(arg, &(p->argv), &(p->argc));
213
}
214
215
/* Add to a plugin's environment */
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
216
__attribute__((nonnull(2), warn_unused_result))
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
217
static bool add_environment(plugin *p, const char *def, bool replace){
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
218
  if(p == NULL){
219
    return false;
220
  }
135 by Teddy Hogeborn
* plugin-runner.c (add_environment): Never insert existing environment
221
  /* namelen = length of name of environment variable */
222
  size_t namelen = (size_t)(strchrnul(def, '=') - def);
223
  /* Search for this environment variable */
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
224
  for(char **envdef = p->environ; *envdef != NULL; envdef++){
225
    if(strncmp(*envdef, def, namelen + 1) == 0){
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
226
      /* It already exists */
227
      if(replace){
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
228
	char *new_envdef;
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
229
	do {
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
230
	  new_envdef = realloc(*envdef, strlen(def) + 1);
231
	} while(new_envdef == NULL and errno == EINTR);
232
	if(new_envdef == NULL){
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
233
	  return false;
234
	}
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
235
	*envdef = new_envdef;
236
	strcpy(*envdef, def);
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
237
      }
135 by Teddy Hogeborn
* plugin-runner.c (add_environment): Never insert existing environment
238
      return true;
239
    }
240
  }
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
241
  return add_to_char_array(def, &(p->environ), &(p->envc));
242
}
243
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
244
#ifndef O_CLOEXEC
32 by Teddy Hogeborn
* plugins.d/plugbasedclient.c (set_cloexec_flag): New function.
245
/*
246
 * Based on the example in the GNU LibC manual chapter 13.13 "File
247
 * Descriptor Flags".
237.2.122 by Teddy Hogeborn
* plugins-runner.c (main): Bug fix: Close config file.
248
 | [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
32 by Teddy Hogeborn
* plugins.d/plugbasedclient.c (set_cloexec_flag): New function.
249
 */
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
250
__attribute__((warn_unused_result))
187 by Teddy Hogeborn
* debian/mandos-client.README.Debian: Document "eth0" default and how
251
static int set_cloexec_flag(int fd){
237.2.130 by Teddy Hogeborn
* init.d-mandos: Bug fix: Correct the LSB header.
252
  int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
32 by Teddy Hogeborn
* plugins.d/plugbasedclient.c (set_cloexec_flag): New function.
253
  /* If reading the flags failed, return error indication now. */
254
  if(ret < 0){
255
    return ret;
256
  }
257
  /* Store modified flag word in the descriptor. */
237.2.130 by Teddy Hogeborn
* init.d-mandos: Bug fix: Correct the LSB header.
258
  return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
259
				       ret | FD_CLOEXEC));
32 by Teddy Hogeborn
* plugins.d/plugbasedclient.c (set_cloexec_flag): New function.
260
}
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
261
#endif	/* not O_CLOEXEC */
32 by Teddy Hogeborn
* plugins.d/plugbasedclient.c (set_cloexec_flag): New function.
262
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
263
102 by Teddy Hogeborn
* plugin-runner.c (process): Set "completed" and "status" as volatile.
264
/* Mark processes as completed when they exit, and save their exit
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
265
   status. */
187 by Teddy Hogeborn
* debian/mandos-client.README.Debian: Document "eth0" default and how
266
static void handle_sigchld(__attribute__((unused)) int sig){
237.2.61 by Teddy Hogeborn
* plugin-runner.c (handle_sigchld): Bug fix: Save and restore "errno".
267
  int old_errno = errno;
24.1.65 by Björn Påhlsson
* plugin-runner.c (handle_sigchld): Loop until all exited children
268
  while(true){
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
269
    plugin *proc = plugin_list;
24.1.65 by Björn Påhlsson
* plugin-runner.c (handle_sigchld): Loop until all exited children
270
    int status;
271
    pid_t pid = waitpid(-1, &status, WNOHANG);
272
    if(pid == 0){
102 by Teddy Hogeborn
* plugin-runner.c (process): Set "completed" and "status" as volatile.
273
      /* Only still running child processes */
24.1.65 by Björn Påhlsson
* plugin-runner.c (handle_sigchld): Loop until all exited children
274
      break;
275
    }
276
    if(pid == -1){
237.2.58 by Teddy Hogeborn
* plugin-runner.c (handle_sigchld): Clarify logic.
277
      if(errno == ECHILD){
278
	/* No child processes */
279
	break;
24.1.65 by Björn Påhlsson
* plugin-runner.c (handle_sigchld): Loop until all exited children
280
      }
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
281
      error(0, errno, "waitpid");
24.1.65 by Björn Påhlsson
* plugin-runner.c (handle_sigchld): Loop until all exited children
282
    }
24.1.90 by Björn Påhlsson
fixed two bugs:
283
    
102 by Teddy Hogeborn
* plugin-runner.c (process): Set "completed" and "status" as volatile.
284
    /* A child exited, find it in process_list */
24.1.65 by Björn Påhlsson
* plugin-runner.c (handle_sigchld): Loop until all exited children
285
    while(proc != NULL and proc->pid != pid){
286
      proc = proc->next;
287
    }
288
    if(proc == NULL){
289
      /* Process not found in process list */
290
      continue;
291
    }
292
    proc->status = status;
237.2.59 by Teddy Hogeborn
* plugin-runner.c (struct plugin.completed): Changed type to "volatile
293
    proc->completed = 1;
24.1.65 by Björn Påhlsson
* plugin-runner.c (handle_sigchld): Loop until all exited children
294
  }
237.2.61 by Teddy Hogeborn
* plugin-runner.c (handle_sigchld): Bug fix: Save and restore "errno".
295
  errno = old_errno;
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
296
}
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
297
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
298
/* Prints out a password to stdout */
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
299
__attribute__((nonnull, warn_unused_result))
187 by Teddy Hogeborn
* debian/mandos-client.README.Debian: Document "eth0" default and how
300
static bool print_out_password(const char *buffer, size_t length){
64 by Teddy Hogeborn
* mandos-client.c (print_out_password): Strip trailing '\n'.
301
  ssize_t ret;
302
  for(size_t written = 0; written < length; written += (size_t)ret){
24.1.42 by Björn Påhlsson
Added fallback to mandos-client
303
    ret = TEMP_FAILURE_RETRY(write(STDOUT_FILENO, buffer + written,
304
				   length - written));
305
    if(ret < 0){
306
      return false;
307
    }
308
  }
309
  return true;
310
}
311
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
312
/* Removes and free a plugin from the plugin list */
237.7.82 by teddy at bsnet
* plugin-runner.c (add_to_char_array): Added "nonnull" attribute.
313
__attribute__((nonnull))
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
314
static void free_plugin(plugin *plugin_node){
315
  
237.7.645 by Teddy Hogeborn
plugin-runner: Fix minor memory leak
316
  for(char **arg = (plugin_node->argv)+1; *arg != NULL; arg++){
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
317
    free(*arg);
318
  }
237.7.645 by Teddy Hogeborn
plugin-runner: Fix minor memory leak
319
  free(plugin_node->name);
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
320
  free(plugin_node->argv);
321
  for(char **env = plugin_node->environ; *env != NULL; env++){
322
    free(*env);
323
  }
324
  free(plugin_node->environ);
325
  free(plugin_node->buffer);
237.2.75 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
326
  
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
327
  /* Removes the plugin from the singly-linked list */
328
  if(plugin_node == plugin_list){
329
    /* First one - simple */
330
    plugin_list = plugin_list->next;
331
  } else {
332
    /* Second one or later */
333
    for(plugin *p = plugin_list; p != NULL; p = p->next){
334
      if(p->next == plugin_node){
335
	p->next = plugin_node->next;
336
	break;
337
      }
338
    }
339
  }
340
  
341
  free(plugin_node);
342
}
343
344
static void free_plugin_list(void){
345
  while(plugin_list != NULL){
346
    free_plugin(plugin_list);
98 by Teddy Hogeborn
* plugin-runner.c (getplugin): Only copy "name" if not NULL. Free
347
  }
24.1.54 by Björn Påhlsson
plugin-runner
348
}
349
13 by Björn Påhlsson
Added following support:
350
int main(int argc, char *argv[]){
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
351
  char *plugindir = NULL;
237.25.1 by Teddy Hogeborn
Add a plugin helper directory, available to all plugins.
352
  char *pluginhelperdir = NULL;
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
353
  char *argfile = NULL;
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
354
  FILE *conffp;
237.7.253 by Teddy Hogeborn
plugin-runner: Release memory and close FD's correctly in all cases.
355
  struct dirent **direntries = NULL;
13 by Björn Påhlsson
Added following support:
356
  struct stat st;
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
357
  fd_set rfds_all;
237.2.74 by Teddy Hogeborn
Overflows are not detected by sscanf(), so stop using it:
358
  int ret, maxfd = 0;
237.2.17 by Teddy Hogeborn
Eliminate warning on 64-bit systems, thanks to Frans Pop
359
  ssize_t sret;
24.1.6 by Björn Påhlsson
plugbasedclient
360
  uid_t uid = 65534;
361
  gid_t gid = 65534;
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
362
  bool debug = false;
363
  int exitstatus = EXIT_SUCCESS;
24.1.7 by Björn Påhlsson
merge
364
  struct sigaction old_sigchld_action;
365
  struct sigaction sigchld_action = { .sa_handler = handle_sigchld,
366
				      .sa_flags = SA_NOCLDSTOP };
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
367
  char **custom_argv = NULL;
368
  int custom_argc = 0;
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
369
  int dir_fd = -1;
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
370
  
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
371
  /* Establish a signal handler */
372
  sigemptyset(&sigchld_action.sa_mask);
373
  ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
24.1.54 by Björn Påhlsson
plugin-runner
374
  if(ret == -1){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
375
    error(0, errno, "sigaddset");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
376
    exitstatus = EX_OSERR;
24.1.54 by Björn Påhlsson
plugin-runner
377
    goto fallback;
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
378
  }
379
  ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
24.1.54 by Björn Påhlsson
plugin-runner
380
  if(ret == -1){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
381
    error(0, errno, "sigaction");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
382
    exitstatus = EX_OSERR;
24.1.54 by Björn Påhlsson
plugin-runner
383
    goto fallback;
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
384
  }
385
  
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
386
  /* The options we understand. */
387
  struct argp_option options[] = {
388
    { .name = "global-options", .key = 'g',
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
389
      .arg = "OPTION[,OPTION[,...]]",
390
      .doc = "Options passed to all plugins" },
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
391
    { .name = "global-env", .key = 'G',
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
392
      .arg = "VAR=value",
393
      .doc = "Environment variable passed to all plugins" },
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
394
    { .name = "options-for", .key = 'o',
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
395
      .arg = "PLUGIN:OPTION[,OPTION[,...]]",
396
      .doc = "Options passed only to specified plugin" },
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
397
    { .name = "env-for", .key = 'E',
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
398
      .arg = "PLUGIN:ENV=value",
399
      .doc = "Environment variable passed to specified plugin" },
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
400
    { .name = "disable", .key = 'd',
401
      .arg = "PLUGIN",
402
      .doc = "Disable a specific plugin", .group = 1 },
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
403
    { .name = "enable", .key = 'e',
404
      .arg = "PLUGIN",
405
      .doc = "Enable a specific plugin", .group = 1 },
24.1.5 by Björn Påhlsson
plugbasedclient:
406
    { .name = "plugin-dir", .key = 128,
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
407
      .arg = "DIRECTORY",
408
      .doc = "Specify a different plugin directory", .group = 2 },
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
409
    { .name = "config-file", .key = 129,
410
      .arg = "FILE",
411
      .doc = "Specify a different configuration file", .group = 2 },
412
    { .name = "userid", .key = 130,
413
      .arg = "ID", .flags = 0,
414
      .doc = "User ID the plugins will run as", .group = 3 },
415
    { .name = "groupid", .key = 131,
416
      .arg = "ID", .flags = 0,
417
      .doc = "Group ID the plugins will run as", .group = 3 },
418
    { .name = "debug", .key = 132,
419
      .doc = "Debug mode", .group = 4 },
237.25.1 by Teddy Hogeborn
Add a plugin helper directory, available to all plugins.
420
    { .name = "plugin-helper-dir", .key = 133,
421
      .arg = "DIRECTORY",
422
      .doc = "Specify a different plugin helper directory",
423
      .group = 2 },
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
424
    /*
425
     * These reproduce what we would get without ARGP_NO_HELP
426
     */
427
    { .name = "help", .key = '?',
428
      .doc = "Give this help list", .group = -1 },
429
    { .name = "usage", .key = -3,
430
      .doc = "Give a short usage message", .group = -1 },
431
    { .name = "version", .key = 'V',
432
      .doc = "Print program version", .group = -1 },
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
433
    { .name = NULL }
434
  };
435
  
237.7.82 by teddy at bsnet
* plugin-runner.c (add_to_char_array): Added "nonnull" attribute.
436
  __attribute__((nonnull(3)))
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
437
  error_t parse_opt(int key, char *arg, struct argp_state *state){
438
    errno = 0;
237.2.56 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
439
    switch(key){
237.2.123 by Teddy Hogeborn
* plugin-runner.c (main): Move variables "tmpmax" and "tmp" into
440
      char *tmp;
237.7.84 by Björn Påhlsson
renamed some foomax values to what they actually represent
441
      intmax_t tmp_id;
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
442
    case 'g': 			/* --global-options */
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
443
      {
24.1.134 by Björn Påhlsson
plugin-runner: Added support for empty string arguments
444
	char *plugin_option;
445
	while((plugin_option = strsep(&arg, ",")) != NULL){
446
	  if(not add_argument(getplugin(NULL), plugin_option)){
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
447
	    break;
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
448
	  }
449
	}
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
450
	errno = 0;
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
451
      }
452
      break;
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
453
    case 'G':			/* --global-env */
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
454
      if(add_environment(getplugin(NULL), arg, true)){
455
	errno = 0;
456
      }
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
457
      break;
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
458
    case 'o':			/* --options-for */
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
459
      {
460
	char *option_list = strchr(arg, ':');
461
	if(option_list == NULL){
462
	  argp_error(state, "No colon in \"%s\"", arg);
463
	  errno = EINVAL;
464
	  break;
465
	}
466
	*option_list = '\0';
467
	option_list++;
468
	if(arg[0] == '\0'){
469
	  argp_error(state, "Empty plugin name");
470
	  errno = EINVAL;
471
	  break;
472
	}
473
	char *option;
474
	while((option = strsep(&option_list, ",")) != NULL){
475
	  if(not add_argument(getplugin(arg), option)){
476
	    break;
24.1.50 by Björn Påhlsson
changed from using strtok to strsep
477
	  }
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
478
	}
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
479
	errno = 0;
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
480
      }
481
      break;
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
482
    case 'E':			/* --env-for */
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
483
      {
484
	char *envdef = strchr(arg, ':');
485
	if(envdef == NULL){
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
486
	  argp_error(state, "No colon in \"%s\"", arg);
487
	  errno = EINVAL;
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
488
	  break;
489
	}
24.1.92 by Björn Påhlsson
Several memory leaks detected by valgrind fixed
490
	*envdef = '\0';
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
491
	envdef++;
492
	if(arg[0] == '\0'){
493
	  argp_error(state, "Empty plugin name");
494
	  errno = EINVAL;
495
	  break;
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
496
	}
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
497
	if(add_environment(getplugin(arg), envdef, true)){
498
	  errno = 0;
499
	}
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
500
      }
501
      break;
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
502
    case 'd':			/* --disable */
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
503
      {
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
504
	plugin *p = getplugin(arg);
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
505
	if(p != NULL){
506
	  p->disabled = true;
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
507
	  errno = 0;
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
508
	}
24.1.5 by Björn Påhlsson
plugbasedclient:
509
      }
510
      break;
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
511
    case 'e':			/* --enable */
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
512
      {
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
513
	plugin *p = getplugin(arg);
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
514
	if(p != NULL){
515
	  p->disabled = false;
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
516
	  errno = 0;
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
517
	}
518
      }
519
      break;
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
520
    case 128:			/* --plugin-dir */
24.1.92 by Björn Påhlsson
Several memory leaks detected by valgrind fixed
521
      free(plugindir);
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
522
      plugindir = strdup(arg);
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
523
      if(plugindir != NULL){
524
	errno = 0;
525
      }
24.1.5 by Björn Påhlsson
plugbasedclient:
526
      break;
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
527
    case 129:			/* --config-file */
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
528
      /* This is already done by parse_opt_config_file() */
529
      break;
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
530
    case 130:			/* --userid */
237.7.84 by Björn Påhlsson
renamed some foomax values to what they actually represent
531
      tmp_id = strtoimax(arg, &tmp, 10);
237.2.74 by Teddy Hogeborn
Overflows are not detected by sscanf(), so stop using it:
532
      if(errno != 0 or tmp == arg or *tmp != '\0'
237.7.84 by Björn Påhlsson
renamed some foomax values to what they actually represent
533
	 or tmp_id != (uid_t)tmp_id){
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
534
	argp_error(state, "Bad user ID number: \"%s\", using %"
535
		   PRIdMAX, arg, (intmax_t)uid);
536
	break;
237.2.27 by Teddy Hogeborn
* plugin-runner.c (main): Use "sscanf" instead of "strtol"; using the
537
      }
237.7.84 by Björn Påhlsson
renamed some foomax values to what they actually represent
538
      uid = (uid_t)tmp_id;
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
539
      errno = 0;
24.1.6 by Björn Påhlsson
plugbasedclient
540
      break;
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
541
    case 131:			/* --groupid */
237.7.84 by Björn Påhlsson
renamed some foomax values to what they actually represent
542
      tmp_id = strtoimax(arg, &tmp, 10);
237.2.74 by Teddy Hogeborn
Overflows are not detected by sscanf(), so stop using it:
543
      if(errno != 0 or tmp == arg or *tmp != '\0'
237.7.84 by Björn Påhlsson
renamed some foomax values to what they actually represent
544
	 or tmp_id != (gid_t)tmp_id){
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
545
	argp_error(state, "Bad group ID number: \"%s\", using %"
546
		   PRIdMAX, arg, (intmax_t)gid);
547
	break;
237.2.27 by Teddy Hogeborn
* plugin-runner.c (main): Use "sscanf" instead of "strtol"; using the
548
      }
237.7.84 by Björn Påhlsson
renamed some foomax values to what they actually represent
549
      gid = (gid_t)tmp_id;
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
550
      errno = 0;
24.1.6 by Björn Påhlsson
plugbasedclient
551
      break;
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
552
    case 132:			/* --debug */
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
553
      debug = true;
554
      break;
237.25.1 by Teddy Hogeborn
Add a plugin helper directory, available to all plugins.
555
    case 133:			/* --plugin-helper-dir */
556
      free(pluginhelperdir);
557
      pluginhelperdir = strdup(arg);
558
      if(pluginhelperdir != NULL){
559
	errno = 0;
560
      }
561
      break;
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
562
      /*
563
       * These reproduce what we would get without ARGP_NO_HELP
564
       */
565
    case '?':			/* --help */
566
      state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
567
      argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
237.7.523 by Teddy Hogeborn
Fix warnings from -Wimplicit-fallthrough
568
      __builtin_unreachable();
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
569
    case -3:			/* --usage */
570
      state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
571
      argp_state_help(state, state->out_stream,
572
		      ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
237.7.523 by Teddy Hogeborn
Fix warnings from -Wimplicit-fallthrough
573
      __builtin_unreachable();
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
574
    case 'V':			/* --version */
575
      fprintf(state->out_stream, "%s\n", argp_program_version);
576
      exit(EXIT_SUCCESS);
577
      break;
237.2.27 by Teddy Hogeborn
* plugin-runner.c (main): Use "sscanf" instead of "strtol"; using the
578
/*
579
 * When adding more options before this line, remember to also add a
580
 * "case" to the "parse_opt_config_file" function below.
581
 */
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
582
    case ARGP_KEY_ARG:
178 by Teddy Hogeborn
* initramfs-tools-script: Fix permissions of "/tmp" in initrd.
583
      /* Cryptsetup always passes an argument, which is an empty
584
	 string if "none" was specified in /etc/crypttab.  So if
585
	 argument was empty, we ignore it silently. */
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
586
      if(arg[0] == '\0'){
587
	break;
178 by Teddy Hogeborn
* initramfs-tools-script: Fix permissions of "/tmp" in initrd.
588
      }
237.7.657 by Teddy Hogeborn
plugin-runner.c: Use a statement attribute only for GCC 7 or later.
589
#if __GNUC__ >= 7
237.7.656 by Teddy Hogeborn
plugin-runner.c: Switch to attribute to mark switch fallthrough
590
      __attribute__((fallthrough));
237.7.657 by Teddy Hogeborn
plugin-runner.c: Use a statement attribute only for GCC 7 or later.
591
#else
592
	  /* FALLTHROUGH */
593
#endif
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
594
    default:
595
      return ARGP_ERR_UNKNOWN;
596
    }
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
597
    return errno;		/* Set to 0 at start */
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
598
  }
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
599
  
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
600
  /* This option parser is the same as parse_opt() above, except it
601
     ignores everything but the --config-file option. */
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
602
  error_t parse_opt_config_file(int key, char *arg,
603
				__attribute__((unused))
237.2.56 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
604
				struct argp_state *state){
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
605
    errno = 0;
237.2.56 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
606
    switch(key){
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
607
    case 'g': 			/* --global-options */
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
608
    case 'G':			/* --global-env */
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
609
    case 'o':			/* --options-for */
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
610
    case 'E':			/* --env-for */
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
611
    case 'd':			/* --disable */
138 by Teddy Hogeborn
* plugin-runner.c: Changed short option for "--global-env" to "-G",
612
    case 'e':			/* --enable */
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
613
    case 128:			/* --plugin-dir */
614
      break;
615
    case 129:			/* --config-file */
24.1.92 by Björn Påhlsson
Several memory leaks detected by valgrind fixed
616
      free(argfile);
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
617
      argfile = strdup(arg);
237.7.220 by Teddy Hogeborn
Update GCC warning flags and function attributes to GCC 4.7.
618
      if(argfile != NULL){
619
	errno = 0;
620
      }
237.2.118 by Teddy Hogeborn
* mandos: White-space fixes only.
621
      break;
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
622
    case 130:			/* --userid */
623
    case 131:			/* --groupid */
624
    case 132:			/* --debug */
237.25.1 by Teddy Hogeborn
Add a plugin helper directory, available to all plugins.
625
    case 133:			/* --plugin-helper-dir */
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
626
    case '?':			/* --help */
627
    case -3:			/* --usage */
628
    case 'V':			/* --version */
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
629
    case ARGP_KEY_ARG:
630
      break;
631
    default:
632
      return ARGP_ERR_UNKNOWN;
633
    }
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
634
    return errno;
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
635
  }
636
  
637
  struct argp argp = { .options = options,
638
		       .parser = parse_opt_config_file,
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
639
		       .args_doc = "",
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
640
		       .doc = "Mandos plugin runner -- Run plugins" };
641
  
237.2.28 by Teddy Hogeborn
* plugin-runner.c (main): Bug fix; do not accept a "d" character after
642
  /* Parse using parse_opt_config_file() in order to get the custom
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
643
     config file location, if any. */
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
644
  ret = argp_parse(&argp, argc, argv,
645
		   ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
646
		   NULL, NULL);
647
  switch(ret){
648
  case 0:
649
    break;
650
  case ENOMEM:
651
  default:
652
    errno = ret;
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
653
    error(0, errno, "argp_parse");
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
654
    exitstatus = EX_OSERR;
655
    goto fallback;
656
  case EINVAL:
657
    exitstatus = EX_USAGE;
137 by Teddy Hogeborn
* plugin-runner.c (main/parse_opt): Removed code for "--config-file".
658
    goto fallback;
659
  }
660
  
661
  /* Reset to the normal argument parser */
662
  argp.parser = parse_opt;
663
  
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
664
  /* Open the configfile if available */
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
665
  if(argfile == NULL){
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
666
    conffp = fopen(AFILE, "r");
667
  } else {
668
    conffp = fopen(argfile, "r");
237.2.118 by Teddy Hogeborn
* mandos: White-space fixes only.
669
  }
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
670
  if(conffp != NULL){
671
    char *org_line = NULL;
24.1.54 by Björn Påhlsson
plugin-runner
672
    char *p, *arg, *new_arg, *line;
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
673
    size_t size = 0;
674
    const char whitespace_delims[] = " \r\t\f\v\n";
675
    const char comment_delim[] = "#";
237.2.75 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
676
    
24.1.67 by Björn Påhlsson
transformed a function to a part of main
677
    custom_argc = 1;
678
    custom_argv = malloc(sizeof(char*) * 2);
679
    if(custom_argv == NULL){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
680
      error(0, errno, "malloc");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
681
      exitstatus = EX_OSERR;
24.1.67 by Björn Påhlsson
transformed a function to a part of main
682
      goto fallback;
683
    }
684
    custom_argv[0] = argv[0];
685
    custom_argv[1] = NULL;
237.2.75 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
686
    
133 by Teddy Hogeborn
* plugin-runner.c: Break a couple of long lines.
687
    /* for each line in the config file, strip whitespace and ignore
688
       commented text */
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
689
    while(true){
690
      sret = getline(&org_line, &size, conffp);
691
      if(sret == -1){
692
	break;
693
      }
237.2.75 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
694
      
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
695
      line = org_line;
696
      arg = strsep(&line, comment_delim);
697
      while((p = strsep(&arg, whitespace_delims)) != NULL){
698
	if(p[0] == '\0'){
699
	  continue;
700
	}
701
	new_arg = strdup(p);
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
702
	if(new_arg == NULL){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
703
	  error(0, errno, "strdup");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
704
	  exitstatus = EX_OSERR;
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
705
	  free(org_line);
706
	  goto fallback;
707
	}
708
	
24.1.67 by Björn Påhlsson
transformed a function to a part of main
709
	custom_argc += 1;
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
710
	{
711
	  char **new_argv = realloc(custom_argv, sizeof(char *)
237.7.345 by Teddy Hogeborn
plugin-runner.c: Use size_t to realloc() for custom plugin args.
712
				    * ((size_t)custom_argc + 1));
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
713
	  if(new_argv == NULL){
714
	    error(0, errno, "realloc");
715
	    exitstatus = EX_OSERR;
716
	    free(new_arg);
717
	    free(org_line);
718
	    goto fallback;
719
	  } else {
720
	    custom_argv = new_argv;
721
	  }
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
722
	}
24.1.67 by Björn Påhlsson
transformed a function to a part of main
723
	custom_argv[custom_argc-1] = new_arg;
237.2.118 by Teddy Hogeborn
* mandos: White-space fixes only.
724
	custom_argv[custom_argc] = NULL;
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
725
      }
726
    }
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
727
    do {
237.2.122 by Teddy Hogeborn
* plugins-runner.c (main): Bug fix: Close config file.
728
      ret = fclose(conffp);
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
729
    } while(ret == EOF and errno == EINTR);
237.2.122 by Teddy Hogeborn
* plugins-runner.c (main): Bug fix: Close config file.
730
    if(ret == EOF){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
731
      error(0, errno, "fclose");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
732
      exitstatus = EX_IOERR;
237.2.122 by Teddy Hogeborn
* plugins-runner.c (main): Bug fix: Close config file.
733
      goto fallback;
734
    }
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
735
    free(org_line);
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
736
  } else {
24.1.52 by Björn Påhlsson
merge + minor adjustments
737
    /* Check for harmful errors and go to fallback. Other errors might
738
       not affect opening plugins */
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
739
    if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
740
      error(0, errno, "fopen");
237.2.165 by Teddy Hogeborn
* mandos (Client.disable): Rename keyword argument "log" to "quiet",
741
      exitstatus = EX_OSERR;
24.1.54 by Björn Påhlsson
plugin-runner
742
      goto fallback;
24.1.8 by Björn Påhlsson
plugbasedclient
743
    }
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
744
  }
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
745
  /* If there were any arguments from the configuration file, pass
746
     them to parser as command line arguments */
24.1.51 by Björn Påhlsson
Added configuration files support for mandos-client
747
  if(custom_argv != NULL){
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
748
    ret = argp_parse(&argp, custom_argc, custom_argv,
749
		     ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
750
		     NULL, NULL);
751
    switch(ret){
752
    case 0:
753
      break;
754
    case ENOMEM:
755
    default:
756
      errno = ret;
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
757
      error(0, errno, "argp_parse");
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
758
      exitstatus = EX_OSERR;
759
      goto fallback;
760
    case EINVAL:
761
      exitstatus = EX_CONFIG;
24.1.54 by Björn Påhlsson
plugin-runner
762
      goto fallback;
24.1.26 by Björn Påhlsson
tally count of used symbols
763
    }
24.1.8 by Björn Påhlsson
plugbasedclient
764
  }
765
  
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
766
  /* Parse actual command line arguments, to let them override the
767
     config file */
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
768
  ret = argp_parse(&argp, argc, argv,
769
		   ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
770
		   NULL, NULL);
771
  switch(ret){
772
  case 0:
773
    break;
774
  case ENOMEM:
775
  default:
776
    errno = ret;
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
777
    error(0, errno, "argp_parse");
237.2.157 by Teddy Hogeborn
Convert some programs to use the exit codes from <sysexits.h>. Change
778
    exitstatus = EX_OSERR;
779
    goto fallback;
780
  case EINVAL:
781
    exitstatus = EX_USAGE;
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
782
    goto fallback;
783
  }
784
  
237.25.1 by Teddy Hogeborn
Add a plugin helper directory, available to all plugins.
785
  {
786
    char *pluginhelperenv;
787
    bool bret = true;
788
    ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
789
		   pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
790
    if(ret != -1){
791
      bret = add_environment(getplugin(NULL), pluginhelperenv, true);
792
    }
793
    if(ret == -1 or not bret){
794
      error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
795
	    " environment variable to \"%s\" for all plugins\n",
796
	    pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
797
    }
798
    if(ret != -1){
799
      free(pluginhelperenv);
800
    }
801
  }
802
  
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
803
  if(debug){
237.7.438 by Teddy Hogeborn
Add spaces around all '=' signs in all C code.
804
    for(plugin *p = plugin_list; p != NULL; p = p->next){
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
805
      fprintf(stderr, "Plugin: %s has %d arguments\n",
32 by Teddy Hogeborn
* plugins.d/plugbasedclient.c (set_cloexec_flag): New function.
806
	      p->name ? p->name : "Global", p->argc - 1);
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
807
      for(char **a = p->argv; *a != NULL; a++){
808
	fprintf(stderr, "\tArg: %s\n", *a);
809
      }
237.2.31 by Teddy Hogeborn
Fixes for sscanf usage:
810
      fprintf(stderr, "...and %d environment variables\n", p->envc);
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
811
      for(char **a = p->environ; *a != NULL; a++){
812
	fprintf(stderr, "\t%s\n", *a);
813
      }
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
814
    }
815
  }
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
816
  
237.16.11 by Teddy Hogeborn
* Makefile (run-client): Add "--network-hook-dir" option.
817
  if(getuid() == 0){
237.7.35 by Teddy Hogeborn
* initramfs-tools-script: Abort if plugin-runner is missing. Removed
818
    /* Work around Debian bug #633582:
237.7.416 by Teddy Hogeborn
Change all http:// URLs to https:// wherever possible.
819
       <https://bugs.debian.org/633582> */
237.7.35 by Teddy Hogeborn
* initramfs-tools-script: Abort if plugin-runner is missing. Removed
820
    int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
821
    if(plugindir_fd == -1){
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
822
      if(errno != ENOENT){
823
	error(0, errno, "open(\"" PDIR "\")");
824
      }
237.7.35 by Teddy Hogeborn
* initramfs-tools-script: Abort if plugin-runner is missing. Removed
825
    } else {
826
      ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
827
      if(ret == -1){
828
	error(0, errno, "fstat");
829
      } else {
830
	if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
831
	  ret = fchown(plugindir_fd, uid, gid);
832
	  if(ret == -1){
833
	    error(0, errno, "fchown");
834
	  }
835
	}
836
      }
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
837
      close(plugindir_fd);
237.7.35 by Teddy Hogeborn
* initramfs-tools-script: Abort if plugin-runner is missing. Removed
838
    }
839
  }
840
  
841
  /* Lower permissions */
237.7.168 by Teddy Hogeborn
* plugin-runner.c (main): Bug fix; do not ignore return value of
842
  ret = setgid(gid);
237.2.62 by Teddy Hogeborn
* plugin-runner.c (main): Bug fix: Do setgid before setuid.
843
  if(ret == -1){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
844
    error(0, errno, "setgid");
237.2.62 by Teddy Hogeborn
* plugin-runner.c (main): Bug fix: Do setgid before setuid.
845
  }
24.1.6 by Björn Påhlsson
plugbasedclient
846
  ret = setuid(uid);
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
847
  if(ret == -1){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
848
    error(0, errno, "setuid");
24.1.6 by Björn Påhlsson
plugbasedclient
849
  }
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
850
  
237.2.147 by Teddy Hogeborn
* plugin-runner.c (main): Use the O_CLOEXEC flag, if available, when
851
  /* Open plugin directory with close_on_exec flag */
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
852
  {
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
853
    dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
854
#ifdef O_CLOEXEC
855
		  O_CLOEXEC
856
#else  /* not O_CLOEXEC */
857
		  0
858
#endif	/* not O_CLOEXEC */
859
		  );
237.2.147 by Teddy Hogeborn
* plugin-runner.c (main): Use the O_CLOEXEC flag, if available, when
860
    if(dir_fd == -1){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
861
      error(0, errno, "Could not open plugin dir");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
862
      exitstatus = EX_UNAVAILABLE;
237.2.147 by Teddy Hogeborn
* plugin-runner.c (main): Use the O_CLOEXEC flag, if available, when
863
      goto fallback;
864
    }
865
    
866
#ifndef O_CLOEXEC
867
  /* Set the FD_CLOEXEC flag on the directory */
868
    ret = set_cloexec_flag(dir_fd);
869
    if(ret < 0){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
870
      error(0, errno, "set_cloexec_flag");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
871
      exitstatus = EX_OSERR;
237.2.147 by Teddy Hogeborn
* plugin-runner.c (main): Use the O_CLOEXEC flag, if available, when
872
      goto fallback;
873
    }
874
#endif	/* O_CLOEXEC */
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
875
  }
876
  
877
  int good_name(const struct dirent * const dirent){
878
    const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
879
				      "*.dpkg-old", "*.dpkg-bak",
880
				      "*.dpkg-divert", NULL };
881
#ifdef __GNUC__
882
#pragma GCC diagnostic push
883
#pragma GCC diagnostic ignored "-Wcast-qual"
884
#endif
885
    for(const char **pat = (const char **)patterns;
886
	*pat != NULL; pat++){
887
#ifdef __GNUC__
888
#pragma GCC diagnostic pop
889
#endif
890
      if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
891
	 != FNM_NOMATCH){
892
	if(debug){
893
	    fprintf(stderr, "Ignoring plugin dir entry \"%s\""
894
		    " matching pattern %s\n", dirent->d_name, *pat);
895
	}
896
	return 0;
897
      }
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
898
    }
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
899
    return 1;
900
  }
901
  
902
  int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
903
			     alphasort);
904
  if(numplugins == -1){
905
    error(0, errno, "Could not scan plugin dir");
237.7.253 by Teddy Hogeborn
plugin-runner: Release memory and close FD's correctly in all cases.
906
    direntries = NULL;
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
907
    exitstatus = EX_OSERR;
908
    goto fallback;
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
909
  }
24.1.1 by Björn Påhlsson
Added syntax and support for plugbasedclient arguments and how they
910
  
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
911
  FD_ZERO(&rfds_all);
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
912
  
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
913
  /* Read and execute any executable in the plugin directory*/
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
914
  for(int i = 0; i < numplugins; i++){
915
    
916
    int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
917
    if(plugin_fd == -1){
918
      error(0, errno, "Could not open plugin");
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
919
      free(direntries[i]);
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
920
      continue;
169 by Teddy Hogeborn
* plugin-runner.c (main): Bug fix: use built-in default value if
921
    }
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
922
    ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
923
    if(ret == -1){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
924
      error(0, errno, "stat");
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
925
      close(plugin_fd);
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
926
      free(direntries[i]);
24.1.46 by Björn Påhlsson
mandos-client
927
      continue;
24.1.26 by Björn Påhlsson
tally count of used symbols
928
    }
237.2.75 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
929
    
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
930
    /* Ignore non-executable files */
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
931
    if(not S_ISREG(st.st_mode)
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
932
       or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
933
					X_OK, 0)) != 0)){
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
934
      if(debug){
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
935
	fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
936
		" with bad type or mode\n",
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
937
		plugindir != NULL ? plugindir : PDIR,
938
		direntries[i]->d_name);
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
939
      }
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
940
      close(plugin_fd);
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
941
      free(direntries[i]);
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
942
      continue;
943
    }
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
944
    
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
945
    plugin *p = getplugin(direntries[i]->d_name);
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
946
    if(p == NULL){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
947
      error(0, errno, "getplugin");
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
948
      close(plugin_fd);
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
949
      free(direntries[i]);
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
950
      continue;
951
    }
952
    if(p->disabled){
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
953
      if(debug){
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
954
	fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
955
		direntries[i]->d_name);
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
956
      }
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
957
      close(plugin_fd);
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
958
      free(direntries[i]);
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
959
      continue;
960
    }
32 by Teddy Hogeborn
* plugins.d/plugbasedclient.c (set_cloexec_flag): New function.
961
    {
962
      /* Add global arguments to argument list for this plugin */
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
963
      plugin *g = getplugin(NULL);
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
964
      if(g != NULL){
965
	for(char **a = g->argv + 1; *a != NULL; a++){
966
	  if(not add_argument(p, *a)){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
967
	    error(0, errno, "add_argument");
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
968
	  }
969
	}
970
	/* Add global environment variables */
971
	for(char **e = g->environ; *e != NULL; e++){
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
972
	  if(not add_environment(p, *e, false)){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
973
	    error(0, errno, "add_environment");
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
974
	  }
975
	}
976
      }
977
    }
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
978
    /* If this plugin has any environment variables, we need to
979
       duplicate the environment from this process, too. */
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
980
    if(p->environ[0] != NULL){
981
      for(char **e = environ; *e != NULL; e++){
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
982
	if(not add_environment(p, *e, false)){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
983
	  error(0, errno, "add_environment");
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
984
	}
985
      }
986
    }
987
    
98 by Teddy Hogeborn
* plugin-runner.c (getplugin): Only copy "name" if not NULL. Free
988
    int pipefd[2];
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
989
#ifndef O_CLOEXEC
237.2.130 by Teddy Hogeborn
* init.d-mandos: Bug fix: Correct the LSB header.
990
    ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
991
#else  /* O_CLOEXEC */
992
    ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
993
#endif	/* O_CLOEXEC */
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
994
    if(ret == -1){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
995
      error(0, errno, "pipe");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
996
      exitstatus = EX_OSERR;
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
997
      free(direntries[i]);
24.1.54 by Björn Påhlsson
plugin-runner
998
      goto fallback;
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
999
    }
237.7.250 by Teddy Hogeborn
In plugin-runner, protect against a larger FD_SETSIZE than fd_set.
1000
    if(pipefd[0] >= FD_SETSIZE){
1001
      fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1002
	      FD_SETSIZE);
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
1003
      close(pipefd[0]);
1004
      close(pipefd[1]);
237.7.250 by Teddy Hogeborn
In plugin-runner, protect against a larger FD_SETSIZE than fd_set.
1005
      exitstatus = EX_OSERR;
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
1006
      free(direntries[i]);
237.7.250 by Teddy Hogeborn
In plugin-runner, protect against a larger FD_SETSIZE than fd_set.
1007
      goto fallback;
1008
    }
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
1009
#ifndef O_CLOEXEC
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1010
    /* Ask OS to automatic close the pipe on exec */
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1011
    ret = set_cloexec_flag(pipefd[0]);
1012
    if(ret < 0){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1013
      error(0, errno, "set_cloexec_flag");
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
1014
      close(pipefd[0]);
1015
      close(pipefd[1]);
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1016
      exitstatus = EX_OSERR;
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
1017
      free(direntries[i]);
24.1.54 by Björn Påhlsson
plugin-runner
1018
      goto fallback;
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1019
    }
1020
    ret = set_cloexec_flag(pipefd[1]);
1021
    if(ret < 0){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1022
      error(0, errno, "set_cloexec_flag");
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
1023
      close(pipefd[0]);
1024
      close(pipefd[1]);
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1025
      exitstatus = EX_OSERR;
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
1026
      free(direntries[i]);
24.1.54 by Björn Påhlsson
plugin-runner
1027
      goto fallback;
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1028
    }
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
1029
#endif	/* not O_CLOEXEC */
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1030
    /* Block SIGCHLD until process is safely in process list */
237.2.130 by Teddy Hogeborn
* init.d-mandos: Bug fix: Correct the LSB header.
1031
    ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1032
					      &sigchld_action.sa_mask,
1033
					      NULL));
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1034
    if(ret < 0){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1035
      error(0, errno, "sigprocmask");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1036
      exitstatus = EX_OSERR;
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
1037
      free(direntries[i]);
24.1.54 by Björn Påhlsson
plugin-runner
1038
      goto fallback;
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1039
    }
136 by Teddy Hogeborn
* plugin-runner.c (add_environment): Override existing environment
1040
    /* Starting a new process to be watched */
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
1041
    pid_t pid;
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
1042
    do {
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
1043
      pid = fork();
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
1044
    } while(pid == -1 and errno == EINTR);
24.1.46 by Björn Påhlsson
mandos-client
1045
    if(pid == -1){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1046
      error(0, errno, "fork");
237.7.249 by Teddy Hogeborn
plugin-runner: Restore resources correctly if fork() fails.
1047
      TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1048
				     &sigchld_action.sa_mask, NULL));
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
1049
      close(pipefd[0]);
1050
      close(pipefd[1]);
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1051
      exitstatus = EX_OSERR;
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
1052
      free(direntries[i]);
24.1.54 by Björn Påhlsson
plugin-runner
1053
      goto fallback;
24.1.46 by Björn Påhlsson
mandos-client
1054
    }
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
1055
    if(pid == 0){
1056
      /* this is the child process */
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1057
      ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1058
      if(ret < 0){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1059
	error(0, errno, "sigaction");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1060
	_exit(EX_OSERR);
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1061
      }
210 by Teddy Hogeborn
* debian/mandos-client.postinst: Change home directory to
1062
      ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1063
      if(ret < 0){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1064
	error(0, errno, "sigprocmask");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1065
	_exit(EX_OSERR);
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1066
      }
210 by Teddy Hogeborn
* debian/mandos-client.postinst: Change home directory to
1067
      
24.1.26 by Björn Påhlsson
tally count of used symbols
1068
      ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1069
      if(ret == -1){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1070
	error(0, errno, "dup2");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1071
	_exit(EX_OSERR);
24.1.26 by Björn Påhlsson
tally count of used symbols
1072
      }
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1073
      
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
1074
      if(fexecve(plugin_fd, p->argv,
237.7.222 by Teddy Hogeborn
Improve error message when working around Debian bug #633582.
1075
		(p->environ[0] != NULL) ? p->environ : environ) < 0){
237.7.223 by Teddy Hogeborn
Use openat() etc. in plugin-runner. Also one less useless warning.
1076
	error(0, errno, "fexecve for %s/%s",
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
1077
	      plugindir != NULL ? plugindir : PDIR,
1078
	      direntries[i]->d_name);
237.7.222 by Teddy Hogeborn
Improve error message when working around Debian bug #633582.
1079
	_exit(EX_OSERR);
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
1080
      }
1081
      /* no return */
1082
    }
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1083
    /* Parent process */
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
1084
    close(pipefd[1]);		/* Close unused write end of pipe */
1085
    close(plugin_fd);
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
1086
    plugin *new_plugin = getplugin(direntries[i]->d_name);
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
1087
    if(new_plugin == NULL){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1088
      error(0, errno, "getplugin");
237.2.130 by Teddy Hogeborn
* init.d-mandos: Bug fix: Correct the LSB header.
1089
      ret = (int)(TEMP_FAILURE_RETRY
1090
		  (sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1091
			       NULL)));
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1092
      if(ret < 0){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1093
        error(0, errno, "sigprocmask");
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1094
      }
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1095
      exitstatus = EX_OSERR;
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
1096
      free(direntries[i]);
24.1.54 by Björn Påhlsson
plugin-runner
1097
      goto fallback;
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
1098
    }
237.7.264 by Teddy Hogeborn
plugin-runner: Bug Fix: Fix some memory leaks.
1099
    free(direntries[i]);
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
1100
    
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1101
    new_plugin->pid = pid;
1102
    new_plugin->fd = pipefd[0];
237.7.500 by Teddy Hogeborn
plugin-runner: More debug output
1103
1104
    if(debug){
1105
      fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1106
	      new_plugin->name, (intmax_t) (new_plugin->pid));
1107
    }
1108
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1109
    /* Unblock SIGCHLD so signal handler can be run if this process
1110
       has already completed */
237.2.130 by Teddy Hogeborn
* init.d-mandos: Bug fix: Correct the LSB header.
1111
    ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1112
					      &sigchld_action.sa_mask,
1113
					      NULL));
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1114
    if(ret < 0){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1115
      error(0, errno, "sigprocmask");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1116
      exitstatus = EX_OSERR;
24.1.54 by Björn Påhlsson
plugin-runner
1117
      goto fallback;
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1118
    }
1119
    
237.7.358 by Teddy Hogeborn
Depend on the GNU C Library 2.16 or later
1120
    FD_SET(new_plugin->fd, &rfds_all);
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1121
    
237.2.29 by Teddy Hogeborn
* plugin-runner.c: Only space changes.
1122
    if(maxfd < new_plugin->fd){
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1123
      maxfd = new_plugin->fd;
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
1124
    }
13 by Björn Påhlsson
Added following support:
1125
  }
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1126
  
237.7.253 by Teddy Hogeborn
plugin-runner: Release memory and close FD's correctly in all cases.
1127
  free(direntries);
1128
  direntries = NULL;
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
1129
  close(dir_fd);
237.7.253 by Teddy Hogeborn
plugin-runner: Release memory and close FD's correctly in all cases.
1130
  dir_fd = -1;
24.1.132 by Björn Påhlsson
Fixed a bug in fallback handling
1131
  free_plugin(getplugin(NULL));
210 by Teddy Hogeborn
* debian/mandos-client.postinst: Change home directory to
1132
  
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1133
  for(plugin *p = plugin_list; p != NULL; p = p->next){
1134
    if(p->pid != 0){
1135
      break;
1136
    }
1137
    if(p->next == NULL){
1138
      fprintf(stderr, "No plugin processes started. Incorrect plugin"
1139
	      " directory?\n");
1140
      free_plugin_list();
1141
    }
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1142
  }
210 by Teddy Hogeborn
* debian/mandos-client.postinst: Change home directory to
1143
  
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1144
  /* Main loop while running plugins exist */
1145
  while(plugin_list){
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1146
    fd_set rfds = rfds_all;
1147
    int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
1148
    if(select_ret == -1 and errno != EINTR){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1149
      error(0, errno, "select");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1150
      exitstatus = EX_OSERR;
24.1.54 by Björn Påhlsson
plugin-runner
1151
      goto fallback;
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1152
    }
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1153
    /* OK, now either a process completed, or something can be read
1154
       from one of them */
24.1.92 by Björn Påhlsson
Several memory leaks detected by valgrind fixed
1155
    for(plugin *proc = plugin_list; proc != NULL;){
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1156
      /* Is this process completely done? */
237.2.60 by Teddy Hogeborn
* plugin-runner.c (struct plugin.status): Changed type to "int".
1157
      if(proc->completed and proc->eof){
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1158
	/* Only accept the plugin output if it exited cleanly */
1159
	if(not WIFEXITED(proc->status)
1160
	   or WEXITSTATUS(proc->status) != 0){
1161
	  /* Bad exit by plugin */
237.2.75 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
1162
	  
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1163
	  if(debug){
1164
	    if(WIFEXITED(proc->status)){
237.2.64 by Teddy Hogeborn
* plugin-runner.c (main): If debugging, print name of failed plugins.
1165
	      fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1166
		      " status %d\n", proc->name,
1167
		      (intmax_t) (proc->pid),
60 by Teddy Hogeborn
* mandos-client.c (main): Cast pid_t to unsigned int before printing.
1168
		      WEXITSTATUS(proc->status));
237.2.56 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
1169
	    } else if(WIFSIGNALED(proc->status)){
237.2.64 by Teddy Hogeborn
* plugin-runner.c (main): If debugging, print name of failed plugins.
1170
	      fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
237.2.119 by Teddy Hogeborn
* plugin-runner.c (main): When a plugin is killed by a signal, show
1171
		      " signal %d: %s\n", proc->name,
237.2.64 by Teddy Hogeborn
* plugin-runner.c (main): If debugging, print name of failed plugins.
1172
		      (intmax_t) (proc->pid),
237.2.119 by Teddy Hogeborn
* plugin-runner.c (main): When a plugin is killed by a signal, show
1173
		      WTERMSIG(proc->status),
1174
		      strsignal(WTERMSIG(proc->status)));
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1175
	    }
1176
	  }
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1177
	  
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1178
	  /* Remove the plugin */
237.7.358 by Teddy Hogeborn
Depend on the GNU C Library 2.16 or later
1179
	  FD_CLR(proc->fd, &rfds_all);
237.2.75 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
1180
	  
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1181
	  /* Block signal while modifying process_list */
237.2.130 by Teddy Hogeborn
* init.d-mandos: Bug fix: Correct the LSB header.
1182
	  ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1183
					(SIG_BLOCK,
1184
					 &sigchld_action.sa_mask,
1185
					 NULL));
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1186
	  if(ret < 0){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1187
	    error(0, errno, "sigprocmask");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1188
	    exitstatus = EX_OSERR;
24.1.54 by Björn Påhlsson
plugin-runner
1189
	    goto fallback;
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1190
	  }
24.1.92 by Björn Påhlsson
Several memory leaks detected by valgrind fixed
1191
	  
210 by Teddy Hogeborn
* debian/mandos-client.postinst: Change home directory to
1192
	  plugin *next_plugin = proc->next;
1193
	  free_plugin(proc);
1194
	  proc = next_plugin;
1195
	  
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1196
	  /* We are done modifying process list, so unblock signal */
237.2.130 by Teddy Hogeborn
* init.d-mandos: Bug fix: Correct the LSB header.
1197
	  ret = (int)(TEMP_FAILURE_RETRY
1198
		      (sigprocmask(SIG_UNBLOCK,
1199
				   &sigchld_action.sa_mask, NULL)));
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1200
	  if(ret < 0){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1201
	    error(0, errno, "sigprocmask");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1202
	    exitstatus = EX_OSERR;
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1203
	    goto fallback;
1204
	  }
1205
	  
1206
	  if(plugin_list == NULL){
1207
	    break;
1208
	  }
24.1.92 by Björn Påhlsson
Several memory leaks detected by valgrind fixed
1209
	  
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1210
	  continue;
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1211
	}
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1212
	
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1213
	/* This process exited nicely, so print its buffer */
210 by Teddy Hogeborn
* debian/mandos-client.postinst: Change home directory to
1214
	
102 by Teddy Hogeborn
* plugin-runner.c (process): Set "completed" and "status" as volatile.
1215
	bool bret = print_out_password(proc->buffer,
1216
				       proc->buffer_length);
24.1.42 by Björn Påhlsson
Added fallback to mandos-client
1217
	if(not bret){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1218
	  error(0, errno, "print_out_password");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1219
	  exitstatus = EX_IOERR;
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1220
	}
24.1.54 by Björn Påhlsson
plugin-runner
1221
	goto fallback;
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1222
      }
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1223
      
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1224
      /* This process has not completed.  Does it have any output? */
237.7.358 by Teddy Hogeborn
Depend on the GNU C Library 2.16 or later
1225
      if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1226
	/* This process had nothing to say at this time */
24.1.92 by Björn Påhlsson
Several memory leaks detected by valgrind fixed
1227
	proc = proc->next;
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1228
	continue;
1229
      }
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1230
      /* Before reading, make the process' data buffer large enough */
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1231
      if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
1232
	char *new_buffer = realloc(proc->buffer, proc->buffer_size
1233
				   + (size_t) BUFFER_SIZE);
1234
	if(new_buffer == NULL){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1235
	  error(0, errno, "malloc");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1236
	  exitstatus = EX_OSERR;
24.1.54 by Björn Påhlsson
plugin-runner
1237
	  goto fallback;
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1238
	}
237.7.214 by Teddy Hogeborn
Bug fix: Free all memory and give better messages when memory is full.
1239
	proc->buffer = new_buffer;
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1240
	proc->buffer_size += BUFFER_SIZE;
1241
      }
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1242
      /* Read from the process */
237.2.125 by Teddy Hogeborn
* plugin-runner.c (getplugin, add_environment, main): Handle EINTR
1243
      sret = TEMP_FAILURE_RETRY(read(proc->fd,
1244
				     proc->buffer
1245
				     + proc->buffer_length,
1246
				     BUFFER_SIZE));
237.2.17 by Teddy Hogeborn
Eliminate warning on 64-bit systems, thanks to Frans Pop
1247
      if(sret < 0){
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1248
	/* Read error from this process; ignore the error */
24.1.92 by Björn Påhlsson
Several memory leaks detected by valgrind fixed
1249
	proc = proc->next;
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1250
	continue;
1251
      }
237.2.17 by Teddy Hogeborn
Eliminate warning on 64-bit systems, thanks to Frans Pop
1252
      if(sret == 0){
34 by Teddy Hogeborn
* plugbasedclient.c (main): Check if plugin dir could be opened. Set
1253
	/* got EOF */
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1254
	proc->eof = true;
1255
      } else {
237.2.17 by Teddy Hogeborn
Eliminate warning on 64-bit systems, thanks to Frans Pop
1256
	proc->buffer_length += (size_t) sret;
13 by Björn Påhlsson
Added following support:
1257
      }
1258
    }
1259
  }
237.2.75 by Teddy Hogeborn
* plugin-runner.c: Whitespace changes only.
1260
  
1261
  
24.1.54 by Björn Påhlsson
plugin-runner
1262
 fallback:
24.1.42 by Björn Påhlsson
Added fallback to mandos-client
1263
  
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1264
  if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1265
			     and exitstatus != EX_OK)){
102 by Teddy Hogeborn
* plugin-runner.c (process): Set "completed" and "status" as volatile.
1266
    /* Fallback if all plugins failed, none are found or an error
1267
       occured */
24.1.42 by Björn Påhlsson
Added fallback to mandos-client
1268
    bool bret;
1269
    fprintf(stderr, "Going to fallback mode using getpass(3)\n");
1270
    char *passwordbuffer = getpass("Password: ");
168 by Teddy Hogeborn
* initramfs-tools-hook: Use long options where available. Use only
1271
    size_t len = strlen(passwordbuffer);
1272
    /* Strip trailing newline */
1273
    if(len > 0 and passwordbuffer[len-1] == '\n'){
1274
      passwordbuffer[len-1] = '\0'; /* not strictly necessary */
1275
      len--;
1276
    }
1277
    bret = print_out_password(passwordbuffer, len);
24.1.42 by Björn Påhlsson
Added fallback to mandos-client
1278
    if(not bret){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1279
      error(0, errno, "print_out_password");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1280
      exitstatus = EX_IOERR;
24.1.42 by Björn Påhlsson
Added fallback to mandos-client
1281
    }
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1282
  }
24.1.42 by Björn Påhlsson
Added fallback to mandos-client
1283
  
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1284
  /* Restore old signal handler */
24.1.54 by Björn Påhlsson
plugin-runner
1285
  ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1286
  if(ret == -1){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1287
    error(0, errno, "sigaction");
237.2.162 by Teddy Hogeborn
* Makefile (BROKEN_PIE): Add comment.
1288
    exitstatus = EX_OSERR;
24.1.54 by Björn Påhlsson
plugin-runner
1289
  }
210 by Teddy Hogeborn
* debian/mandos-client.postinst: Change home directory to
1290
  
24.1.54 by Björn Påhlsson
plugin-runner
1291
  if(custom_argv != NULL){
24.1.67 by Björn Påhlsson
transformed a function to a part of main
1292
    for(char **arg = custom_argv+1; *arg != NULL; arg++){
24.1.54 by Björn Påhlsson
plugin-runner
1293
      free(*arg);
78 by Teddy Hogeborn
Add feature to specify custom environment variables for plugins.
1294
    }
24.1.54 by Björn Påhlsson
plugin-runner
1295
    free(custom_argv);
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1296
  }
1297
  
237.7.253 by Teddy Hogeborn
plugin-runner: Release memory and close FD's correctly in all cases.
1298
  free(direntries);
1299
  
237.7.251 by Teddy Hogeborn
In plugin-runner, do scandirat() or scandir() instead of readdir().
1300
  if(dir_fd != -1){
237.7.322 by Teddy Hogeborn
Don't use TEMP_FAILURE_RETRY around close().
1301
    close(dir_fd);
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1302
  }
1303
  
210 by Teddy Hogeborn
* debian/mandos-client.postinst: Change home directory to
1304
  /* Kill the processes */
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1305
  for(plugin *p = plugin_list; p != NULL; p = p->next){
1306
    if(p->pid != 0){
1307
      close(p->fd);
1308
      ret = kill(p->pid, SIGTERM);
1309
      if(ret == -1 and errno != ESRCH){
1310
	/* Set-uid proccesses might not get closed */
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1311
	error(0, errno, "kill");
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1312
      }
24.1.26 by Björn Påhlsson
tally count of used symbols
1313
    }
13 by Björn Påhlsson
Added following support:
1314
  }
1315
  
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1316
  /* Wait for any remaining child processes to terminate */
237.2.126 by Teddy Hogeborn
* plugin-runner.c: Minor stylistic changes.
1317
  do {
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1318
    ret = wait(NULL);
1319
  } while(ret >= 0);
1320
  if(errno != ECHILD){
24.1.155 by Björn Påhlsson
mandos server: Added debuglevel that adjust at what level information
1321
    error(0, errno, "wait");
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1322
  }
210 by Teddy Hogeborn
* debian/mandos-client.postinst: Change home directory to
1323
  
24.1.76 by Björn Påhlsson
Rearranged so plugins and processes is the same thing
1324
  free_plugin_list();
1325
  
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
1326
  free(plugindir);
237.25.1 by Teddy Hogeborn
Add a plugin helper directory, available to all plugins.
1327
  free(pluginhelperdir);
24.1.69 by Björn Påhlsson
added configfile as a optional argument to plugin-runner
1328
  free(argfile);
35 by Teddy Hogeborn
* plugbasedclient.c (struct process): New fields "eof", "completed",
1329
  
31 by Teddy Hogeborn
* plugins.d/plugbasedclient.c: Update include file comments.
1330
  return exitstatus;
13 by Björn Påhlsson
Added following support:
1331
}