/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release
24.1.116 by Björn Påhlsson
added a mandos list client program
1
#!/usr/bin/python
237.2.3 by Teddy Hogeborn
Merge "mandos-list" from belorn.
2
# -*- mode: python; coding: utf-8 -*-
237.2.207 by Teddy Hogeborn
Update copyright year to "2010" wherever appropriate.
3
# 
4
# Mandos Monitor - Control and monitor the Mandos server
5
# 
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
6
# Copyright © 2008-2015 Teddy Hogeborn
7
# Copyright © 2008-2015 Björn Påhlsson
237.2.207 by Teddy Hogeborn
Update copyright year to "2010" wherever appropriate.
8
# 
9
# This program is free software: you can redistribute it and/or modify
10
# it under the terms of the GNU General Public License as published by
11
# the Free Software Foundation, either version 3 of the License, or
12
# (at your option) any later version.
13
#
14
#     This program is distributed in the hope that it will be useful,
15
#     but WITHOUT ANY WARRANTY; without even the implied warranty of
16
#     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17
#     GNU General Public License for more details.
18
# 
19
# You should have received a copy of the GNU General Public License
237.7.120 by Teddy Hogeborn
* mandos-ctl: Break long lines.
20
# along with this program.  If not, see
21
# <http://www.gnu.org/licenses/>.
237.2.207 by Teddy Hogeborn
Update copyright year to "2010" wherever appropriate.
22
# 
237.11.2 by Teddy Hogeborn
Change "fukt.bsnet.se" to "recompile.se" throughout.
23
# Contact the authors at <mandos@recompile.se>.
237.2.207 by Teddy Hogeborn
Update copyright year to "2010" wherever appropriate.
24
# 
24.1.116 by Björn Påhlsson
added a mandos list client program
25
237.8.9 by teddy at bsnet
* mandos-ctl: Use print function.
26
from __future__ import (division, absolute_import, print_function,
27
                        unicode_literals)
237.8.8 by teddy at bsnet
* mandos-ctl: Use unicode string literals.
28
237.7.266 by Teddy Hogeborn
mandos-ctl: Make it work in Python 3.
29
try:
30
    from future_builtins import *
31
except ImportError:
32
    pass
237.7.127 by Teddy Hogeborn
* mandos: Use all new builtins.
33
24.1.119 by Björn Påhlsson
Added more method support for mandos clients through mandos-ctl
34
import sys
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
35
import argparse
237.2.3 by Teddy Hogeborn
Merge "mandos-list" from belorn.
36
import locale
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
37
import datetime
38
import re
24.1.163 by Björn Påhlsson
mandos-client: Added never ending loop for --connect
39
import os
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
40
import collections
41
import doctest
42
43
import dbus
237.2.3 by Teddy Hogeborn
Merge "mandos-list" from belorn.
44
237.23.7 by Teddy Hogeborn
Use the .major attribute on sys.version_info instead of using "[0]".
45
if sys.version_info.major == 2:
237.7.266 by Teddy Hogeborn
mandos-ctl: Make it work in Python 3.
46
    str = unicode
47
237.8.8 by teddy at bsnet
* mandos-ctl: Use unicode string literals.
48
locale.setlocale(locale.LC_ALL, "")
24.1.116 by Björn Påhlsson
added a mandos list client program
49
50
tablewords = {
237.8.8 by teddy at bsnet
* mandos-ctl: Use unicode string literals.
51
    "Name": "Name",
52
    "Enabled": "Enabled",
53
    "Timeout": "Timeout",
54
    "LastCheckedOK": "Last Successful Check",
55
    "LastApprovalRequest": "Last Approval Request",
56
    "Created": "Created",
57
    "Interval": "Interval",
58
    "Host": "Host",
59
    "Fingerprint": "Fingerprint",
60
    "CheckerRunning": "Check Is Running",
61
    "LastEnabled": "Last Enabled",
62
    "ApprovalPending": "Approval Is Pending",
63
    "ApprovedByDefault": "Approved By Default",
64
    "ApprovalDelay": "Approval Delay",
65
    "ApprovalDuration": "Approval Duration",
66
    "Checker": "Checker",
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
67
    "ExtendedTimeout": "Extended Timeout"
68
}
237.8.8 by teddy at bsnet
* mandos-ctl: Use unicode string literals.
69
defaultkeywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
24.1.186 by Björn Påhlsson
transitional stuff actually working
70
domain = "se.recompile"
237.8.8 by teddy at bsnet
* mandos-ctl: Use unicode string literals.
71
busname = domain + ".Mandos"
72
server_path = "/"
73
server_interface = domain + ".Mandos"
74
client_interface = domain + ".Mandos.Client"
324 by Teddy Hogeborn
* Makefile (version): Changed to "1.6.9".
75
version = "1.6.9"
24.1.118 by Björn Påhlsson
Added enable/disable
76
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
77
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
78
def milliseconds_to_string(ms):
79
    td = datetime.timedelta(0, 0, 0, ms)
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
80
    return ("{days}{hours:02}:{minutes:02}:{seconds:02}".format(
81
        days = "{}T".format(td.days) if td.days else "",
82
        hours = td.seconds // 3600,
83
        minutes = (td.seconds % 3600) // 60,
84
        seconds = td.seconds % 60))
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
85
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
86
87
def rfc3339_duration_to_delta(duration):
237.7.157 by Teddy Hogeborn
* clients.conf: Convert all time intervals to new RFC 3339 syntax.
88
    """Parse an RFC 3339 "duration" and return a datetime.timedelta
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
89
    
90
    >>> rfc3339_duration_to_delta("P7D")
91
    datetime.timedelta(7)
92
    >>> rfc3339_duration_to_delta("PT60S")
93
    datetime.timedelta(0, 60)
94
    >>> rfc3339_duration_to_delta("PT60M")
95
    datetime.timedelta(0, 3600)
96
    >>> rfc3339_duration_to_delta("PT24H")
97
    datetime.timedelta(1)
98
    >>> rfc3339_duration_to_delta("P1W")
99
    datetime.timedelta(7)
100
    >>> rfc3339_duration_to_delta("PT5M30S")
101
    datetime.timedelta(0, 330)
102
    >>> rfc3339_duration_to_delta("P1DT3M20S")
103
    datetime.timedelta(1, 200)
104
    """
105
    
237.7.157 by Teddy Hogeborn
* clients.conf: Convert all time intervals to new RFC 3339 syntax.
106
    # Parsing an RFC 3339 duration with regular expressions is not
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
107
    # possible - there would have to be multiple places for the same
237.7.157 by Teddy Hogeborn
* clients.conf: Convert all time intervals to new RFC 3339 syntax.
108
    # values, like seconds.  The current code, while more esoteric, is
109
    # cleaner without depending on a parsing library.  If Python had a
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
110
    # built-in library for parsing we would use it, but we'd like to
111
    # avoid excessive use of external libraries.
112
    
113
    # New type for defining tokens, syntax, and semantics all-in-one
114
    Token = collections.namedtuple("Token",
115
                                   ("regexp", # To match token; if
116
                                              # "value" is not None,
117
                                              # must have a "group"
118
                                              # containing digits
119
                                    "value",  # datetime.timedelta or
120
                                              # None
121
                                    "followers")) # Tokens valid after
122
                                                  # this token
123
    # RFC 3339 "duration" tokens, syntax, and semantics; taken from
124
    # the "duration" ABNF definition in RFC 3339, Appendix A.
125
    token_end = Token(re.compile(r"$"), None, frozenset())
126
    token_second = Token(re.compile(r"(\d+)S"),
127
                         datetime.timedelta(seconds=1),
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
128
                         frozenset((token_end, )))
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
129
    token_minute = Token(re.compile(r"(\d+)M"),
130
                         datetime.timedelta(minutes=1),
131
                         frozenset((token_second, token_end)))
132
    token_hour = Token(re.compile(r"(\d+)H"),
133
                       datetime.timedelta(hours=1),
134
                       frozenset((token_minute, token_end)))
135
    token_time = Token(re.compile(r"T"),
136
                       None,
137
                       frozenset((token_hour, token_minute,
138
                                  token_second)))
139
    token_day = Token(re.compile(r"(\d+)D"),
140
                      datetime.timedelta(days=1),
141
                      frozenset((token_time, token_end)))
142
    token_month = Token(re.compile(r"(\d+)M"),
143
                        datetime.timedelta(weeks=4),
144
                        frozenset((token_day, token_end)))
145
    token_year = Token(re.compile(r"(\d+)Y"),
146
                       datetime.timedelta(weeks=52),
147
                       frozenset((token_month, token_end)))
148
    token_week = Token(re.compile(r"(\d+)W"),
149
                       datetime.timedelta(weeks=1),
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
150
                       frozenset((token_end, )))
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
151
    token_duration = Token(re.compile(r"P"), None,
152
                           frozenset((token_year, token_month,
153
                                      token_day, token_time,
237.7.269 by Teddy Hogeborn
Fix two mutually cancelling bugs.
154
                                      token_week)))
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
155
    # Define starting values
156
    value = datetime.timedelta() # Value so far
157
    found_token = None
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
158
    followers = frozenset((token_duration, )) # Following valid tokens
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
159
    s = duration                # String left to parse
160
    # Loop until end token is found
161
    while found_token is not token_end:
162
        # Search for any currently valid tokens
163
        for token in followers:
164
            match = token.regexp.match(s)
165
            if match is not None:
166
                # Token found
167
                if token.value is not None:
168
                    # Value found, parse digits
169
                    factor = int(match.group(1), 10)
170
                    # Add to value so far
171
                    value += factor * token.value
172
                # Strip token from string
173
                s = token.regexp.sub("", s, 1)
174
                # Go to found token
175
                found_token = token
176
                # Set valid next tokens
177
                followers = found_token.followers
178
                break
179
        else:
180
            # No currently valid tokens were found
181
            raise ValueError("Invalid RFC 3339 duration")
182
    # End token found
183
    return value
184
185
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
186
def string_to_delta(interval):
187
    """Parse a string and return a datetime.timedelta
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
188
    
237.8.7 by teddy at bsnet
* mandos-ctl: Use only unicode string literals.
189
    >>> string_to_delta("7d")
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
190
    datetime.timedelta(7)
237.8.7 by teddy at bsnet
* mandos-ctl: Use only unicode string literals.
191
    >>> string_to_delta("60s")
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
192
    datetime.timedelta(0, 60)
237.8.7 by teddy at bsnet
* mandos-ctl: Use only unicode string literals.
193
    >>> string_to_delta("60m")
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
194
    datetime.timedelta(0, 3600)
237.8.7 by teddy at bsnet
* mandos-ctl: Use only unicode string literals.
195
    >>> string_to_delta("24h")
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
196
    datetime.timedelta(1)
237.8.8 by teddy at bsnet
* mandos-ctl: Use unicode string literals.
197
    >>> string_to_delta("1w")
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
198
    datetime.timedelta(7)
237.8.7 by teddy at bsnet
* mandos-ctl: Use only unicode string literals.
199
    >>> string_to_delta("5m 30s")
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
200
    datetime.timedelta(0, 330)
201
    """
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
202
    
203
    try:
204
        return rfc3339_duration_to_delta(interval)
205
    except ValueError:
206
        pass
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
207
    
237.7.164 by Teddy Hogeborn
* mandos-ctl (string_to_delta): Try to parse RFC 3339 duration before
208
    value = datetime.timedelta(0)
209
    regexp = re.compile(r"(\d+)([dsmhw]?)")
210
    
237.14.9 by Teddy Hogeborn
* mandos (ClientDBus.approval_delay, ClientDBus.approval_duration,
211
    for num, suffix in regexp.findall(interval):
212
        if suffix == "d":
213
            value += datetime.timedelta(int(num))
214
        elif suffix == "s":
215
            value += datetime.timedelta(0, int(num))
216
        elif suffix == "m":
217
            value += datetime.timedelta(0, 0, 0, 0, int(num))
218
        elif suffix == "h":
219
            value += datetime.timedelta(0, 0, 0, 0, 0, int(num))
220
        elif suffix == "w":
221
            value += datetime.timedelta(0, 0, 0, 0, 0, 0, int(num))
222
        elif suffix == "":
223
            value += datetime.timedelta(0, 0, 0, int(num))
224
    return value
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
225
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
226
24.1.163 by Björn Påhlsson
mandos-client: Added never ending loop for --connect
227
def print_clients(clients, keywords):
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
228
    def valuetostring(value, keyword):
229
        if type(value) is dbus.Boolean:
237.8.8 by teddy at bsnet
* mandos-ctl: Use unicode string literals.
230
            return "Yes" if value else "No"
231
        if keyword in ("Timeout", "Interval", "ApprovalDelay",
237.7.119 by Teddy Hogeborn
* mandos-ctl (print_clients): Bug fix: Don't show "Extended Timeout"
232
                       "ApprovalDuration", "ExtendedTimeout"):
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
233
            return milliseconds_to_string(value)
237.7.266 by Teddy Hogeborn
mandos-ctl: Make it work in Python 3.
234
        return str(value)
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
235
    
237.2.145 by Teddy Hogeborn
* mandos-ctl: Made work again after D-Bus API changes.
236
    # Create format string to print table rows
237.7.117 by Teddy Hogeborn
* mandos-ctl: Use new string format method. Bug fix: --version now
237
    format_string = " ".join("{{{key}:{width}}}".format(
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
238
        width = max(len(tablewords[key]),
239
                    max(len(valuetostring(client[key], key))
240
                        for client in clients)),
241
        key = key)
242
                             for key in keywords)
237.2.145 by Teddy Hogeborn
* mandos-ctl: Made work again after D-Bus API changes.
243
    # Print header line
237.7.117 by Teddy Hogeborn
* mandos-ctl: Use new string format method. Bug fix: --version now
244
    print(format_string.format(**tablewords))
24.1.121 by Björn Påhlsson
mandos-ctl: Added support for all client calls
245
    for client in clients:
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
246
        print(format_string.format(**{
247
            key: valuetostring(client[key], key)
248
            for key in keywords }))
249
237.2.201 by Teddy Hogeborn
* mandos (Client.runtime_expansions): New attribute containing the
250
24.1.163 by Björn Påhlsson
mandos-client: Added never ending loop for --connect
251
def has_actions(options):
252
    return any((options.enable,
253
                options.disable,
254
                options.bump_timeout,
255
                options.start_checker,
256
                options.stop_checker,
257
                options.is_enabled,
258
                options.remove,
259
                options.checker is not None,
260
                options.timeout is not None,
24.1.179 by Björn Påhlsson
New feature:
261
                options.extended_timeout is not None,
24.1.163 by Björn Påhlsson
mandos-client: Added never ending loop for --connect
262
                options.interval is not None,
237.2.204 by Teddy Hogeborn
* mandos (ClientDBus.__init__): Bug fix: Translate "-" in client names
263
                options.approved_by_default is not None,
264
                options.approval_delay is not None,
265
                options.approval_duration is not None,
24.1.163 by Björn Påhlsson
mandos-client: Added never ending loop for --connect
266
                options.host is not None,
267
                options.secret is not None,
268
                options.approve,
269
                options.deny))
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
270
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
271
24.1.163 by Björn Påhlsson
mandos-client: Added never ending loop for --connect
272
def main():
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
273
    parser = argparse.ArgumentParser()
274
    parser.add_argument("--version", action="version",
237.23.5 by Teddy Hogeborn
Use the new auto-numbered "{}" syntax for the .format() string method.
275
                        version = "%(prog)s {}".format(version),
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
276
                        help="show version number and exit")
277
    parser.add_argument("-a", "--all", action="store_true",
278
                        help="Select all clients")
279
    parser.add_argument("-v", "--verbose", action="store_true",
280
                        help="Print all fields")
281
    parser.add_argument("-e", "--enable", action="store_true",
282
                        help="Enable client")
283
    parser.add_argument("-d", "--disable", action="store_true",
284
                        help="disable client")
285
    parser.add_argument("-b", "--bump-timeout", action="store_true",
286
                        help="Bump timeout for client")
287
    parser.add_argument("--start-checker", action="store_true",
288
                        help="Start checker for client")
289
    parser.add_argument("--stop-checker", action="store_true",
290
                        help="Stop checker for client")
291
    parser.add_argument("-V", "--is-enabled", action="store_true",
292
                        help="Check if client is enabled")
293
    parser.add_argument("-r", "--remove", action="store_true",
294
                        help="Remove client")
295
    parser.add_argument("-c", "--checker",
296
                        help="Set checker command for client")
297
    parser.add_argument("-t", "--timeout",
298
                        help="Set timeout for client")
24.1.179 by Björn Påhlsson
New feature:
299
    parser.add_argument("--extended-timeout",
300
                        help="Set extended timeout for client")
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
301
    parser.add_argument("-i", "--interval",
302
                        help="Set checker interval for client")
303
    parser.add_argument("--approve-by-default", action="store_true",
304
                        default=None, dest="approved_by_default",
305
                        help="Set client to be approved by default")
306
    parser.add_argument("--deny-by-default", action="store_false",
307
                        dest="approved_by_default",
308
                        help="Set client to be denied by default")
309
    parser.add_argument("--approval-delay",
310
                        help="Set delay before client approve/deny")
311
    parser.add_argument("--approval-duration",
312
                        help="Set duration of one client approval")
313
    parser.add_argument("-H", "--host", help="Set host for client")
237.7.266 by Teddy Hogeborn
mandos-ctl: Make it work in Python 3.
314
    parser.add_argument("-s", "--secret",
315
                        type=argparse.FileType(mode="rb"),
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
316
                        help="Set password blob (file) for client")
317
    parser.add_argument("-A", "--approve", action="store_true",
318
                        help="Approve any current client request")
319
    parser.add_argument("-D", "--deny", action="store_true",
320
                        help="Deny any current client request")
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
321
    parser.add_argument("--check", action="store_true",
322
                        help="Run self-test")
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
323
    parser.add_argument("client", nargs="*", help="Client name")
324
    options = parser.parse_args()
325
    
237.7.120 by Teddy Hogeborn
* mandos-ctl: Break long lines.
326
    if has_actions(options) and not (options.client or options.all):
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
327
        parser.error("Options require clients names or --all.")
328
    if options.verbose and has_actions(options):
329
        parser.error("--verbose can only be used alone or with"
330
                     " --all.")
331
    if options.all and not has_actions(options):
332
        parser.error("--all requires an action.")
237.7.156 by Teddy Hogeborn
* Makefile (check): Also check mandos-ctl.
333
334
    if options.check:
335
        fail_count, test_count = doctest.testmod()
237.7.202 by Teddy Hogeborn
Fix running of self-tests.
336
        sys.exit(os.EX_OK if fail_count == 0 else 1)
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
337
    
338
    try:
339
        bus = dbus.SystemBus()
340
        mandos_dbus_objc = bus.get_object(busname, server_path)
341
    except dbus.exceptions.DBusException:
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
342
        print("Could not connect to Mandos server", file=sys.stderr)
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
343
        sys.exit(1)
344
    
345
    mandos_serv = dbus.Interface(mandos_dbus_objc,
346
                                 dbus_interface = server_interface)
347
    
348
    #block stderr since dbus library prints to stderr
349
    null = os.open(os.path.devnull, os.O_RDWR)
350
    stderrcopy = os.dup(sys.stderr.fileno())
351
    os.dup2(null, sys.stderr.fileno())
352
    os.close(null)
353
    try:
354
        try:
355
            mandos_clients = mandos_serv.GetAllClientsWithProperties()
356
        finally:
357
            #restore stderr
358
            os.dup2(stderrcopy, sys.stderr.fileno())
359
            os.close(stderrcopy)
237.11.24 by Teddy Hogeborn
* mandos-ctl (main): Correct "except:" syntax.
360
    except dbus.exceptions.DBusException:
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
361
        print("Access denied: Accessing mandos server through dbus.",
362
              file=sys.stderr)
363
        sys.exit(1)
364
    
365
    # Compile dict of (clients: properties) to process
366
    clients={}
367
    
368
    if options.all or not options.client:
237.23.3 by Teddy Hogeborn
Use dictionary comprehensions.
369
        clients = { bus.get_object(busname, path): properties
370
                    for path, properties in mandos_clients.items() }
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
371
    else:
372
        for name in options.client:
237.23.4 by Teddy Hogeborn
Use the .items() method instead of .iteritems().
373
            for path, client in mandos_clients.items():
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
374
                if client["Name"] == name:
375
                    client_objc = bus.get_object(busname, path)
376
                    clients[client_objc] = client
377
                    break
24.1.163 by Björn Påhlsson
mandos-client: Added never ending loop for --connect
378
            else:
237.23.5 by Teddy Hogeborn
Use the new auto-numbered "{}" syntax for the .format() string method.
379
                print("Client not found on server: {!r}"
237.7.117 by Teddy Hogeborn
* mandos-ctl: Use new string format method. Bug fix: --version now
380
                      .format(name), file=sys.stderr)
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
381
                sys.exit(1)
382
    
383
    if not has_actions(options) and clients:
384
        if options.verbose:
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
385
            keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
386
                        "Created", "Interval", "Host", "Fingerprint",
387
                        "CheckerRunning", "LastEnabled",
388
                        "ApprovalPending", "ApprovedByDefault",
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
389
                        "LastApprovalRequest", "ApprovalDelay",
24.1.179 by Björn Påhlsson
New feature:
390
                        "ApprovalDuration", "Checker",
391
                        "ExtendedTimeout")
24.1.163 by Björn Påhlsson
mandos-client: Added never ending loop for --connect
392
        else:
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
393
            keywords = defaultkeywords
394
        
395
        print_clients(clients.values(), keywords)
396
    else:
397
        # Process each client in the list by all selected options
398
        for client in clients:
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
399
            
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
400
            def set_client_prop(prop, value):
401
                """Set a Client D-Bus property"""
402
                client.Set(client_interface, prop, value,
403
                           dbus_interface=dbus.PROPERTIES_IFACE)
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
404
            
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
405
            def set_client_prop_ms(prop, value):
406
                """Set a Client D-Bus property, converted
407
                from a string to milliseconds."""
408
                set_client_prop(prop,
237.23.6 by Teddy Hogeborn
Use the new .total_seconds() method on datetime.timedelta objects.
409
                                string_to_delta(value).total_seconds()
410
                                * 1000)
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
411
            
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
412
            if options.remove:
413
                mandos_serv.RemoveClient(client.__dbus_object_path__)
414
            if options.enable:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
415
                set_client_prop("Enabled", dbus.Boolean(True))
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
416
            if options.disable:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
417
                set_client_prop("Enabled", dbus.Boolean(False))
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
418
            if options.bump_timeout:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
419
                set_client_prop("LastCheckedOK", "")
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
420
            if options.start_checker:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
421
                set_client_prop("CheckerRunning", dbus.Boolean(True))
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
422
            if options.stop_checker:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
423
                set_client_prop("CheckerRunning", dbus.Boolean(False))
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
424
            if options.is_enabled:
425
                sys.exit(0 if client.Get(client_interface,
426
                                         "Enabled",
427
                                         dbus_interface=
428
                                         dbus.PROPERTIES_IFACE)
429
                         else 1)
237.11.16 by Teddy Hogeborn
* mandos-ctl (main): Bug fix: Handle empty strings correctly.
430
            if options.checker is not None:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
431
                set_client_prop("Checker", options.checker)
237.11.16 by Teddy Hogeborn
* mandos-ctl (main): Bug fix: Handle empty strings correctly.
432
            if options.host is not None:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
433
                set_client_prop("Host", options.host)
237.11.16 by Teddy Hogeborn
* mandos-ctl (main): Bug fix: Handle empty strings correctly.
434
            if options.interval is not None:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
435
                set_client_prop_ms("Interval", options.interval)
237.11.16 by Teddy Hogeborn
* mandos-ctl (main): Bug fix: Handle empty strings correctly.
436
            if options.approval_delay is not None:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
437
                set_client_prop_ms("ApprovalDelay",
438
                                   options.approval_delay)
237.11.16 by Teddy Hogeborn
* mandos-ctl (main): Bug fix: Handle empty strings correctly.
439
            if options.approval_duration is not None:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
440
                set_client_prop_ms("ApprovalDuration",
441
                                   options.approval_duration)
237.11.16 by Teddy Hogeborn
* mandos-ctl (main): Bug fix: Handle empty strings correctly.
442
            if options.timeout is not None:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
443
                set_client_prop_ms("Timeout", options.timeout)
237.11.16 by Teddy Hogeborn
* mandos-ctl (main): Bug fix: Handle empty strings correctly.
444
            if options.extended_timeout is not None:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
445
                set_client_prop_ms("ExtendedTimeout",
446
                                   options.extended_timeout)
237.11.16 by Teddy Hogeborn
* mandos-ctl (main): Bug fix: Handle empty strings correctly.
447
            if options.secret is not None:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
448
                set_client_prop("Secret",
449
                                dbus.ByteArray(options.secret.read()))
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
450
            if options.approved_by_default is not None:
237.20.2 by Teddy Hogeborn
* mandos-ctl (main): Use helper functions to shorten code.
451
                set_client_prop("ApprovedByDefault",
452
                                dbus.Boolean(options
453
                                             .approved_by_default))
237.7.23 by teddy at bsnet
* mandos-ctl: Use the new argparse library instead of optparse.
454
            if options.approve:
455
                client.Approve(dbus.Boolean(True),
456
                               dbus_interface=client_interface)
457
            elif options.deny:
458
                client.Approve(dbus.Boolean(False),
459
                               dbus_interface=client_interface)
24.1.163 by Björn Påhlsson
mandos-client: Added never ending loop for --connect
460
237.7.293 by Teddy Hogeborn
mandos-ctl: Do minor formatting and whitespace adjustments.
461
237.8.8 by teddy at bsnet
* mandos-ctl: Use unicode string literals.
462
if __name__ == "__main__":
24.1.163 by Björn Påhlsson
mandos-client: Added never ending loop for --connect
463
    main()