/mandos/release : contents of plugin-runner.c at revision 176

: (revision 176)

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/release

21 by Teddy Hogeborn * Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and	1	/* -- coding: utf-8 -- */
	2	/*
	3	* Mandos plugin runner - Run Mandos plugins
	4	*
28 by Teddy Hogeborn * server.conf: New file.	5	* Copyright © 2007-2008 Teddy Hogeborn & Björn Påhlsson
21 by Teddy Hogeborn * Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and	6	*
	7	* This program is free software: you can redistribute it and/or
	8	* modify it under the terms of the GNU General Public License as
	9	* published by the Free Software Foundation, either version 3 of the
	10	* License, or (at your option) any later version.
	11	*
	12	* This program is distributed in the hope that it will be useful, but
	13	* WITHOUT ANY WARRANTY; without even the implied warranty of
	14	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
	15	* General Public License for more details.
	16	*
	17	* You should have received a copy of the GNU General Public License
	18	* along with this program. If not, see
	19	* <http://www.gnu.org/licenses/>.
	20	*
28 by Teddy Hogeborn * server.conf: New file.	21	* Contact the authors at <mandos@fukt.bsnet.se>.
21 by Teddy Hogeborn * Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and	22	*/
	23
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	24	#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
	25	asprintf() */
24.1.26 by Björn Påhlsson tally count of used symbols	26	#include <stddef.h> /* size_t, NULL */
	27	#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
	28	EXIT_SUCCESS, realloc() */
	29	#include <stdbool.h> /* bool, true, false */
	30	#include <stdio.h> /* perror, popen(), fileno(),
	31	fprintf(), stderr, STDOUT_FILENO */
	32	#include <sys/types.h> /* DIR, opendir(), stat(), struct
	33	stat, waitpid(), WIFEXITED(),
	34	WEXITSTATUS(), wait(), pid_t,
	35	uid_t, gid_t, getuid(), getgid(),
	36	dirfd() */
	37	#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
	38	FD_SET(), FD_ISSET(), FD_CLR */
	39	#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
	40	WEXITSTATUS() */
	41	#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	42	#include <iso646.h> /* and, or, not */
	43	#include <dirent.h> /* DIR, struct dirent, opendir(),
24.1.26 by Björn Påhlsson tally count of used symbols	44	readdir(), closedir(), dirfd() */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	45	#include <unistd.h> /* struct stat, stat(), S_ISREG(),
24.1.26 by Björn Påhlsson tally count of used symbols	46	fcntl(), setuid(), setgid(),
	47	F_GETFD, F_SETFD, FD_CLOEXEC,
	48	access(), pipe(), fork(), close()
	49	dup2, STDOUT_FILENO, _exit(),
	50	execv(), write(), read(),
	51	close() */
	52	#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
	53	FD_CLOEXEC */
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	54	#include <string.h> /* strsep, strlen(), asprintf() */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	55	#include <errno.h> /* errno */
24.1.26 by Björn Påhlsson tally count of used symbols	56	#include <argp.h> /* struct argp_option, struct
	57	argp_state, struct argp,
	58	argp_parse(), ARGP_ERR_UNKNOWN,
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	59	ARGP_KEY_END, ARGP_KEY_ARG,
	60	error_t */
24.1.26 by Björn Påhlsson tally count of used symbols	61	#include <signal.h> /* struct sigaction, sigemptyset(),
	62	sigaddset(), sigaction(),
	63	sigprocmask(), SIG_BLOCK, SIGCHLD,
	64	SIG_UNBLOCK, kill() */
	65	#include <errno.h> /* errno, EBADF */
13 by Björn Påhlsson Added following support:	66
37 by Teddy Hogeborn Non-tested commit for merge purposes.	67	#define BUFFER_SIZE 256
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	68
	69	#define PDIR "/lib/mandos/plugins.d"
	70	#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
37 by Teddy Hogeborn Non-tested commit for merge purposes.	71
74 by Teddy Hogeborn * Makefile (PREFIX, CONFDIR): New.	72	const char *argp_program_version = "plugin-runner 1.0";
24.1.35 by Björn Påhlsson version 1.0	73	const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
24.1.35 by Björn Påhlsson version 1.0	74
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	75	struct plugin;
	76
	77	typedef struct plugin{
	78	char name; / can be NULL or any plugin name */
	79	char **argv;
	80	int argc;
	81	char **environ;
	82	int envc;
	83	bool disabled;
	84
	85	/* Variables used for running processes*/
13 by Björn Påhlsson Added following support:	86	pid_t pid;
	87	int fd;
	88	char *buffer;
21 by Teddy Hogeborn * Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and	89	size_t buffer_size;
	90	size_t buffer_length;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	91	bool eof;
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	92	volatile bool completed;
	93	volatile int status;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	94	struct plugin *next;
	95	} plugin;
	96
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	97	static plugin *plugin_list = NULL;
	98
24.1.90 by Björn Påhlsson fixed two bugs:	99	/* Gets an existing plugin based on name,
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	100	or if none is found, creates a new one */
	101	static plugin getplugin(char name){
	102	/* Check for exiting plugin with that name */
	103	for (plugin *p = plugin_list; p != NULL; p = p->next){
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	104	if ((p->name == name)
	105	or (p->name and name and (strcmp(p->name, name) == 0))){
	106	return p;
	107	}
	108	}
	109	/* Create a new plugin */
	110	plugin *new_plugin = malloc(sizeof(plugin));
	111	if (new_plugin == NULL){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	112	return NULL;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	113	}
24.1.62 by Björn Påhlsson merge + small bugfix	114	char *copy_name = NULL;
	115	if(name != NULL){
	116	copy_name = strdup(name);
98 by Teddy Hogeborn * plugin-runner.c (getplugin): Only copy "name" if not NULL. Free	117	if(copy_name == NULL){
	118	return NULL;
	119	}
24.1.54 by Björn Påhlsson plugin-runner	120	}
24.1.90 by Björn Påhlsson fixed two bugs:	121
24.1.54 by Björn Påhlsson plugin-runner	122	*new_plugin = (plugin) { .name = copy_name,
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	123	.argc = 1,
	124	.disabled = false,
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	125	.next = plugin_list };
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	126
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	127	new_plugin->argv = malloc(sizeof(char ) 2);
	128	if (new_plugin->argv == NULL){
24.1.62 by Björn Påhlsson merge + small bugfix	129	free(copy_name);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	130	free(new_plugin);
	131	return NULL;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	132	}
24.1.54 by Björn Påhlsson plugin-runner	133	new_plugin->argv[0] = copy_name;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	134	new_plugin->argv[1] = NULL;
135 by Teddy Hogeborn * plugin-runner.c (add_environment): Never insert existing environment	135
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	136	new_plugin->environ = malloc(sizeof(char *));
	137	if(new_plugin->environ == NULL){
24.1.62 by Björn Påhlsson merge + small bugfix	138	free(copy_name);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	139	free(new_plugin->argv);
	140	free(new_plugin);
	141	return NULL;
	142	}
	143	new_plugin->environ[0] = NULL;
135 by Teddy Hogeborn * plugin-runner.c (add_environment): Never insert existing environment	144
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	145	/* Append the new plugin to the list */
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	146	plugin_list = new_plugin;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	147	return new_plugin;
	148	}
	149
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	150	/* Helper function for add_argument and add_environment */
	151	static bool add_to_char_array(const char new, char **array,
	152	int *len){
	153	/* Resize the pointed-to array to hold one more pointer */
	154	array = realloc(array, sizeof(char *)
	155	* (size_t) ((*len) + 2));
	156	/* Malloc check */
	157	if(*array == NULL){
	158	return false;
	159	}
	160	/* Make a copy of the new string */
	161	char *copy = strdup(new);
	162	if(copy == NULL){
	163	return false;
	164	}
	165	/* Insert the copy */
	166	(array)[len] = copy;
	167	(*len)++;
	168	/* Add a new terminating NULL pointer to the last element */
	169	(array)[len] = NULL;
	170	return true;
	171	}
	172
	173	/* Add to a plugin's argument vector */
	174	static bool add_argument(plugin p, const char arg){
	175	if(p == NULL){
	176	return false;
	177	}
	178	return add_to_char_array(arg, &(p->argv), &(p->argc));
	179	}
	180
	181	/* Add to a plugin's environment */
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	182	static bool add_environment(plugin p, const char def, bool replace){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	183	if(p == NULL){
	184	return false;
	185	}
135 by Teddy Hogeborn * plugin-runner.c (add_environment): Never insert existing environment	186	/* namelen = length of name of environment variable */
	187	size_t namelen = (size_t)(strchrnul(def, '=') - def);
	188	/* Search for this environment variable */
	189	for(char *e = p->environ; e != NULL; e++){
24.1.90 by Björn Påhlsson fixed two bugs:	190	if(strncmp(*e, def, namelen + 1) == 0){
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	191	/* It already exists */
	192	if(replace){
24.1.90 by Björn Påhlsson fixed two bugs:	193	char new = realloc(e, strlen(def) + 1);
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	194	if(new == NULL){
	195	return false;
	196	}
	197	*e = new;
	198	strcpy(*e, def);
	199	}
135 by Teddy Hogeborn * plugin-runner.c (add_environment): Never insert existing environment	200	return true;
	201	}
	202	}
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	203	return add_to_char_array(def, &(p->environ), &(p->envc));
	204	}
	205
32 by Teddy Hogeborn * plugins.d/plugbasedclient.c (set_cloexec_flag): New function.	206	/*
	207	* Based on the example in the GNU LibC manual chapter 13.13 "File
	208	* Descriptor Flags".
	209	* *Note File Descriptor Flags:(libc)Descriptor Flags.
	210	*/
37 by Teddy Hogeborn Non-tested commit for merge purposes.	211	static int set_cloexec_flag(int fd)
32 by Teddy Hogeborn * plugins.d/plugbasedclient.c (set_cloexec_flag): New function.	212	{
	213	int ret = fcntl(fd, F_GETFD, 0);
	214	/* If reading the flags failed, return error indication now. */
	215	if(ret < 0){
	216	return ret;
	217	}
	218	/* Store modified flag word in the descriptor. */
	219	return fcntl(fd, F_SETFD, ret \| FD_CLOEXEC);
	220	}
	221
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	222
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	223	/* Mark processes as completed when they exit, and save their exit
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	224	status. */
	225	void handle_sigchld(__attribute__((unused)) int sig){
24.1.65 by Björn Påhlsson * plugin-runner.c (handle_sigchld): Loop until all exited children	226	while(true){
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	227	plugin *proc = plugin_list;
24.1.65 by Björn Påhlsson * plugin-runner.c (handle_sigchld): Loop until all exited children	228	int status;
	229	pid_t pid = waitpid(-1, &status, WNOHANG);
	230	if(pid == 0){
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	231	/* Only still running child processes */
24.1.65 by Björn Påhlsson * plugin-runner.c (handle_sigchld): Loop until all exited children	232	break;
	233	}
	234	if(pid == -1){
	235	if (errno != ECHILD){
	236	perror("waitpid");
	237	}
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	238	/* No child processes */
	239	break;
24.1.65 by Björn Påhlsson * plugin-runner.c (handle_sigchld): Loop until all exited children	240	}
24.1.90 by Björn Påhlsson fixed two bugs:	241
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	242	/* A child exited, find it in process_list */
24.1.65 by Björn Påhlsson * plugin-runner.c (handle_sigchld): Loop until all exited children	243	while(proc != NULL and proc->pid != pid){
	244	proc = proc->next;
	245	}
	246	if(proc == NULL){
	247	/* Process not found in process list */
	248	continue;
	249	}
	250	proc->status = status;
	251	proc->completed = true;
	252	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	253	}
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	254
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	255	/* Prints out a password to stdout */
24.1.42 by Björn Påhlsson Added fallback to mandos-client	256	bool print_out_password(const char *buffer, size_t length){
64 by Teddy Hogeborn * mandos-client.c (print_out_password): Strip trailing '\n'.	257	ssize_t ret;
	258	for(size_t written = 0; written < length; written += (size_t)ret){
24.1.42 by Björn Påhlsson Added fallback to mandos-client	259	ret = TEMP_FAILURE_RETRY(write(STDOUT_FILENO, buffer + written,
	260	length - written));
	261	if(ret < 0){
	262	return false;
	263	}
	264	}
	265	return true;
	266	}
	267
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	268	/* Removes and free a plugin from the plugin list */
	269	static void free_plugin(plugin *plugin_node){
	270
	271	for(char *arg = plugin_node->argv; arg != NULL; arg++){
	272	free(*arg);
	273	}
	274	free(plugin_node->argv);
	275	for(char *env = plugin_node->environ; env != NULL; env++){
	276	free(*env);
	277	}
	278	free(plugin_node->environ);
	279	free(plugin_node->buffer);
	280
	281	/* Removes the plugin from the singly-linked list */
	282	if(plugin_node == plugin_list){
	283	/* First one - simple */
	284	plugin_list = plugin_list->next;
	285	} else {
	286	/* Second one or later */
	287	for(plugin *p = plugin_list; p != NULL; p = p->next){
	288	if(p->next == plugin_node){
	289	p->next = plugin_node->next;
	290	break;
	291	}
	292	}
	293	}
	294
	295	free(plugin_node);
	296	}
	297
	298	static void free_plugin_list(void){
	299	while(plugin_list != NULL){
	300	free_plugin(plugin_list);
98 by Teddy Hogeborn * plugin-runner.c (getplugin): Only copy "name" if not NULL. Free	301	}
24.1.54 by Björn Påhlsson plugin-runner	302	}
24.1.54 by Björn Påhlsson plugin-runner	303
13 by Björn Påhlsson Added following support:	304	int main(int argc, char *argv[]){
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	305	char *plugindir = NULL;
	306	char *argfile = NULL;
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	307	FILE *conffp;
24.1.5 by Björn Påhlsson plugbasedclient:	308	size_t d_name_len;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	309	DIR *dir = NULL;
13 by Björn Påhlsson Added following support:	310	struct dirent *dirst;
13 by Björn Påhlsson Added following support:	311	struct stat st;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	312	fd_set rfds_all;
13 by Björn Påhlsson Added following support:	313	int ret, maxfd = 0;
24.1.6 by Björn Påhlsson plugbasedclient	314	uid_t uid = 65534;
24.1.6 by Björn Påhlsson plugbasedclient	315	gid_t gid = 65534;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	316	bool debug = false;
	317	int exitstatus = EXIT_SUCCESS;
24.1.7 by Björn Påhlsson merge	318	struct sigaction old_sigchld_action;
	319	struct sigaction sigchld_action = { .sa_handler = handle_sigchld,
	320	.sa_flags = SA_NOCLDSTOP };
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	321	char **custom_argv = NULL;
	322	int custom_argc = 0;
	323
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	324	/* Establish a signal handler */
	325	sigemptyset(&sigchld_action.sa_mask);
	326	ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
24.1.54 by Björn Påhlsson plugin-runner	327	if(ret == -1){
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	328	perror("sigaddset");
24.1.54 by Björn Påhlsson plugin-runner	329	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	330	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	331	}
	332	ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
24.1.54 by Björn Påhlsson plugin-runner	333	if(ret == -1){
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	334	perror("sigaction");
98 by Teddy Hogeborn * plugin-runner.c (getplugin): Only copy "name" if not NULL. Free	335	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	336	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	337	}
	338
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	339	/* The options we understand. */
	340	struct argp_option options[] = {
	341	{ .name = "global-options", .key = 'g',
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	342	.arg = "OPTION[,OPTION[,...]]",
	343	.doc = "Options passed to all plugins" },
138 by Teddy Hogeborn * plugin-runner.c: Changed short option for "--global-env" to "-G",	344	{ .name = "global-env", .key = 'G',
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	345	.arg = "VAR=value",
	346	.doc = "Environment variable passed to all plugins" },
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	347	{ .name = "options-for", .key = 'o',
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	348	.arg = "PLUGIN:OPTION[,OPTION[,...]]",
	349	.doc = "Options passed only to specified plugin" },
138 by Teddy Hogeborn * plugin-runner.c: Changed short option for "--global-env" to "-G",	350	{ .name = "env-for", .key = 'E',
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	351	.arg = "PLUGIN:ENV=value",
	352	.doc = "Environment variable passed to specified plugin" },
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	353	{ .name = "disable", .key = 'd',
	354	.arg = "PLUGIN",
	355	.doc = "Disable a specific plugin", .group = 1 },
138 by Teddy Hogeborn * plugin-runner.c: Changed short option for "--global-env" to "-G",	356	{ .name = "enable", .key = 'e',
	357	.arg = "PLUGIN",
	358	.doc = "Enable a specific plugin", .group = 1 },
24.1.5 by Björn Påhlsson plugbasedclient:	359	{ .name = "plugin-dir", .key = 128,
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	360	.arg = "DIRECTORY",
	361	.doc = "Specify a different plugin directory", .group = 2 },
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	362	{ .name = "config-file", .key = 129,
	363	.arg = "FILE",
	364	.doc = "Specify a different configuration file", .group = 2 },
	365	{ .name = "userid", .key = 130,
	366	.arg = "ID", .flags = 0,
	367	.doc = "User ID the plugins will run as", .group = 3 },
	368	{ .name = "groupid", .key = 131,
	369	.arg = "ID", .flags = 0,
	370	.doc = "Group ID the plugins will run as", .group = 3 },
	371	{ .name = "debug", .key = 132,
	372	.doc = "Debug mode", .group = 4 },
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	373	{ .name = NULL }
	374	};
	375
133 by Teddy Hogeborn * plugin-runner.c: Break a couple of long lines.	376	error_t parse_opt (int key, char *arg, __attribute__((unused))
	377	struct argp_state *state) {
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	378	switch (key) {
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	379	case 'g': /* --global-options */
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	380	if (arg != NULL){
24.1.50 by Björn Påhlsson changed from using strtok to strsep	381	char *p;
	382	while((p = strsep(&arg, ",")) != NULL){
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	383	if(p[0] == '\0'){
24.1.50 by Björn Påhlsson changed from using strtok to strsep	384	continue;
	385	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	386	if(not add_argument(getplugin(NULL), p)){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	387	perror("add_argument");
	388	return ARGP_ERR_UNKNOWN;
	389	}
	390	}
	391	}
	392	break;
138 by Teddy Hogeborn * plugin-runner.c: Changed short option for "--global-env" to "-G",	393	case 'G': /* --global-env */
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	394	if(arg == NULL){
	395	break;
	396	}
24.1.92 by Björn Påhlsson Several memory leaks detected by valgrind fixed	397	if(not add_environment(getplugin(NULL), arg, true)){
	398	perror("add_environment");
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	399	}
	400	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	401	case 'o': /* --options-for */
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	402	if (arg != NULL){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	403	char *p_name = strsep(&arg, ":");
24.1.90 by Björn Påhlsson fixed two bugs:	404	if(p_name[0] == '\0' or arg == NULL){
24.1.50 by Björn Påhlsson changed from using strtok to strsep	405	break;
	406	}
	407	char *opt = strsep(&arg, ":");
24.1.90 by Björn Påhlsson fixed two bugs:	408	if(opt[0] == '\0' or opt == NULL){
24.1.50 by Björn Påhlsson changed from using strtok to strsep	409	break;
	410	}
24.1.90 by Björn Påhlsson fixed two bugs:	411	char *p;
	412	while((p = strsep(&opt, ",")) != NULL){
	413	if(p[0] == '\0'){
	414	continue;
	415	}
	416	if(not add_argument(getplugin(p_name), p)){
	417	perror("add_argument");
	418	return ARGP_ERR_UNKNOWN;
24.1.50 by Björn Påhlsson changed from using strtok to strsep	419	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	420	}
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	421	}
	422	break;
138 by Teddy Hogeborn * plugin-runner.c: Changed short option for "--global-env" to "-G",	423	case 'E': /* --env-for */
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	424	if(arg == NULL){
	425	break;
	426	}
	427	{
	428	char *envdef = strchr(arg, ':');
	429	if(envdef == NULL){
	430	break;
	431	}
24.1.92 by Björn Påhlsson Several memory leaks detected by valgrind fixed	432	*envdef = '\0';
	433	if(not add_environment(getplugin(arg), envdef+1, true)){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	434	perror("add_environment");
	435	}
	436	}
	437	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	438	case 'd': /* --disable */
24.1.5 by Björn Påhlsson plugbasedclient:	439	if (arg != NULL){
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	440	plugin *p = getplugin(arg);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	441	if(p == NULL){
	442	return ARGP_ERR_UNKNOWN;
	443	}
	444	p->disabled = true;
24.1.5 by Björn Påhlsson plugbasedclient:	445	}
24.1.5 by Björn Påhlsson plugbasedclient:	446	break;
138 by Teddy Hogeborn * plugin-runner.c: Changed short option for "--global-env" to "-G",	447	case 'e': /* --enable */
	448	if (arg != NULL){
	449	plugin *p = getplugin(arg);
	450	if(p == NULL){
	451	return ARGP_ERR_UNKNOWN;
	452	}
	453	p->disabled = false;
	454	}
	455	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	456	case 128: /* --plugin-dir */
24.1.92 by Björn Påhlsson Several memory leaks detected by valgrind fixed	457	free(plugindir);
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	458	plugindir = strdup(arg);
	459	if(plugindir == NULL){
	460	perror("strdup");
	461	}
24.1.5 by Björn Påhlsson plugbasedclient:	462	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	463	case 129: /* --config-file */
137 by Teddy Hogeborn * plugin-runner.c (main/parse_opt): Removed code for "--config-file".	464	/* This is already done by parse_opt_config_file() */
	465	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	466	case 130: /* --userid */
24.1.6 by Björn Påhlsson plugbasedclient	467	uid = (uid_t)strtol(arg, NULL, 10);
24.1.6 by Björn Påhlsson plugbasedclient	468	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	469	case 131: /* --groupid */
24.1.6 by Björn Påhlsson plugbasedclient	470	gid = (gid_t)strtol(arg, NULL, 10);
24.1.6 by Björn Påhlsson plugbasedclient	471	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	472	case 132: /* --debug */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	473	debug = true;
	474	break;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	475	case ARGP_KEY_ARG:
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	476	fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	477	break;
	478	case ARGP_KEY_END:
	479	break;
	480	default:
	481	return ARGP_ERR_UNKNOWN;
	482	}
	483	return 0;
	484	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	485
137 by Teddy Hogeborn * plugin-runner.c (main/parse_opt): Removed code for "--config-file".	486	/* This option parser is the same as parse_opt() above, except it
	487	ignores everything but the --config-file option. */
	488	error_t parse_opt_config_file (int key, char *arg,
	489	__attribute__((unused))
	490	struct argp_state *state) {
	491	switch (key) {
	492	case 'g': /* --global-options */
138 by Teddy Hogeborn * plugin-runner.c: Changed short option for "--global-env" to "-G",	493	case 'G': /* --global-env */
137 by Teddy Hogeborn * plugin-runner.c (main/parse_opt): Removed code for "--config-file".	494	case 'o': /* --options-for */
138 by Teddy Hogeborn * plugin-runner.c: Changed short option for "--global-env" to "-G",	495	case 'E': /* --env-for */
137 by Teddy Hogeborn * plugin-runner.c (main/parse_opt): Removed code for "--config-file".	496	case 'd': /* --disable */
138 by Teddy Hogeborn * plugin-runner.c: Changed short option for "--global-env" to "-G",	497	case 'e': /* --enable */
137 by Teddy Hogeborn * plugin-runner.c (main/parse_opt): Removed code for "--config-file".	498	case 128: /* --plugin-dir */
	499	break;
	500	case 129: /* --config-file */
24.1.92 by Björn Påhlsson Several memory leaks detected by valgrind fixed	501	free(argfile);
137 by Teddy Hogeborn * plugin-runner.c (main/parse_opt): Removed code for "--config-file".	502	argfile = strdup(arg);
	503	if(argfile == NULL){
	504	perror("strdup");
	505	}
	506	break;
	507	case 130: /* --userid */
	508	case 131: /* --groupid */
	509	case 132: /* --debug */
	510	case ARGP_KEY_ARG:
	511	case ARGP_KEY_END:
	512	break;
	513	default:
	514	return ARGP_ERR_UNKNOWN;
	515	}
	516	return 0;
	517	}
	518
	519	struct argp argp = { .options = options,
	520	.parser = parse_opt_config_file,
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	521	.args_doc = "",
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	522	.doc = "Mandos plugin runner -- Run plugins" };
	523
137 by Teddy Hogeborn * plugin-runner.c (main/parse_opt): Removed code for "--config-file".	524	/* Parse using the parse_opt_config_file in order to get the custom
	525	config file location, if any. */
	526	ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
	527	if (ret == ARGP_ERR_UNKNOWN){
	528	fprintf(stderr, "Unknown error while parsing arguments\n");
	529	exitstatus = EXIT_FAILURE;
	530	goto fallback;
	531	}
	532
	533	/* Reset to the normal argument parser */
	534	argp.parser = parse_opt;
	535
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	536	/* Open the configfile if available */
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	537	if (argfile == NULL){
	538	conffp = fopen(AFILE, "r");
	539	} else {
	540	conffp = fopen(argfile, "r");
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	541	}
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	542	if(conffp != NULL){
	543	char *org_line = NULL;
24.1.54 by Björn Påhlsson plugin-runner	544	char p, arg, new_arg, line;
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	545	size_t size = 0;
	546	ssize_t sret;
	547	const char whitespace_delims[] = " \r\t\f\v\n";
	548	const char comment_delim[] = "#";
	549
24.1.67 by Björn Påhlsson transformed a function to a part of main	550	custom_argc = 1;
	551	custom_argv = malloc(sizeof(char) 2);
	552	if(custom_argv == NULL){
	553	perror("malloc");
	554	exitstatus = EXIT_FAILURE;
	555	goto fallback;
	556	}
	557	custom_argv[0] = argv[0];
	558	custom_argv[1] = NULL;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	559
133 by Teddy Hogeborn * plugin-runner.c: Break a couple of long lines.	560	/* for each line in the config file, strip whitespace and ignore
	561	commented text */
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	562	while(true){
	563	sret = getline(&org_line, &size, conffp);
	564	if(sret == -1){
	565	break;
	566	}
	567
	568	line = org_line;
	569	arg = strsep(&line, comment_delim);
	570	while((p = strsep(&arg, whitespace_delims)) != NULL){
	571	if(p[0] == '\0'){
	572	continue;
	573	}
	574	new_arg = strdup(p);
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	575	if(new_arg == NULL){
	576	perror("strdup");
	577	exitstatus = EXIT_FAILURE;
	578	free(org_line);
	579	goto fallback;
	580	}
	581
24.1.67 by Björn Påhlsson transformed a function to a part of main	582	custom_argc += 1;
	583	custom_argv = realloc(custom_argv, sizeof(char *)
	584	* ((unsigned int) custom_argc + 1));
	585	if(custom_argv == NULL){
	586	perror("realloc");
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	587	exitstatus = EXIT_FAILURE;
24.1.67 by Björn Påhlsson transformed a function to a part of main	588	free(org_line);
24.1.54 by Björn Påhlsson plugin-runner	589	goto fallback;
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	590	}
24.1.67 by Björn Påhlsson transformed a function to a part of main	591	custom_argv[custom_argc-1] = new_arg;
	592	custom_argv[custom_argc] = NULL;
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	593	}
	594	}
	595	free(org_line);
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	596	} else {
24.1.52 by Björn Påhlsson merge + minor adjustments	597	/* Check for harmful errors and go to fallback. Other errors might
24.1.52 by Björn Påhlsson merge + minor adjustments	598	not affect opening plugins */
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	599	if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
	600	perror("fopen");
24.1.8 by Björn Påhlsson plugbasedclient	601	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	602	goto fallback;
24.1.8 by Björn Påhlsson plugbasedclient	603	}
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	604	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	605	/* If there was any arguments from configuration file,
	606	pass them to parser as command arguments */
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	607	if(custom_argv != NULL){
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	608	ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
	609	0, NULL);
24.1.26 by Björn Påhlsson tally count of used symbols	610	if (ret == ARGP_ERR_UNKNOWN){
64 by Teddy Hogeborn * mandos-client.c (print_out_password): Strip trailing '\n'.	611	fprintf(stderr, "Unknown error while parsing arguments\n");
24.1.26 by Björn Påhlsson tally count of used symbols	612	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	613	goto fallback;
24.1.26 by Björn Påhlsson tally count of used symbols	614	}
24.1.8 by Björn Påhlsson plugbasedclient	615	}
24.1.8 by Björn Påhlsson plugbasedclient	616
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	617	/* Parse actual command line arguments, to let them override the
	618	config file */
	619	ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
	620	if (ret == ARGP_ERR_UNKNOWN){
	621	fprintf(stderr, "Unknown error while parsing arguments\n");
	622	exitstatus = EXIT_FAILURE;
	623	goto fallback;
	624	}
	625
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	626	if(debug){
	627	for(plugin *p = plugin_list; p != NULL; p=p->next){
	628	fprintf(stderr, "Plugin: %s has %d arguments\n",
32 by Teddy Hogeborn * plugins.d/plugbasedclient.c (set_cloexec_flag): New function.	629	p->name ? p->name : "Global", p->argc - 1);
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	630	for(char *a = p->argv; a != NULL; a++){
	631	fprintf(stderr, "\tArg: %s\n", *a);
	632	}
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	633	fprintf(stderr, "...and %u environment variables\n", p->envc);
	634	for(char *a = p->environ; a != NULL; a++){
	635	fprintf(stderr, "\t%s\n", *a);
	636	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	637	}
	638	}
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	639
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	640	/* Strip permissions down to nobody */
24.1.6 by Björn Påhlsson plugbasedclient	641	ret = setuid(uid);
	642	if (ret == -1){
	643	perror("setuid");
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	644	}
24.1.6 by Björn Påhlsson plugbasedclient	645	setgid(gid);
24.1.6 by Björn Påhlsson plugbasedclient	646	if (ret == -1){
39 by Teddy Hogeborn * plugins.d/mandosclient.c (pgp_packet_decrypt): Renamed variables.	647	perror("setgid");
24.1.6 by Björn Påhlsson plugbasedclient	648	}
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	649
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	650	if (plugindir == NULL){
	651	dir = opendir(PDIR);
	652	} else {
	653	dir = opendir(plugindir);
	654	}
24.1.6 by Björn Påhlsson plugbasedclient	655
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	656	if(dir == NULL){
	657	perror("Could not open plugin dir");
	658	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	659	goto fallback;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	660	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	661
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	662	/* Set the FD_CLOEXEC flag on the directory, if possible */
	663	{
	664	int dir_fd = dirfd(dir);
	665	if(dir_fd >= 0){
	666	ret = set_cloexec_flag(dir_fd);
	667	if(ret < 0){
	668	perror("set_cloexec_flag");
	669	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	670	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	671	}
	672	}
	673	}
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	674
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	675	FD_ZERO(&rfds_all);
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	676
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	677	/* Read and execute any executable in the plugin directory*/
13 by Björn Påhlsson Added following support:	678	while(true){
	679	dirst = readdir(dir);
	680
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	681	/* All directory entries have been processed */
13 by Björn Påhlsson Added following support:	682	if(dirst == NULL){
24.1.26 by Björn Påhlsson tally count of used symbols	683	if (errno == EBADF){
	684	perror("readdir");
	685	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	686	goto fallback;
24.1.26 by Björn Påhlsson tally count of used symbols	687	}
13 by Björn Påhlsson Added following support:	688	break;
	689	}
	690
	691	d_name_len = strlen(dirst->d_name);
	692
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	693	/* Ignore dotfiles, backup files and other junk */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	694	{
	695	bool bad_name = false;
	696
	697	const char const *bad_prefixes[] = { ".", "#", NULL };
	698
	699	const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
	700	".dpkg-old",
	701	".dpkg-divert", NULL };
	702	for(const char *pre = bad_prefixes; pre != NULL; pre++){
	703	size_t pre_len = strlen(*pre);
	704	if((d_name_len >= pre_len)
	705	and strncmp((dirst->d_name), *pre, pre_len) == 0){
	706	if(debug){
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	707	fprintf(stderr, "Ignoring plugin dir entry \"%s\""
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	708	" with bad prefix %s\n", dirst->d_name, *pre);
	709	}
	710	bad_name = true;
	711	break;
	712	}
	713	}
	714	if(bad_name){
	715	continue;
	716	}
	717	for(const char *suf = bad_suffixes; suf != NULL; suf++){
	718	size_t suf_len = strlen(*suf);
	719	if((d_name_len >= suf_len)
	720	and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
	721	== 0)){
	722	if(debug){
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	723	fprintf(stderr, "Ignoring plugin dir entry \"%s\""
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	724	" with bad suffix %s\n", dirst->d_name, *suf);
	725	}
	726	bad_name = true;
	727	break;
	728	}
	729	}
	730
	731	if(bad_name){
	732	continue;
	733	}
13 by Björn Påhlsson Added following support:	734	}
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	735
	736	char *filename;
169 by Teddy Hogeborn * plugin-runner.c (main): Bug fix: use built-in default value if	737	if(plugindir == NULL){
	738	ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
	739	} else {
	740	ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
	741	}
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	742	if(ret < 0){
	743	perror("asprintf");
24.1.46 by Björn Påhlsson mandos-client	744	continue;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	745	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	746
24.1.26 by Björn Påhlsson tally count of used symbols	747	ret = stat(filename, &st);
	748	if (ret == -1){
	749	perror("stat");
24.1.46 by Björn Påhlsson mandos-client	750	free(filename);
24.1.46 by Björn Påhlsson mandos-client	751	continue;
24.1.26 by Björn Påhlsson tally count of used symbols	752	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	753
	754	/* Ignore non-executable files */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	755	if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
	756	if(debug){
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	757	fprintf(stderr, "Ignoring plugin dir entry \"%s\""
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	758	" with bad type or mode\n", filename);
	759	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	760	free(filename);
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	761	continue;
	762	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	763
	764	plugin *p = getplugin(dirst->d_name);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	765	if(p == NULL){
	766	perror("getplugin");
	767	free(filename);
	768	continue;
	769	}
	770	if(p->disabled){
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	771	if(debug){
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	772	fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	773	dirst->d_name);
	774	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	775	free(filename);
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	776	continue;
	777	}
32 by Teddy Hogeborn * plugins.d/plugbasedclient.c (set_cloexec_flag): New function.	778	{
	779	/* Add global arguments to argument list for this plugin */
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	780	plugin *g = getplugin(NULL);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	781	if(g != NULL){
	782	for(char *a = g->argv + 1; a != NULL; a++){
	783	if(not add_argument(p, *a)){
	784	perror("add_argument");
	785	}
	786	}
	787	/* Add global environment variables */
	788	for(char *e = g->environ; e != NULL; e++){
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	789	if(not add_environment(p, *e, false)){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	790	perror("add_environment");
	791	}
	792	}
	793	}
	794	}
	795	/* If this plugin has any environment variables, we will call
	796	using execve and need to duplicate the environment from this
	797	process, too. */
	798	if(p->environ[0] != NULL){
	799	for(char *e = environ; e != NULL; e++){
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	800	if(not add_environment(p, *e, false)){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	801	perror("add_environment");
	802	}
	803	}
	804	}
	805
98 by Teddy Hogeborn * plugin-runner.c (getplugin): Only copy "name" if not NULL. Free	806	int pipefd[2];
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	807	ret = pipe(pipefd);
	808	if (ret == -1){
	809	perror("pipe");
	810	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	811	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	812	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	813	/* Ask OS to automatic close the pipe on exec */
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	814	ret = set_cloexec_flag(pipefd[0]);
	815	if(ret < 0){
	816	perror("set_cloexec_flag");
	817	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	818	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	819	}
	820	ret = set_cloexec_flag(pipefd[1]);
	821	if(ret < 0){
	822	perror("set_cloexec_flag");
	823	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	824	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	825	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	826	/* Block SIGCHLD until process is safely in process list */
	827	ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
	828	if(ret < 0){
	829	perror("sigprocmask");
	830	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	831	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	832	}
136 by Teddy Hogeborn * plugin-runner.c (add_environment): Override existing environment	833	/* Starting a new process to be watched */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	834	pid_t pid = fork();
24.1.46 by Björn Påhlsson mandos-client	835	if(pid == -1){
	836	perror("fork");
	837	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	838	goto fallback;
24.1.46 by Björn Påhlsson mandos-client	839	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	840	if(pid == 0){
	841	/* this is the child process */
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	842	ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
	843	if(ret < 0){
	844	perror("sigaction");
	845	_exit(EXIT_FAILURE);
	846	}
	847	ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
	848	if(ret < 0){
	849	perror("sigprocmask");
	850	_exit(EXIT_FAILURE);
	851	}
24.1.26 by Björn Påhlsson tally count of used symbols	852
	853	ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
	854	if(ret == -1){
	855	perror("dup2");
	856	_exit(EXIT_FAILURE);
	857	}
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	858
	859	if(dirfd(dir) < 0){
	860	/* If dir has no file descriptor, we could not set FD_CLOEXEC
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	861	above and must now close it manually here. */
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	862	closedir(dir);
33 by Teddy Hogeborn * plugins.d/plugbasedclient.c (main): Close the pipe fd after dup2:ing	863	}
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	864	if(p->environ[0] == NULL){
	865	if(execv(filename, p->argv) < 0){
	866	perror("execv");
	867	_exit(EXIT_FAILURE);
	868	}
	869	} else {
	870	if(execve(filename, p->argv, p->environ) < 0){
	871	perror("execve");
	872	_exit(EXIT_FAILURE);
	873	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	874	}
	875	/* no return */
	876	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	877	/* Parent process */
	878	close(pipefd[1]); /* Close unused write end of pipe */
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	879	free(filename);
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	880	plugin *new_plugin = getplugin(dirst->d_name);
	881	if (new_plugin == NULL){
	882	perror("getplugin");
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	883	ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
	884	if(ret < 0){
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	885	perror("sigprocmask");
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	886	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	887	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	888	goto fallback;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	889	}
	890
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	891	new_plugin->pid = pid;
	892	new_plugin->fd = pipefd[0];
	893
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	894	/* Unblock SIGCHLD so signal handler can be run if this process
	895	has already completed */
	896	ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
	897	if(ret < 0){
	898	perror("sigprocmask");
	899	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	900	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	901	}
	902
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	903	FD_SET(new_plugin->fd, &rfds_all);
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	904
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	905	if (maxfd < new_plugin->fd){
	906	maxfd = new_plugin->fd;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	907	}
	908
13 by Björn Påhlsson Added following support:	909	}
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	910
13 by Björn Påhlsson Added following support:	911	closedir(dir);
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	912	dir = NULL;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	913
	914	for(plugin *p = plugin_list; p != NULL; p = p->next){
	915	if(p->pid != 0){
	916	break;
	917	}
	918	if(p->next == NULL){
	919	fprintf(stderr, "No plugin processes started. Incorrect plugin"
	920	" directory?\n");
	921	free_plugin_list();
	922	}
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	923	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	924
	925	/* Main loop while running plugins exist */
	926	while(plugin_list){
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	927	fd_set rfds = rfds_all;
	928	int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
	929	if (select_ret == -1){
	930	perror("select");
	931	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	932	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	933	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	934	/* OK, now either a process completed, or something can be read
	935	from one of them */
24.1.92 by Björn Påhlsson Several memory leaks detected by valgrind fixed	936	for(plugin *proc = plugin_list; proc != NULL;){
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	937	/* Is this process completely done? */
	938	if(proc->eof and proc->completed){
	939	/* Only accept the plugin output if it exited cleanly */
	940	if(not WIFEXITED(proc->status)
	941	or WEXITSTATUS(proc->status) != 0){
	942	/* Bad exit by plugin */
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	943
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	944	if(debug){
	945	if(WIFEXITED(proc->status)){
60 by Teddy Hogeborn * mandos-client.c (main): Cast pid_t to unsigned int before printing.	946	fprintf(stderr, "Plugin %u exited with status %d\n",
	947	(unsigned int) (proc->pid),
	948	WEXITSTATUS(proc->status));
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	949	} else if(WIFSIGNALED(proc->status)) {
60 by Teddy Hogeborn * mandos-client.c (main): Cast pid_t to unsigned int before printing.	950	fprintf(stderr, "Plugin %u killed by signal %d\n",
	951	(unsigned int) (proc->pid),
	952	WTERMSIG(proc->status));
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	953	} else if(WCOREDUMP(proc->status)){
60 by Teddy Hogeborn * mandos-client.c (main): Cast pid_t to unsigned int before printing.	954	fprintf(stderr, "Plugin %d dumped core\n",
	955	(unsigned int) (proc->pid));
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	956	}
	957	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	958
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	959	/* Remove the plugin */
	960	FD_CLR(proc->fd, &rfds_all);
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	961
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	962	/* Block signal while modifying process_list */
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	963	ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	964	if(ret < 0){
	965	perror("sigprocmask");
	966	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	967	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	968	}
24.1.92 by Björn Påhlsson Several memory leaks detected by valgrind fixed	969
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	970	/* We are done modifying process list, so unblock signal */
	971	ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
	972	NULL);
	973	if(ret < 0){
	974	perror("sigprocmask");
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	975	exitstatus = EXIT_FAILURE;
	976	goto fallback;
	977	}
	978
	979	if(plugin_list == NULL){
	980	break;
	981	}
24.1.92 by Björn Påhlsson Several memory leaks detected by valgrind fixed	982
	983	plugin *next_plugin = proc->next;
	984	free_plugin(proc);
	985	proc = next_plugin;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	986	continue;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	987	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	988
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	989	/* This process exited nicely, so print its buffer */
24.1.42 by Björn Påhlsson Added fallback to mandos-client	990
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	991	bool bret = print_out_password(proc->buffer,
	992	proc->buffer_length);
24.1.42 by Björn Påhlsson Added fallback to mandos-client	993	if(not bret){
	994	perror("print_out_password");
	995	exitstatus = EXIT_FAILURE;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	996	}
24.1.54 by Björn Påhlsson plugin-runner	997	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	998	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	999
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1000	/* This process has not completed. Does it have any output? */
	1001	if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
	1002	/* This process had nothing to say at this time */
24.1.92 by Björn Påhlsson Several memory leaks detected by valgrind fixed	1003	proc = proc->next;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	1004	continue;
	1005	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1006	/* Before reading, make the process' data buffer large enough */
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	1007	if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
	1008	proc->buffer = realloc(proc->buffer, proc->buffer_size
	1009	+ (size_t) BUFFER_SIZE);
	1010	if (proc->buffer == NULL){
	1011	perror("malloc");
	1012	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	1013	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	1014	}
	1015	proc->buffer_size += BUFFER_SIZE;
	1016	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1017	/* Read from the process */
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	1018	ret = read(proc->fd, proc->buffer + proc->buffer_length,
	1019	BUFFER_SIZE);
	1020	if(ret < 0){
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1021	/* Read error from this process; ignore the error */
24.1.92 by Björn Påhlsson Several memory leaks detected by valgrind fixed	1022	proc = proc->next;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	1023	continue;
	1024	}
	1025	if(ret == 0){
	1026	/* got EOF */
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1027	proc->eof = true;
	1028	} else {
	1029	proc->buffer_length += (size_t) ret;
13 by Björn Påhlsson Added following support:	1030	}
	1031	}
	1032	}
24.1.45 by Björn Påhlsson Fixed fallback on error in mandos-client	1033
	1034
24.1.54 by Björn Påhlsson plugin-runner	1035	fallback:
24.1.42 by Björn Påhlsson Added fallback to mandos-client	1036
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	1037	if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	1038	/* Fallback if all plugins failed, none are found or an error
	1039	occured */
24.1.42 by Björn Påhlsson Added fallback to mandos-client	1040	bool bret;
	1041	fprintf(stderr, "Going to fallback mode using getpass(3)\n");
	1042	char *passwordbuffer = getpass("Password: ");
168 by Teddy Hogeborn * initramfs-tools-hook: Use long options where available. Use only	1043	size_t len = strlen(passwordbuffer);
	1044	/* Strip trailing newline */
	1045	if(len > 0 and passwordbuffer[len-1] == '\n'){
	1046	passwordbuffer[len-1] = '\0'; /* not strictly necessary */
	1047	len--;
	1048	}
	1049	bret = print_out_password(passwordbuffer, len);
24.1.42 by Björn Påhlsson Added fallback to mandos-client	1050	if(not bret){
	1051	perror("print_out_password");
	1052	exitstatus = EXIT_FAILURE;
	1053	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1054	}
24.1.42 by Björn Påhlsson Added fallback to mandos-client	1055
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1056	/* Restore old signal handler */
24.1.54 by Björn Påhlsson plugin-runner	1057	ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
	1058	if(ret == -1){
	1059	perror("sigaction");
	1060	exitstatus = EXIT_FAILURE;
	1061	}
	1062
	1063	if(custom_argv != NULL){
24.1.67 by Björn Påhlsson transformed a function to a part of main	1064	for(char *arg = custom_argv+1; arg != NULL; arg++){
24.1.54 by Björn Påhlsson plugin-runner	1065	free(*arg);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	1066	}
24.1.54 by Björn Påhlsson plugin-runner	1067	free(custom_argv);
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1068	}
	1069
	1070	if(dir != NULL){
	1071	closedir(dir);
	1072	}
	1073
	1074	/* Free the process list and kill the processes */
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	1075	for(plugin *p = plugin_list; p != NULL; p = p->next){
	1076	if(p->pid != 0){
	1077	close(p->fd);
	1078	ret = kill(p->pid, SIGTERM);
	1079	if(ret == -1 and errno != ESRCH){
	1080	/* Set-uid proccesses might not get closed */
	1081	perror("kill");
	1082	}
24.1.26 by Björn Påhlsson tally count of used symbols	1083	}
13 by Björn Påhlsson Added following support:	1084	}
13 by Björn Påhlsson Added following support:	1085
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1086	/* Wait for any remaining child processes to terminate */
	1087	do{
	1088	ret = wait(NULL);
	1089	} while(ret >= 0);
	1090	if(errno != ECHILD){
	1091	perror("wait");
	1092	}
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	1093
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	1094	free_plugin_list();
	1095
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	1096	free(plugindir);
	1097	free(argfile);
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1098
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	1099	return exitstatus;
13 by Björn Påhlsson Added following support:	1100	}